inoki-giskard commited on
Commit
27538a2
·
1 Parent(s): 88f768f

Improve dataset validation

Browse files
Files changed (1) hide show
  1. app.py +10 -2
app.py CHANGED
@@ -58,14 +58,22 @@ def try_submit(model_id, dataset_id, dataset_config, dataset_split):
58
  # Validate dataset
59
  d_id, config, split = check_dataset(dataset_id=dataset_id, dataset_config=dataset_config, dataset_split=dataset_split)
60
 
 
61
  if d_id is None:
62
  gr.Warning(f'Dataset "{dataset_id}" is not accessible. Please set your HF_TOKEN if it is a private dataset.')
63
  elif isinstance(config, list):
64
- gr.Warning(f'Dataset "{dataset_id}" does have "{dataset_config}" config. Please choose a valid config.')
65
  config = gr.Dropdown.update(choices=config, value=config[0])
66
  elif isinstance(split, list):
67
- gr.Warning(f'Dataset "{dataset_id}" does have "{dataset_split}" split. Please choose a valid split.')
68
  split = gr.Dropdown.update(choices=split, value=split[0])
 
 
 
 
 
 
 
69
 
70
  return config, split
71
 
 
58
  # Validate dataset
59
  d_id, config, split = check_dataset(dataset_id=dataset_id, dataset_config=dataset_config, dataset_split=dataset_split)
60
 
61
+ dataset_ok = False
62
  if d_id is None:
63
  gr.Warning(f'Dataset "{dataset_id}" is not accessible. Please set your HF_TOKEN if it is a private dataset.')
64
  elif isinstance(config, list):
65
+ gr.Warning(f'Dataset "{dataset_id}" does not have "{dataset_config}" config. Please choose a valid config.')
66
  config = gr.Dropdown.update(choices=config, value=config[0])
67
  elif isinstance(split, list):
68
+ gr.Warning(f'Dataset "{dataset_id}" does not have "{dataset_split}" split. Please choose a valid split.')
69
  split = gr.Dropdown.update(choices=split, value=split[0])
70
+ else:
71
+ dataset_ok = True
72
+
73
+ if not dataset_ok:
74
+ return config, split
75
+
76
+ # TODO: Validate column mapping by running once
77
 
78
  return config, split
79