url
stringlengths 50
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 64
67
| comments_url
stringlengths 59
62
| events_url
stringlengths 57
60
| html_url
stringlengths 38
43
| id
int64 597k
2.65B
| node_id
stringlengths 18
32
| number
int64 1
6.83k
| title
stringlengths 1
296
| user
dict | labels
listlengths 0
5
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
4
| milestone
dict | comments
int64 0
211
| created_at
stringlengths 20
20
| updated_at
stringlengths 20
20
| closed_at
stringlengths 20
20
⌀ | author_association
stringclasses 3
values | active_lock_reason
stringclasses 4
values | body
stringlengths 0
65.6k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 59
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | draft
bool 2
classes | pull_request
dict | is_pull_request
bool 2
classes | issue_comments
sequencelengths 0
30
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/psf/requests/issues/6623 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6623/labels{/name} | https://api.github.com/repos/psf/requests/issues/6623/comments | https://api.github.com/repos/psf/requests/issues/6623/events | https://github.com/psf/requests/pull/6623 | 2,095,154,523 | PR_kwDOABTKOs5kyaJr | 6,623 | handle failure in apparent_encoding gracefully | {
"avatar_url": "https://avatars.githubusercontent.com/u/68711926?v=4",
"events_url": "https://api.github.com/users/dgravitate/events{/privacy}",
"followers_url": "https://api.github.com/users/dgravitate/followers",
"following_url": "https://api.github.com/users/dgravitate/following{/other_user}",
"gists_url": "https://api.github.com/users/dgravitate/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dgravitate",
"id": 68711926,
"login": "dgravitate",
"node_id": "MDQ6VXNlcjY4NzExOTI2",
"organizations_url": "https://api.github.com/users/dgravitate/orgs",
"received_events_url": "https://api.github.com/users/dgravitate/received_events",
"repos_url": "https://api.github.com/users/dgravitate/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dgravitate/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dgravitate/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dgravitate",
"user_view_type": "public"
} | [
{
"color": "e11d21",
"default": false,
"description": null,
"id": 44501305,
"name": "Not Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTMwNQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Not%20Ready%20To%20Merge"
},
{
"color": "e11d21",
"default": false,
"description": null,
"id": 78002701,
"name": "Do Not Merge",
"node_id": "MDU6TGFiZWw3ODAwMjcwMQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Do%20Not%20Merge"
},
{
"color": "e11d21",
"default": false,
"description": null,
"id": 136589914,
"name": "Needs Info",
"node_id": "MDU6TGFiZWwxMzY1ODk5MTQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20Info"
}
] | closed | false | null | [] | null | 2 | 2024-01-23T03:08:43Z | 2024-02-23T00:51:38Z | 2024-02-23T00:51:38Z | NONE | null | Under certain circumstances, we have seen the content of our response come back as a `str` instead of `bytes`. When that happens, and we use `response.text`, the library is throwing a `TypeError`. This PR catches that exception, and lets the `text` property gracefully handle coercing the content to a `str`.
In our case, this happened when we received a `ConnectionError`, however, I believe there may be some other situations where this could occur. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6623/reactions"
} | https://api.github.com/repos/psf/requests/issues/6623/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6623.diff",
"html_url": "https://github.com/psf/requests/pull/6623",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6623.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6623"
} | true | [
"Please we need way more information than you have provided before we could merge this including test cases to ensure that _if_ this is a bug that has gone unreported for nearly a decade, that it doesn't regress.\n\nPlease look at the issue template and provide as much of that detail as possible ",
"Nearly a month with no more explanation of what's going on here that somehow a string is being returned as content. As a result, I'm closing this."
] |
https://api.github.com/repos/psf/requests/issues/6622 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6622/labels{/name} | https://api.github.com/repos/psf/requests/issues/6622/comments | https://api.github.com/repos/psf/requests/issues/6622/events | https://github.com/psf/requests/issues/6622 | 2,085,227,293 | I_kwDOABTKOs58Sgsd | 6,622 | Refresh Test PyPi Package | {
"avatar_url": "https://avatars.githubusercontent.com/u/136826?v=4",
"events_url": "https://api.github.com/users/cmlh/events{/privacy}",
"followers_url": "https://api.github.com/users/cmlh/followers",
"following_url": "https://api.github.com/users/cmlh/following{/other_user}",
"gists_url": "https://api.github.com/users/cmlh/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cmlh",
"id": 136826,
"login": "cmlh",
"node_id": "MDQ6VXNlcjEzNjgyNg==",
"organizations_url": "https://api.github.com/users/cmlh/orgs",
"received_events_url": "https://api.github.com/users/cmlh/received_events",
"repos_url": "https://api.github.com/users/cmlh/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cmlh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cmlh/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cmlh",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2024-01-17T01:28:03Z | 2024-01-17T02:12:14Z | 2024-01-17T01:57:07Z | NONE | null | The Python Package on [TestPyPI has not been updated since 14 March 2015 i.e. 2.5.4.1.](https://test.pypi.org/project/requests/#history) and therefore references the deprecated `python-requests.org`
https://twitter.com/cmlh/status/1747071886029475971 is my recent Twitter thread with @kennethreitz
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6622/reactions"
} | https://api.github.com/repos/psf/requests/issues/6622/timeline | null | not_planned | null | null | false | [
"No. TestPyPI generally should be evicting those after a period of time thus someone is uploading that. Further TestPyPI isn't intended to have any use besides verifying your upload works. Don't install things from there",
"@sigmavirus24 wrote:\r\n> No. TestPyPI generally should be evicting those after a period of time thus someone is uploading that. Further TestPyPI isn't intended to have any use besides verifying your upload works. Don't install things from there\r\n\r\n@dj stated during 2020 that \"[_currently there is no limit to how long releases might remain on TestPyPI_](https://stackoverflow.com/questions/62714907/how-long-does-a-python-package-stay-on-testpypi)\"\r\n\r\nSince the above is technically outside of the control of `requests` then I'll escalate this to https://pypi.org/help/#feedback\r\n"
] |
https://api.github.com/repos/psf/requests/issues/6619 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6619/labels{/name} | https://api.github.com/repos/psf/requests/issues/6619/comments | https://api.github.com/repos/psf/requests/issues/6619/events | https://github.com/psf/requests/pull/6619 | 2,070,879,342 | PR_kwDOABTKOs5jf7XE | 6,619 | Bump github/codeql-action from 3.22.11 to 3.23.0 | {
"avatar_url": "https://avatars.githubusercontent.com/in/29110?v=4",
"events_url": "https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/dependabot%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/dependabot",
"id": 49699333,
"login": "dependabot[bot]",
"node_id": "MDM6Qm90NDk2OTkzMzM=",
"organizations_url": "https://api.github.com/users/dependabot%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/dependabot%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/dependabot%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dependabot%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/dependabot%5Bbot%5D",
"user_view_type": "public"
} | [
{
"color": "0366d6",
"default": false,
"description": "Pull requests that update a dependency file",
"id": 1868210094,
"name": "dependencies",
"node_id": "MDU6TGFiZWwxODY4MjEwMDk0",
"url": "https://api.github.com/repos/psf/requests/labels/dependencies"
},
{
"color": "000000",
"default": false,
"description": "Pull requests that update GitHub Actions code",
"id": 5838729011,
"name": "github_actions",
"node_id": "LA_kwDOABTKOs8AAAABXAPvMw",
"url": "https://api.github.com/repos/psf/requests/labels/github_actions"
}
] | closed | false | null | [] | null | 0 | 2024-01-08T17:01:38Z | 2024-01-08T17:56:02Z | 2024-01-08T17:56:01Z | CONTRIBUTOR | null | Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.22.11 to 3.23.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.23.0 - 08 Jan 2024</h2>
<ul>
<li>We are rolling out a feature in January 2024 that will disable Python dependency installation by default for all users. This improves the speed of analysis while having only a very minor impact on results. You can override this behavior by setting <code>CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION=false</code> in your workflow, however we plan to remove this ability in future versions of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/2031">#2031</a></li>
<li>The CodeQL Action now requires CodeQL version 2.11.6 or later. For more information, see <a href="https://github.com/github/codeql-action/blob/main/#2227---16-nov-2023">the corresponding changelog entry for CodeQL Action version 2.22.7</a>. <a href="https://redirect.github.com/github/codeql-action/pull/2009">#2009</a></li>
</ul>
<h2>3.22.12 - 22 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.5. <a href="https://redirect.github.com/github/codeql-action/pull/2047">#2047</a></li>
</ul>
<h2>3.22.11 - 13 Dec 2023</h2>
<ul>
<li>[v3+ only] The CodeQL Action now runs on Node.js v20. <a href="https://redirect.github.com/github/codeql-action/pull/2006">#2006</a></li>
</ul>
<h2>2.22.10 - 12 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.4. <a href="https://redirect.github.com/github/codeql-action/pull/2016">#2016</a></li>
</ul>
<h2>2.22.9 - 07 Dec 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.8 - 23 Nov 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.3. <a href="https://redirect.github.com/github/codeql-action/pull/2001">#2001</a></li>
</ul>
<h2>2.22.7 - 16 Nov 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.11.5 and earlier. These versions of CodeQL were discontinued on 8 November 2023 alongside GitHub Enterprise Server 3.7, and will be unsupported by CodeQL Action v2.23.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/1993">#1993</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.11.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.10.5 and 2.11.5, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.22.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
</ul>
<h2>2.22.6 - 14 Nov 2023</h2>
<ul>
<li>Customers running Python analysis on macOS using version 2.14.6 or earlier of the CodeQL CLI should upgrade to CodeQL CLI version 2.15.0 or later. If you do not wish to upgrade the CodeQL CLI, ensure that you are using Python version 3.11 or earlier, as CodeQL version 2.14.6 and earlier do not support Python 3.12. You can achieve this by adding a <a href="https://github.com/actions/setup-python"><code>setup-python</code></a> step to your code scanning workflow before the step that invokes <code>github/codeql-action/init</code>.</li>
<li>Update default CodeQL bundle version to 2.15.2. <a href="https://redirect.github.com/github/codeql-action/pull/1978">#1978</a></li>
</ul>
<h2>2.22.5 - 27 Oct 2023</h2>
<p>No user facing changes.</p>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/e5f05b81d5b6ff8cfa111c80c22c5fd02a384118"><code>e5f05b8</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2066">#2066</a> from github/update-v3.23.0-fd55bb0b0</li>
<li><a href="https://github.com/github/codeql-action/commit/48e7b8b751b457ccde050d587c85ce3defc30555"><code>48e7b8b</code></a> Update changelog for v3.23.0</li>
<li><a href="https://github.com/github/codeql-action/commit/fd55bb0b00b5802fdceb93f76b498f105e0edbe1"><code>fd55bb0</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2065">#2065</a> from github/henrymercer/further-run-queries-cleanup</li>
<li><a href="https://github.com/github/codeql-action/commit/838a0229829cd641a4a60fc3c95e12a673b5fcdb"><code>838a022</code></a> Clean up running queries workflow now that the queries are determined by the CLI</li>
<li><a href="https://github.com/github/codeql-action/commit/8516954d603e47049b34f3da4dfac83009fcd450"><code>8516954</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2062">#2062</a> from github/henrymercer/remove-action-config-parsing</li>
<li><a href="https://github.com/github/codeql-action/commit/a533ec62b3aeb59c7467569705b9edaca021df43"><code>a533ec6</code></a> Merge branch 'main' into henrymercer/remove-action-config-parsing</li>
<li><a href="https://github.com/github/codeql-action/commit/08ae9bf4d0d441bd9dcf6c2d80742c9fd2bf3cf0"><code>08ae9bf</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2063">#2063</a> from github/henrymercer/remove-ml-powered-queries-repo</li>
<li><a href="https://github.com/github/codeql-action/commit/58ff74adc38e087ca7f6670dfe24cd319aea5f11"><code>58ff74a</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2031">#2031</a> from github/rasmuswl/no-dep-inst-default</li>
<li><a href="https://github.com/github/codeql-action/commit/9926570d4c48228ba780bd02a18a4e05dbb1bbe7"><code>9926570</code></a> Generate JS</li>
<li><a href="https://github.com/github/codeql-action/commit/2e27b3c56bdb1864f5dd58da25fee61f6cd7bb81"><code>2e27b3c</code></a> Create helper <code>isPythonDependencyInstallationDisabled</code></li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/b374143c1149a9115d881581d29b8390bbcbb59c...e5f05b81d5b6ff8cfa111c80c22c5fd02a384118">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details> | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6619/reactions"
} | https://api.github.com/repos/psf/requests/issues/6619/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6619.diff",
"html_url": "https://github.com/psf/requests/pull/6619",
"merged_at": "2024-01-08T17:56:01Z",
"patch_url": "https://github.com/psf/requests/pull/6619.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6619"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6617 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6617/labels{/name} | https://api.github.com/repos/psf/requests/issues/6617/comments | https://api.github.com/repos/psf/requests/issues/6617/events | https://github.com/psf/requests/pull/6617 | 2,065,138,810 | PR_kwDOABTKOs5jMjqK | 6,617 | Closes #6565; Add documentation to `certs.where`. | {
"avatar_url": "https://avatars.githubusercontent.com/u/87777314?v=4",
"events_url": "https://api.github.com/users/tanrbobanr/events{/privacy}",
"followers_url": "https://api.github.com/users/tanrbobanr/followers",
"following_url": "https://api.github.com/users/tanrbobanr/following{/other_user}",
"gists_url": "https://api.github.com/users/tanrbobanr/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tanrbobanr",
"id": 87777314,
"login": "tanrbobanr",
"node_id": "MDQ6VXNlcjg3Nzc3MzE0",
"organizations_url": "https://api.github.com/users/tanrbobanr/orgs",
"received_events_url": "https://api.github.com/users/tanrbobanr/received_events",
"repos_url": "https://api.github.com/users/tanrbobanr/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tanrbobanr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tanrbobanr/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tanrbobanr",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2024-01-04T07:24:49Z | 2024-01-17T00:18:02Z | 2024-01-17T00:18:02Z | NONE | null | Closes #6565 by adding documentation to `certs.where`. A wrapper was used so that the `__doc__` attribute of `certifi.where` would be preserved, and to allow for greater intellisense coverage. The second issue brought up in #6565 could not be addressed, as the CA-certs default path is only taken from `certs.where`, and can be overridden on a per-instance level of `Session` instances (for example). | {
"avatar_url": "https://avatars.githubusercontent.com/u/87777314?v=4",
"events_url": "https://api.github.com/users/tanrbobanr/events{/privacy}",
"followers_url": "https://api.github.com/users/tanrbobanr/followers",
"following_url": "https://api.github.com/users/tanrbobanr/following{/other_user}",
"gists_url": "https://api.github.com/users/tanrbobanr/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tanrbobanr",
"id": 87777314,
"login": "tanrbobanr",
"node_id": "MDQ6VXNlcjg3Nzc3MzE0",
"organizations_url": "https://api.github.com/users/tanrbobanr/orgs",
"received_events_url": "https://api.github.com/users/tanrbobanr/received_events",
"repos_url": "https://api.github.com/users/tanrbobanr/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tanrbobanr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tanrbobanr/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tanrbobanr",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6617/reactions"
} | https://api.github.com/repos/psf/requests/issues/6617/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6617.diff",
"html_url": "https://github.com/psf/requests/pull/6617",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6617.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6617"
} | true | [
"This addresses only one sliver of that issue, not the core of what they're asking for. ",
"> This addresses only one sliver of that issue, not the core of what they're asking for. \n\nYeah, this is my first PR so I'm kinda new to this. From what I was able to see, the `cacerts_loaded` function would not really be possible unless it was a method of Session, as (to my knowledge) the only way to change the bundle path is through `verify` (a Session argument) and through `merge_environment_settings` (a method of Session), meaning there would be no way to get this information globally (again, to my knowledge)."
] |
https://api.github.com/repos/psf/requests/issues/6616 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6616/labels{/name} | https://api.github.com/repos/psf/requests/issues/6616/comments | https://api.github.com/repos/psf/requests/issues/6616/events | https://github.com/psf/requests/issues/6616 | 2,061,817,916 | I_kwDOABTKOs565Ng8 | 6,616 | sslv3 alert handshake failure | {
"avatar_url": "https://avatars.githubusercontent.com/u/112264612?v=4",
"events_url": "https://api.github.com/users/suryavaddiraju/events{/privacy}",
"followers_url": "https://api.github.com/users/suryavaddiraju/followers",
"following_url": "https://api.github.com/users/suryavaddiraju/following{/other_user}",
"gists_url": "https://api.github.com/users/suryavaddiraju/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/suryavaddiraju",
"id": 112264612,
"login": "suryavaddiraju",
"node_id": "U_kgDOBrEFpA",
"organizations_url": "https://api.github.com/users/suryavaddiraju/orgs",
"received_events_url": "https://api.github.com/users/suryavaddiraju/received_events",
"repos_url": "https://api.github.com/users/suryavaddiraju/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/suryavaddiraju/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suryavaddiraju/subscriptions",
"type": "User",
"url": "https://api.github.com/users/suryavaddiraju",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2024-01-01T23:02:23Z | 2024-02-29T02:38:51Z | 2024-01-02T12:36:52Z | NONE | null | Trying to connect https://www.irctc.co.in using requests module but it raises the ssl error when using requests==2.31.0 but not on when using requests==2.29.0 but have not tried it on v2.30
## Expected Result
The web page html text content
## Actual Result
raise SSLError(e, request=request)
requests.exceptions.SSLError: HTTPSConnectionPool(host='www.irctc.co.in', port=443): Max retries exceeded with url: /nget/train-search (Caused by SSLError(SSLError(1, '[SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:1006)')))
## Reproduction Steps
```python
import requests
r = requests.get("https://www.irctc.co.in/nget/train-search")
print(r.text)
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.12"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.6"
},
"implementation": {
"name": "CPython",
"version": "3.11.7"
},
"platform": {
"release": "10",
"system": "Windows"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.28.0"
},
"system_ssl": {
"version": "300000b0"
},
"urllib3": {
"version": "1.26.18"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 1,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/6616/reactions"
} | https://api.github.com/repos/psf/requests/issues/6616/timeline | null | completed | null | null | false | [
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here.\r\n",
"This (and some similar recent issues reported here) are probably a result of the CVE fix in 2.31.0. I'm seeing the same thing with a system we connect to with Requests, after upgrading to 2.31.0, and the problem goes away on downgrade to 2.30.0, all else remaining the same. It's not yet clear to me exactly what's going wrong from reading either the error message or the release log for 2.31.0, so I'm not sure whether this is misconfig of the system we're trying to connect to (correctly tripping this new CVE fix, and erroring) and Requests is behaving as it should, or if this is a regression in Requests and our systems are fine. Commenting here so others who end up here have some kind of pointer to what's behind this issue, don't yet have enough info to file this as a bug (indeed, it may not be one).",
"Hi @notabeatle,\r\n\r\nNothing should have changed in Requests between those two versions _unless_ you were using a non-`https` scheme and somehow requiring `Proxy-Authorization` being sent beyond your proxy to the destination host. There shouldn't be any standard configuration doing this. You can find the full list of changes [here](https://github.com/psf/requests/compare/v2.30.0...v2.31.0) but I wouldn't expect this to do anything to your TLS handshake.\r\n\r\nYou may want to note which version of urllib3 you're using in each deployment. Requests<=2.29.0 does not use urllib3 2.0 which made a change to stop using a fixed set of ciphers and instead relies on system configuration from OpenSSL.",
"Yep, it's almost certainly that @nateprewitt . Setting a custom SSL context for urllib ended up being the fix. I'm glad, because I was scratching my head, looking at that tiny diff between 2.30 and 2.31 and trying to figure out _how_ that could be the problem.\r\n\r\nHelpful link for anyone else who arrives in this thread: https://quentin.pradet.me/blog/fixing-sslv3_alert_handshake_failure-with-urllib3-20.html"
] |
https://api.github.com/repos/psf/requests/issues/6615 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6615/labels{/name} | https://api.github.com/repos/psf/requests/issues/6615/comments | https://api.github.com/repos/psf/requests/issues/6615/events | https://github.com/psf/requests/issues/6615 | 2,060,746,508 | I_kwDOABTKOs561H8M | 6,615 | How to use multiple redundant hosts | {
"avatar_url": "https://avatars.githubusercontent.com/u/8939758?v=4",
"events_url": "https://api.github.com/users/andy-maier/events{/privacy}",
"followers_url": "https://api.github.com/users/andy-maier/followers",
"following_url": "https://api.github.com/users/andy-maier/following{/other_user}",
"gists_url": "https://api.github.com/users/andy-maier/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/andy-maier",
"id": 8939758,
"login": "andy-maier",
"node_id": "MDQ6VXNlcjg5Mzk3NTg=",
"organizations_url": "https://api.github.com/users/andy-maier/orgs",
"received_events_url": "https://api.github.com/users/andy-maier/received_events",
"repos_url": "https://api.github.com/users/andy-maier/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/andy-maier/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/andy-maier/subscriptions",
"type": "User",
"url": "https://api.github.com/users/andy-maier",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2023-12-30T13:24:51Z | 2024-01-01T12:45:32Z | 2024-01-01T12:45:31Z | NONE | null | I would like to understand whether (and how) it is possible to configure requests to target multiple redundant hosts and to use one of them that is reachable.
Following the guideline to post such help requests in SO, I asked that in https://stackoverflow.com/q/76218020/1424462, and got a response there which so far I did not get to work. So I wanted to ask the maintainers directly. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6615/reactions"
} | https://api.github.com/repos/psf/requests/issues/6615/timeline | null | completed | null | null | false | [
"@andy-maier looking at your StackOverflow question you're saying you don't want to use things that are the standard for achieving this. You don't want to use a load balancer because you don't want a single address (which doesn't make a great deal of sense) but fine. Is there a reason you're not leveraging DNS on your internal network? That would allow you to specify `hmc-service` as a DNS name which resolves to `N` addresses. `urllib3` would then retry those until they find one that works. There's countless StackOverflow questions around using dnsmasq and other free software to do exactly this.\r\n\r\nIn short, none of this is what one would expect of a typical HTTP client library providing the level of interface we provide. And urllib3 isn't exactly the right place for this either. If you want something like this, your issue in the client library is probably the best place because whatever logic you think is \"right\" here probably isn't right for a large enough percentage of requests or urllib3 users.\r\n\r\n---\r\n\r\nPut another way, many things operate in a fashion you're describing - databases with redundant servers as one example. In those cases the client libraries for those things do not rely on the underlying TCP libraries to allow users to specify how to connect/what redundant addresses are they either:\r\n\r\n* Specify it at the client level (e.g., tell the library you want it to behave a [certain way](https://redis-py.readthedocs.io/en/stable/clustering.html) and either tell it the redundant addresses or have the remote service tell you how to find them)\r\n* Specify it another way outside of the library's control (e.g., DNS; if you're on an IaaS that supports IP swapping, have a healthcheck that dynamically swaps the IP address of the thing you're trying to connect to over to one of the healthy redundant hosts; etc.).\r\n\r\n---\r\n\r\nFinally, the answer you received will not work likely because it looks like an AI hallucination to me and the person answering likely doesn't understand what is happening. SOCKS is a proxy protocol that is almost certainly completely unrelated to what you were asking so you don't need that at all. In fact, I'm 99% certain that's an LLM hallucination because the [SOCKS Proxy Manager](https://urllib3.readthedocs.io/en/stable/reference/contrib/socks.html#urllib3.contrib.socks.SOCKSProxyManager) does not have any [`resolver` attribute whatsoever](https://github.com/urllib3/urllib3/blob/main/src/urllib3/contrib/socks.py#L175) and neither does the class it inherits from."
] |
https://api.github.com/repos/psf/requests/issues/6614 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6614/labels{/name} | https://api.github.com/repos/psf/requests/issues/6614/comments | https://api.github.com/repos/psf/requests/issues/6614/events | https://github.com/psf/requests/issues/6614 | 2,055,616,053 | I_kwDOABTKOs56hjY1 | 6,614 | python requests.get() stuck | {
"avatar_url": "https://avatars.githubusercontent.com/u/105736335?v=4",
"events_url": "https://api.github.com/users/mominurr/events{/privacy}",
"followers_url": "https://api.github.com/users/mominurr/followers",
"following_url": "https://api.github.com/users/mominurr/following{/other_user}",
"gists_url": "https://api.github.com/users/mominurr/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mominurr",
"id": 105736335,
"login": "mominurr",
"node_id": "U_kgDOBk1ojw",
"organizations_url": "https://api.github.com/users/mominurr/orgs",
"received_events_url": "https://api.github.com/users/mominurr/received_events",
"repos_url": "https://api.github.com/users/mominurr/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mominurr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mominurr/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mominurr",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
}
] | closed | false | null | [] | null | 1 | 2023-12-25T11:09:00Z | 2023-12-25T15:05:45Z | 2023-12-25T15:05:14Z | NONE | null | url=links[x]
try:
response=requests.get(url,headers=HEADERLISTS,proxies={"http":proxy_lists[prox_index]},timeout=(10,10))
except Exception as e:
print("Error : ",e)
sys.stderr = open('error.log', 'a+', encoding='utf-8')
traceback.print_exc()
sys.stderr.close()
prox_index+=1
time.sleep(1)
continue
if response.status_code==404:
print("status code 404")
prox_index+=1
CURRENT_NUMBER+=1
x+=1
time.sleep(1)
continue
if response.status_code!=200:
print("status code: ",response.status_code)
prox_index+=1
time.sleep(1)
continue
time.sleep(1)
prox_index+=1
CURRENT_NUMBER+=1
x+=1
**This is my code. Script running After sometime response is not comming and get stuck. Next iteration is not going. Please give me solution.** | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6614/reactions"
} | https://api.github.com/repos/psf/requests/issues/6614/timeline | null | not_planned | null | null | false | [
"This doesn't look like a bug with requests library but with your code. Please ask in StackOverflow and using the `python-requests` tag.\r\n\r\n"
] |
https://api.github.com/repos/psf/requests/issues/6613 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6613/labels{/name} | https://api.github.com/repos/psf/requests/issues/6613/comments | https://api.github.com/repos/psf/requests/issues/6613/events | https://github.com/psf/requests/pull/6613 | 2,054,848,194 | PR_kwDOABTKOs5is0Uk | 6,613 | docs: add label to socks heading | {
"avatar_url": "https://avatars.githubusercontent.com/u/529516?v=4",
"events_url": "https://api.github.com/users/miketheman/events{/privacy}",
"followers_url": "https://api.github.com/users/miketheman/followers",
"following_url": "https://api.github.com/users/miketheman/following{/other_user}",
"gists_url": "https://api.github.com/users/miketheman/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/miketheman",
"id": 529516,
"login": "miketheman",
"node_id": "MDQ6VXNlcjUyOTUxNg==",
"organizations_url": "https://api.github.com/users/miketheman/orgs",
"received_events_url": "https://api.github.com/users/miketheman/received_events",
"repos_url": "https://api.github.com/users/miketheman/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/miketheman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/miketheman/subscriptions",
"type": "User",
"url": "https://api.github.com/users/miketheman",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 0 | 2023-12-23T17:19:45Z | 2023-12-23T17:25:22Z | 2023-12-23T17:24:56Z | MEMBER | null | When trying to link via intersphinx, a label must be used. Otherwise a full URL is required, which is less desirable.
Alternately, the project could attempt to use [`sphinx.ext.autosectionlabel`](https://www.sphinx-doc.org/en/master/usage/extensions/autosectionlabel.html), but that felt too heavy-handed for right now. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6613/reactions"
} | https://api.github.com/repos/psf/requests/issues/6613/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6613.diff",
"html_url": "https://github.com/psf/requests/pull/6613",
"merged_at": "2023-12-23T17:24:56Z",
"patch_url": "https://github.com/psf/requests/pull/6613.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6613"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6612 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6612/labels{/name} | https://api.github.com/repos/psf/requests/issues/6612/comments | https://api.github.com/repos/psf/requests/issues/6612/events | https://github.com/psf/requests/pull/6612 | 2,054,833,478 | PR_kwDOABTKOs5isxiO | 6,612 | docs: specify sphinx dirhtml builder, use references instead of absolutes | {
"avatar_url": "https://avatars.githubusercontent.com/u/529516?v=4",
"events_url": "https://api.github.com/users/miketheman/events{/privacy}",
"followers_url": "https://api.github.com/users/miketheman/followers",
"following_url": "https://api.github.com/users/miketheman/following{/other_user}",
"gists_url": "https://api.github.com/users/miketheman/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/miketheman",
"id": 529516,
"login": "miketheman",
"node_id": "MDQ6VXNlcjUyOTUxNg==",
"organizations_url": "https://api.github.com/users/miketheman/orgs",
"received_events_url": "https://api.github.com/users/miketheman/received_events",
"repos_url": "https://api.github.com/users/miketheman/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/miketheman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/miketheman/subscriptions",
"type": "User",
"url": "https://api.github.com/users/miketheman",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 5 | 2023-12-23T16:20:11Z | 2023-12-23T18:35:43Z | 2023-12-23T18:33:48Z | MEMBER | null | With the requirement of a configuration file, the default builder of `dirhtml` that RTD used to use is no longer specified. This leads to URLs ending in `.html` now, which
breaks other exisitng references.
Refs: #6603
Refs: https://docs.readthedocs.io/en/stable/config-file/v2.html#sphinx-builder
Refs: https://www.sphinx-doc.org/en/master/usage/builders/index.html#sphinx.builders.dirhtml.DirectoryHTMLBuilder | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6612/reactions"
} | https://api.github.com/repos/psf/requests/issues/6612/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6612.diff",
"html_url": "https://github.com/psf/requests/pull/6612",
"merged_at": "2023-12-23T18:33:48Z",
"patch_url": "https://github.com/psf/requests/pull/6612.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6612"
} | true | [
"One example:\r\n\r\nhttps://requests.readthedocs.io/en/latest/user/advanced.html#socks\r\nvs\r\nhttps://requests--6612.org.readthedocs.build/en/6612/user/advanced/#socks",
"Probably should revert https://github.com/psf/requests/issues/6604 as well",
"Please do include a revert of that PR in here. I didn't get a chance to object to it",
"Revert added",
"Added references instead of absolutes, so these shouldn't ever need to be changed despite the builder chosen."
] |
https://api.github.com/repos/psf/requests/issues/6611 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6611/labels{/name} | https://api.github.com/repos/psf/requests/issues/6611/comments | https://api.github.com/repos/psf/requests/issues/6611/events | https://github.com/psf/requests/issues/6611 | 2,054,443,900 | I_kwDOABTKOs56dFN8 | 6,611 | Unexpected `UnicodeError` on some URL | {
"avatar_url": "https://avatars.githubusercontent.com/u/37775?v=4",
"events_url": "https://api.github.com/users/catap/events{/privacy}",
"followers_url": "https://api.github.com/users/catap/followers",
"following_url": "https://api.github.com/users/catap/following{/other_user}",
"gists_url": "https://api.github.com/users/catap/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/catap",
"id": 37775,
"login": "catap",
"node_id": "MDQ6VXNlcjM3Nzc1",
"organizations_url": "https://api.github.com/users/catap/orgs",
"received_events_url": "https://api.github.com/users/catap/received_events",
"repos_url": "https://api.github.com/users/catap/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/catap/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/catap/subscriptions",
"type": "User",
"url": "https://api.github.com/users/catap",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2023-12-22T19:42:09Z | 2024-01-02T12:42:58Z | 2024-01-02T12:42:58Z | NONE | null | Seems that `requests` haven't handle well some url which `curl` handle quite well.
## Expected Result
Should work.
## Actual Result
Crashed as `UnicodeError: label empty or too long`
## Reproduction Steps
```python
import requests
requests.get("https://www.elyricsworld.com/go.php?url=http://894763313no67.%D1%86%D0%B5%D0%BD%D1%82%D1%80-%D1%81%D1%82%D1%80%D0%B0%D1%85%D0%BE%D0%B2%D0%B0%D0%BD%D0%B8%D1%8F-%D0%BE%D0%BD%D0%BB%D0%B0%D0%B9%D0%BD.%D1%80%D1%84")
```
## System Information
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": "41.0.5"
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "CPython",
"version": "3.10.13"
},
"platform": {
"release": "21.6.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "30100040",
"version": "23.2.0"
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "30200000"
},
"urllib3": {
"version": "1.26.18"
},
"using_charset_normalizer": true,
"using_pyopenssl": true
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6611/reactions"
} | https://api.github.com/repos/psf/requests/issues/6611/timeline | null | completed | null | null | false | [
"I want to work on this, it would be great if anyone assign this to me!",
"Duplicate of #6026 #4187 and many others"
] |
https://api.github.com/repos/psf/requests/issues/6610 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6610/labels{/name} | https://api.github.com/repos/psf/requests/issues/6610/comments | https://api.github.com/repos/psf/requests/issues/6610/events | https://github.com/psf/requests/issues/6610 | 2,052,308,657 | I_kwDOABTKOs56U76x | 6,610 | I don't think the name of this function is appropriate, because the return value of this function is a ConnectionPool object, and the first sentence of the comment is also wrong, which makes it a huge difficulty for me to read!! | {
"avatar_url": "https://avatars.githubusercontent.com/u/43978320?v=4",
"events_url": "https://api.github.com/users/gitlGl/events{/privacy}",
"followers_url": "https://api.github.com/users/gitlGl/followers",
"following_url": "https://api.github.com/users/gitlGl/following{/other_user}",
"gists_url": "https://api.github.com/users/gitlGl/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gitlGl",
"id": 43978320,
"login": "gitlGl",
"node_id": "MDQ6VXNlcjQzOTc4MzIw",
"organizations_url": "https://api.github.com/users/gitlGl/orgs",
"received_events_url": "https://api.github.com/users/gitlGl/received_events",
"repos_url": "https://api.github.com/users/gitlGl/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gitlGl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gitlGl/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gitlGl",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2023-12-21T12:11:29Z | 2023-12-21T12:53:12Z | 2023-12-21T12:53:12Z | NONE | null | def get_connection(self, url, proxies=None):
"""Returns a urllib3 connection for the given URL. This should not be
called from user code, and is only exposed for use when subclassing the
:class:`HTTPAdapter <requests.adapters.HTTPAdapter>`.
:param url: The URL to connect to.
:param proxies: (optional) A Requests-style dictionary of proxies used on this request.
:rtype: urllib3.ConnectionPool
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 2,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 2,
"url": "https://api.github.com/repos/psf/requests/issues/6610/reactions"
} | https://api.github.com/repos/psf/requests/issues/6610/timeline | null | not_planned | null | null | false | [
"adapters.HTTPAdapter.get_connection",
"You're right. As documented we are returning a connection pool which behaves almost identically to a connection. Alas, that method and that contract has existed for over a decade at this point, so we will not be changing it"
] |
https://api.github.com/repos/psf/requests/issues/6609 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6609/labels{/name} | https://api.github.com/repos/psf/requests/issues/6609/comments | https://api.github.com/repos/psf/requests/issues/6609/events | https://github.com/psf/requests/pull/6609 | 2,050,936,243 | PR_kwDOABTKOs5iffXk | 6,609 | refc: remove the if else statement and add redable format. | {
"avatar_url": "https://avatars.githubusercontent.com/u/105969316?v=4",
"events_url": "https://api.github.com/users/Krupeshgithub/events{/privacy}",
"followers_url": "https://api.github.com/users/Krupeshgithub/followers",
"following_url": "https://api.github.com/users/Krupeshgithub/following{/other_user}",
"gists_url": "https://api.github.com/users/Krupeshgithub/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Krupeshgithub",
"id": 105969316,
"login": "Krupeshgithub",
"node_id": "U_kgDOBlD2pA",
"organizations_url": "https://api.github.com/users/Krupeshgithub/orgs",
"received_events_url": "https://api.github.com/users/Krupeshgithub/received_events",
"repos_url": "https://api.github.com/users/Krupeshgithub/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Krupeshgithub/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Krupeshgithub/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Krupeshgithub",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2023-12-20T16:53:14Z | 2023-12-20T17:45:29Z | 2023-12-20T17:45:29Z | NONE | null | `
data = [] if data is None else data
`
This statement is little bit complex to read. It's not readable.
`
data = [] or data
`
In the above statement if data is `None` then data store list but if there anything found in the data so, data some store value. It is readable format. | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6609/reactions"
} | https://api.github.com/repos/psf/requests/issues/6609/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6609.diff",
"html_url": "https://github.com/psf/requests/pull/6609",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6609.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6609"
} | true | [
"These are not semantically equivalent statements. This would be a breaking change so we won't be able to accept it."
] |
https://api.github.com/repos/psf/requests/issues/6607 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6607/labels{/name} | https://api.github.com/repos/psf/requests/issues/6607/comments | https://api.github.com/repos/psf/requests/issues/6607/events | https://github.com/psf/requests/pull/6607 | 2,047,043,886 | PR_kwDOABTKOs5iSL7J | 6,607 | Bump github/codeql-action from 2.22.1 to 3.22.11 | {
"avatar_url": "https://avatars.githubusercontent.com/in/29110?v=4",
"events_url": "https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/dependabot%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/dependabot",
"id": 49699333,
"login": "dependabot[bot]",
"node_id": "MDM6Qm90NDk2OTkzMzM=",
"organizations_url": "https://api.github.com/users/dependabot%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/dependabot%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/dependabot%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dependabot%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/dependabot%5Bbot%5D",
"user_view_type": "public"
} | [
{
"color": "0366d6",
"default": false,
"description": "Pull requests that update a dependency file",
"id": 1868210094,
"name": "dependencies",
"node_id": "MDU6TGFiZWwxODY4MjEwMDk0",
"url": "https://api.github.com/repos/psf/requests/labels/dependencies"
},
{
"color": "000000",
"default": false,
"description": "Pull requests that update GitHub Actions code",
"id": 5838729011,
"name": "github_actions",
"node_id": "LA_kwDOABTKOs8AAAABXAPvMw",
"url": "https://api.github.com/repos/psf/requests/labels/github_actions"
}
] | closed | false | null | [] | null | 0 | 2023-12-18T16:39:48Z | 2023-12-18T17:30:44Z | 2023-12-18T17:30:43Z | CONTRIBUTOR | null | Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.1 to 3.22.11.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.22.11 - 13 Dec 2023</h2>
<ul>
<li>[v3+ only] The CodeQL Action now runs on Node.js v20. <a href="https://redirect.github.com/github/codeql-action/pull/2006">#2006</a></li>
</ul>
<h2>2.22.10 - 12 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.4. <a href="https://redirect.github.com/github/codeql-action/pull/2016">#2016</a></li>
</ul>
<h2>2.22.9 - 07 Dec 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.8 - 23 Nov 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.3. <a href="https://redirect.github.com/github/codeql-action/pull/2001">#2001</a></li>
</ul>
<h2>2.22.7 - 16 Nov 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.11.5 and earlier. These versions of CodeQL were discontinued on 8 November 2023 alongside GitHub Enterprise Server 3.7, and will be unsupported by CodeQL Action v2.23.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/1993">#1993</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.11.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.10.5 and 2.11.5, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.22.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
</ul>
<h2>2.22.6 - 14 Nov 2023</h2>
<ul>
<li>Customers running Python analysis on macOS using version 2.14.6 or earlier of the CodeQL CLI should upgrade to CodeQL CLI version 2.15.0 or later. If you do not wish to upgrade the CodeQL CLI, ensure that you are using Python version 3.11 or earlier, as CodeQL version 2.14.6 and earlier do not support Python 3.12. You can achieve this by adding a <a href="https://github.com/actions/setup-python"><code>setup-python</code></a> step to your code scanning workflow before the step that invokes <code>github/codeql-action/init</code>.</li>
<li>Update default CodeQL bundle version to 2.15.2. <a href="https://redirect.github.com/github/codeql-action/pull/1978">#1978</a></li>
</ul>
<h2>2.22.5 - 27 Oct 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.4 - 20 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/1953">#1953</a></li>
<li>Users will begin to see warnings on Node.js 16 deprecation in their Actions logs on code scanning runs starting October 23, 2023.
<ul>
<li>All code scanning workflows should continue to succeed regardless of the warning.</li>
<li>The team at GitHub maintaining the CodeQL Action is aware of the deprecation timeline and actively working on creating another version of the CodeQL Action, v3, that will bump us to Node 20.</li>
<li>For more information, and to communicate with the maintaining team, please use <a href="https://redirect.github.com/github/codeql-action/issues/1959">this issue</a>.</li>
</ul>
</li>
</ul>
<h2>2.22.3 - 13 Oct 2023</h2>
<ul>
<li>Provide an authentication token when downloading the CodeQL Bundle from the API of a GitHub Enterprise Server instance. <a href="https://redirect.github.com/github/codeql-action/pull/1945">#1945</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/b374143c1149a9115d881581d29b8390bbcbb59c"><code>b374143</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2034">#2034</a> from github/update-v3.22.11-64e61baea</li>
<li><a href="https://github.com/github/codeql-action/commit/e2b5cc75ce46a4a33dbafa57e19019d6bd5a67be"><code>e2b5cc7</code></a> Update changelog for v3.22.11</li>
<li><a href="https://github.com/github/codeql-action/commit/64e61baeac852f409b48440cebec029a2d978f90"><code>64e61ba</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2006">#2006</a> from github/nickfyson/node-20</li>
<li><a href="https://github.com/github/codeql-action/commit/c757f9f6de6bebddbc274b26f9282d0199ab0512"><code>c757f9f</code></a> Apply suggestions from code review</li>
<li><a href="https://github.com/github/codeql-action/commit/7898bc2041d7b0bc5e6f97169b127ff75eee02f2"><code>7898bc2</code></a> add pr check for node version consistency</li>
<li><a href="https://github.com/github/codeql-action/commit/6b5b95806324a3ee7e164709fbfc152595556fe9"><code>6b5b958</code></a> remove dedundant single quotes from node version strings</li>
<li><a href="https://github.com/github/codeql-action/commit/ea1e72c6697fe8b190253b561a93508e587ea209"><code>ea1e72c</code></a> Update .github/workflows/pr-checks.yml</li>
<li><a href="https://github.com/github/codeql-action/commit/b974542e9f06e790793093fb5d47fc462c0d20bf"><code>b974542</code></a> Merge branch 'main' into nickfyson/node-20</li>
<li><a href="https://github.com/github/codeql-action/commit/b995212303c9b90cac695cf6c0b558f54fb613f6"><code>b995212</code></a> Bump the actions group with 2 updates (<a href="https://redirect.github.com/github/codeql-action/issues/2024">#2024</a>)</li>
<li><a href="https://github.com/github/codeql-action/commit/3c1878d8f9d642687f3f2ba76af5406aa16ce232"><code>3c1878d</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2029">#2029</a> from github/mergeback/v2.22.10-to-main-305f6546</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/fdcae64e1484d349b3366718cdfef3d404390e85...b374143c1149a9115d881581d29b8390bbcbb59c">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details> | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6607/reactions"
} | https://api.github.com/repos/psf/requests/issues/6607/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6607.diff",
"html_url": "https://github.com/psf/requests/pull/6607",
"merged_at": "2023-12-18T17:30:43Z",
"patch_url": "https://github.com/psf/requests/pull/6607.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6607"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6606 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6606/labels{/name} | https://api.github.com/repos/psf/requests/issues/6606/comments | https://api.github.com/repos/psf/requests/issues/6606/events | https://github.com/psf/requests/pull/6606 | 2,045,393,077 | PR_kwDOABTKOs5iMkad | 6,606 | Update http status code 103 and 508 | {
"avatar_url": "https://avatars.githubusercontent.com/u/35526514?v=4",
"events_url": "https://api.github.com/users/jaikishpai/events{/privacy}",
"followers_url": "https://api.github.com/users/jaikishpai/followers",
"following_url": "https://api.github.com/users/jaikishpai/following{/other_user}",
"gists_url": "https://api.github.com/users/jaikishpai/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jaikishpai",
"id": 35526514,
"login": "jaikishpai",
"node_id": "MDQ6VXNlcjM1NTI2NTE0",
"organizations_url": "https://api.github.com/users/jaikishpai/orgs",
"received_events_url": "https://api.github.com/users/jaikishpai/received_events",
"repos_url": "https://api.github.com/users/jaikishpai/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jaikishpai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jaikishpai/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jaikishpai",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2023-12-17T22:01:38Z | 2023-12-17T22:07:03Z | 2023-12-17T22:07:03Z | CONTRIBUTOR | null | Added additional definition for `103` status code and added `508` http status code | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6606/reactions"
} | https://api.github.com/repos/psf/requests/issues/6606/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6606.diff",
"html_url": "https://github.com/psf/requests/pull/6606",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6606.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6606"
} | true | [
"Thanks for the PR @jaikishpai. However, I think we're unlikely to accept this. 103 is still experimental as per RFC 8297 and 508 is a WebDAV specific status code which we won't be supporting."
] |
https://api.github.com/repos/psf/requests/issues/6605 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6605/labels{/name} | https://api.github.com/repos/psf/requests/issues/6605/comments | https://api.github.com/repos/psf/requests/issues/6605/events | https://github.com/psf/requests/pull/6605 | 2,045,385,500 | PR_kwDOABTKOs5iMi5i | 6,605 | fix for ##6604 | {
"avatar_url": "https://avatars.githubusercontent.com/u/35526514?v=4",
"events_url": "https://api.github.com/users/jaikishpai/events{/privacy}",
"followers_url": "https://api.github.com/users/jaikishpai/followers",
"following_url": "https://api.github.com/users/jaikishpai/following{/other_user}",
"gists_url": "https://api.github.com/users/jaikishpai/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jaikishpai",
"id": 35526514,
"login": "jaikishpai",
"node_id": "MDQ6VXNlcjM1NTI2NTE0",
"organizations_url": "https://api.github.com/users/jaikishpai/orgs",
"received_events_url": "https://api.github.com/users/jaikishpai/received_events",
"repos_url": "https://api.github.com/users/jaikishpai/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jaikishpai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jaikishpai/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jaikishpai",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 0 | 2023-12-17T21:36:12Z | 2023-12-20T09:25:09Z | 2023-12-20T06:17:56Z | CONTRIBUTOR | null | updated the links to fix #6604 | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6605/reactions"
} | https://api.github.com/repos/psf/requests/issues/6605/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6605.diff",
"html_url": "https://github.com/psf/requests/pull/6605",
"merged_at": "2023-12-20T06:17:55Z",
"patch_url": "https://github.com/psf/requests/pull/6605.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6605"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6604 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6604/labels{/name} | https://api.github.com/repos/psf/requests/issues/6604/comments | https://api.github.com/repos/psf/requests/issues/6604/events | https://github.com/psf/requests/issues/6604 | 2,045,076,597 | I_kwDOABTKOs555WR1 | 6,604 | Links at docs site return 404 | {
"avatar_url": "https://avatars.githubusercontent.com/u/27302114?v=4",
"events_url": "https://api.github.com/users/mishankov/events{/privacy}",
"followers_url": "https://api.github.com/users/mishankov/followers",
"following_url": "https://api.github.com/users/mishankov/following{/other_user}",
"gists_url": "https://api.github.com/users/mishankov/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mishankov",
"id": 27302114,
"login": "mishankov",
"node_id": "MDQ6VXNlcjI3MzAyMTE0",
"organizations_url": "https://api.github.com/users/mishankov/orgs",
"received_events_url": "https://api.github.com/users/mishankov/received_events",
"repos_url": "https://api.github.com/users/mishankov/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mishankov/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mishankov/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mishankov",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 3 | 2023-12-17T06:33:58Z | 2023-12-20T06:21:54Z | 2023-12-20T06:21:53Z | NONE | null | At https://requests.readthedocs.io/en/latest/ all links under "Usefull links" lead to 404 page
## Expected Result
Open corresponding docs page
## Actual Result
404 page
## Reproduction Steps
- Open https://requests.readthedocs.io/en/latest/
- Click on "[Quickstart](https://requests.readthedocs.io/en/latest/user/quickstart/)"
## System Information
Not applicable
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 2,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 2,
"url": "https://api.github.com/repos/psf/requests/issues/6604/reactions"
} | https://api.github.com/repos/psf/requests/issues/6604/timeline | null | completed | null | null | false | [
"Looks like `.html` at the end of link is what's missing",
"Working on it.",
"Resolved in #6605."
] |
https://api.github.com/repos/psf/requests/issues/6603 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6603/labels{/name} | https://api.github.com/repos/psf/requests/issues/6603/comments | https://api.github.com/repos/psf/requests/issues/6603/events | https://github.com/psf/requests/pull/6603 | 2,044,364,974 | PR_kwDOABTKOs5iJR8g | 6,603 | Add now mandatory readthedocs config file | {
"avatar_url": "https://avatars.githubusercontent.com/u/4924623?v=4",
"events_url": "https://api.github.com/users/nsoranzo/events{/privacy}",
"followers_url": "https://api.github.com/users/nsoranzo/followers",
"following_url": "https://api.github.com/users/nsoranzo/following{/other_user}",
"gists_url": "https://api.github.com/users/nsoranzo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nsoranzo",
"id": 4924623,
"login": "nsoranzo",
"node_id": "MDQ6VXNlcjQ5MjQ2MjM=",
"organizations_url": "https://api.github.com/users/nsoranzo/orgs",
"received_events_url": "https://api.github.com/users/nsoranzo/received_events",
"repos_url": "https://api.github.com/users/nsoranzo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nsoranzo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nsoranzo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nsoranzo",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2023-12-15T21:01:43Z | 2024-01-29T16:36:27Z | 2023-12-16T13:24:37Z | CONTRIBUTOR | null | Docs builds currently fail with:
```
Problem in your project's configuration. No default configuration file found at repository's root. See https://docs.readthedocs.io/en/stable/config-file/
```
See e.g. https://readthedocs.org/projects/requests/builds/22842479/ | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6603/reactions"
} | https://api.github.com/repos/psf/requests/issues/6603/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6603.diff",
"html_url": "https://github.com/psf/requests/pull/6603",
"merged_at": "2023-12-16T13:24:37Z",
"patch_url": "https://github.com/psf/requests/pull/6603.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6603"
} | true | [
"Thank you @nsoranzo !"
] |
https://api.github.com/repos/psf/requests/issues/6602 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6602/labels{/name} | https://api.github.com/repos/psf/requests/issues/6602/comments | https://api.github.com/repos/psf/requests/issues/6602/events | https://github.com/psf/requests/issues/6602 | 2,042,756,520 | I_kwDOABTKOs55wf2o | 6,602 | the first response history url is incorrect | {
"avatar_url": "https://avatars.githubusercontent.com/u/5090914?v=4",
"events_url": "https://api.github.com/users/xtremebeing/events{/privacy}",
"followers_url": "https://api.github.com/users/xtremebeing/followers",
"following_url": "https://api.github.com/users/xtremebeing/following{/other_user}",
"gists_url": "https://api.github.com/users/xtremebeing/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/xtremebeing",
"id": 5090914,
"login": "xtremebeing",
"node_id": "MDQ6VXNlcjUwOTA5MTQ=",
"organizations_url": "https://api.github.com/users/xtremebeing/orgs",
"received_events_url": "https://api.github.com/users/xtremebeing/received_events",
"repos_url": "https://api.github.com/users/xtremebeing/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/xtremebeing/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xtremebeing/subscriptions",
"type": "User",
"url": "https://api.github.com/users/xtremebeing",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2023-12-15T01:50:08Z | 2023-12-20T08:09:58Z | 2023-12-20T06:32:20Z | NONE | null | <!-- Summary. -->
The first url returned from response.url is different than the url passed to requests.get
## Expected Result
<!-- What you expected. -->
I expected the first history url to be that same as passed into requests.get
```
Redirect #1
URL: http://google.com
```
## Actual Result
The first redirected url is always the same as the the first response.headers.get('Location')
```python resp.py
requests.__version__ 2.31.0
initial url: http://google.com
Redirect #1
URL: http://google.com/
Status Code: 301
Redirect: http://www.google.com/
Redirect #2
URL: http://www.google.com/
Status Code: 302
Redirect: https://www.google.com/?gws_rd=ssl
URL: https://www.google.com/?gws_rd=ssl
Status Code: 200
Redirect: None
```
<!-- What happened instead. -->
## Reproduction Steps
```python
import requests
url = "http://google.com"
headers = {
"User-Agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36"
}
response = requests.get(url, headers=headers, allow_redirects=True)
print(f"requests.__version__ {requests.__version__}")
print(f"initial url: {url}\n")
for index, resp in enumerate(response.history, start=1):
print(f"Redirect #{index}")
print(f"URL: {resp.url}")
print(f"Status Code: {resp.status_code}")
print(f"Redirect: {resp.headers.get('Location')}\n")
print(f"URL: {response.url}")
print(f"Status Code: {response.status_code}")
print(f"Redirect: {response.headers.get('Location')}")
```
## System Information
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.6"
},
"implementation": {
"name": "CPython",
"version": "3.10.12"
},
"platform": {
"release": "22.6.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "1010115f"
},
"urllib3": {
"version": "2.0.7"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6602/reactions"
} | https://api.github.com/repos/psf/requests/issues/6602/timeline | null | completed | null | null | false | [
"Hi @xtremebeing,\r\n\r\nI'm assuming you're referring to the trailing `/` in `https://google.com/`? That's a standard semantic of url normalization, and is identical to what you provided. This should be treated the same by a properly functioning server.\r\n\r\n> In general, a URI that uses the generic syntax for authority with an\r\n empty path should be normalized to a path of \"/\".\r\n\r\n\\- [RFC 3986 6.2.3](https://datatracker.ietf.org/doc/html/rfc3986#section-6.2.3)\r\n\r\nYou may try setting the URL again with the [PreparedRequest workflow](https://requests.readthedocs.io/en/latest/user/advanced.html#prepared-requests), but my hunch without having looked is this is happening in urllib3. If that's the case, this won't be adjustable."
] |
https://api.github.com/repos/psf/requests/issues/6601 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6601/labels{/name} | https://api.github.com/repos/psf/requests/issues/6601/comments | https://api.github.com/repos/psf/requests/issues/6601/events | https://github.com/psf/requests/issues/6601 | 2,039,794,795 | I_kwDOABTKOs55lMxr | 6,601 | Since migration of urllib3 to 2.x data-strings with umlauts in a post request are truncated | {
"avatar_url": "https://avatars.githubusercontent.com/u/102509141?v=4",
"events_url": "https://api.github.com/users/secorvo-jen/events{/privacy}",
"followers_url": "https://api.github.com/users/secorvo-jen/followers",
"following_url": "https://api.github.com/users/secorvo-jen/following{/other_user}",
"gists_url": "https://api.github.com/users/secorvo-jen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/secorvo-jen",
"id": 102509141,
"login": "secorvo-jen",
"node_id": "U_kgDOBhwqVQ",
"organizations_url": "https://api.github.com/users/secorvo-jen/orgs",
"received_events_url": "https://api.github.com/users/secorvo-jen/received_events",
"repos_url": "https://api.github.com/users/secorvo-jen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/secorvo-jen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/secorvo-jen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/secorvo-jen",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2023-12-13T14:09:36Z | 2023-12-13T23:39:10Z | 2023-12-13T23:39:10Z | NONE | null | Before requests 2.30 it was possible to just pass a Python-string with umlauts (äöü...) to a `requests.post` call. Since urllib3 2.x this causes the body of the request to be truncated. It seems that the Content-Length is calculated based on the length of the string and the string itself is handed over to the call as a multibyte representation causing the string to be truncated in the request because with multibyte characters there are more bytes than characters.
## Expected Result
All characters of the input string should have been sent to the target.
## Actual Result
Input string is truncated. See output of code below:
```
data:application/octet-stream;base64,RGFzIHNpbmQgUG9zdC1EYXRlbiBtaXQgVW1sYXV0ZW46IMOkww==
data:application/octet-stream;base64,RGFzIHNpbmQgUG9zdC1EYXRlbiBtaXQgVW1sYXV0ZW46IOT89g==
Das sind Post-Daten mit Umlauten: äüö
```
## Reproduction Steps
```python
import requests
import json
data_as_string = "Das sind Post-Daten mit Umlauten: äüö"
data_array = [
data_as_string,
bytes(data_as_string,'iso-8859-1'),
bytes(data_as_string,'utf-8')
]
post_url = "https://httpbin.org/post"
headers = {
"Content-Type": "text/plain",
"Host": "httpbin.org",
}
def main():
for d in data_array:
response = requests.post(
url=post_url,
headers=headers,
data=d
)
r = json.loads(response.content)
print(r['data'])
if __name__ == '__main__':
main()
```
The behaviour was also verified using Portswigger Burp Suite:
First Request:
```
50 4F 53 54 20 2F 70 6F 73 74 20 48 54 54 50 2F 32 0D 0A 48 6F 73 74 3A 20 68 74 74 70 62 69 6E 2E 6F 72 67 0D 0A 55 73 65 72 2D 41 67 65 6E 74 3A 20 70 79 74 68 6F 6E 2D 72 65 71 75 65 73 74 73 2F 32 2E 33 31 2E 30 0D 0A 41 63 63 65 70 74 2D 45 6E 63 6F 64 69 6E 67 3A 20 67 7A 69 70 2C 20 64 65 66 6C 61 74 65 2C 20 62 72 0D 0A 41 63 63 65 70 74 3A 20 2A 2F 2A 0D 0A 43 6F 6E 6E 65 63 74 69 6F 6E 3A 20 63 6C 6F 73 65 0D 0A 43 6F 6E 74 65 6E 74 2D 54 79 70 65 3A 20 74 65 78 74 2F 70 6C 61 69 6E 0D 0A 43 6F 6E 74 65 6E 74 2D 4C 65 6E 67 74 68 3A 20 33 37 0D 0A 0D 0A 44 61 73 20 73 69 6E 64 20 50 6F 73 74 2D 44 61 74 65 6E 20 6D 69 74 20 55 6D 6C 61 75 74 65 6E 3A 20 C3 A4 C3
```
```
POST /post HTTP/2
Host: httpbin.org
User-Agent: python-requests/2.31.0
Accept-Encoding: gzip, deflate, br
Accept: */*
Connection: close
Content-Type: text/plain
Content-Length: 37
Das sind Post-Daten mit Umlauten: äÃ
```
Second Request:
```
50 4F 53 54 20 2F 70 6F 73 74 20 48 54 54 50 2F 32 0D 0A 48 6F 73 74 3A 20 68 74 74 70 62 69 6E 2E 6F 72 67 0D 0A 55 73 65 72 2D 41 67 65 6E 74 3A 20 70 79 74 68 6F 6E 2D 72 65 71 75 65 73 74 73 2F 32 2E 33 31 2E 30 0D 0A 41 63 63 65 70 74 2D 45 6E 63 6F 64 69 6E 67 3A 20 67 7A 69 70 2C 20 64 65 66 6C 61 74 65 2C 20 62 72 0D 0A 41 63 63 65 70 74 3A 20 2A 2F 2A 0D 0A 43 6F 6E 6E 65 63 74 69 6F 6E 3A 20 6B 65 65 70 2D 61 6C 69 76 65 0D 0A 43 6F 6E 74 65 6E 74 2D 54 79 70 65 3A 20 74 65 78 74 2F 70 6C 61 69 6E 0D 0A 43 6F 6E 74 65 6E 74 2D 4C 65 6E 67 74 68 3A 20 33 37 0D 0A 0D 0A 44 61 73 20 73 69 6E 64 20 50 6F 73 74 2D 44 61 74 65 6E 20 6D 69 74 20 55 6D 6C 61 75 74 65 6E 3A 20 E4 FC F6
```
```
POST /post HTTP/2
Host: httpbin.org
User-Agent: python-requests/2.31.0
Accept-Encoding: gzip, deflate, br
Accept: */*
Connection: keep-alive
Content-Type: text/plain
Content-Length: 37
Das sind Post-Daten mit Umlauten: äüö
```
Third Request:
```
50 4F 53 54 20 2F 70 6F 73 74 20 48 54 54 50 2F 32 0D 0A 48 6F 73 74 3A 20 68 74 74 70 62 69 6E 2E 6F 72 67 0D 0A 55 73 65 72 2D 41 67 65 6E 74 3A 20 70 79 74 68 6F 6E 2D 72 65 71 75 65 73 74 73 2F 32 2E 33 31 2E 30 0D 0A 41 63 63 65 70 74 2D 45 6E 63 6F 64 69 6E 67 3A 20 67 7A 69 70 2C 20 64 65 66 6C 61 74 65 2C 20 62 72 0D 0A 41 63 63 65 70 74 3A 20 2A 2F 2A 0D 0A 43 6F 6E 6E 65 63 74 69 6F 6E 3A 20 6B 65 65 70 2D 61 6C 69 76 65 0D 0A 43 6F 6E 74 65 6E 74 2D 54 79 70 65 3A 20 74 65 78 74 2F 70 6C 61 69 6E 0D 0A 43 6F 6E 74 65 6E 74 2D 4C 65 6E 67 74 68 3A 20 34 30 0D 0A 0D 0A 44 61 73 20 73 69 6E 64 20 50 6F 73 74 2D 44 61 74 65 6E 20 6D 69 74 20 55 6D 6C 61 75 74 65 6E 3A 20 C3 A4 C3 BC C3 B6
```
```
POST /post HTTP/2
Host: httpbin.org
User-Agent: python-requests/2.31.0
Accept-Encoding: gzip, deflate, br
Accept: */*
Connection: keep-alive
Content-Type: text/plain
Content-Length: 40
Das sind Post-Daten mit Umlauten: äüö
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.6"
},
"implementation": {
"name": "CPython",
"version": "3.12.0"
},
"platform": {
"release": "10",
"system": "Windows"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "300000b0"
},
"urllib3": {
"version": "2.1.0"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6601/reactions"
} | https://api.github.com/repos/psf/requests/issues/6601/timeline | null | completed | null | null | false | [
"Just saw https://github.com/psf/requests/issues/6586\nSeems to be the same issue."
] |
https://api.github.com/repos/psf/requests/issues/6600 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6600/labels{/name} | https://api.github.com/repos/psf/requests/issues/6600/comments | https://api.github.com/repos/psf/requests/issues/6600/events | https://github.com/psf/requests/pull/6600 | 2,039,700,170 | PR_kwDOABTKOs5h5YI2 | 6,600 | Add note on connection timeout being larger than specified. Fix #5773 | {
"avatar_url": "https://avatars.githubusercontent.com/u/992317?v=4",
"events_url": "https://api.github.com/users/MestreLion/events{/privacy}",
"followers_url": "https://api.github.com/users/MestreLion/followers",
"following_url": "https://api.github.com/users/MestreLion/following{/other_user}",
"gists_url": "https://api.github.com/users/MestreLion/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/MestreLion",
"id": 992317,
"login": "MestreLion",
"node_id": "MDQ6VXNlcjk5MjMxNw==",
"organizations_url": "https://api.github.com/users/MestreLion/orgs",
"received_events_url": "https://api.github.com/users/MestreLion/received_events",
"repos_url": "https://api.github.com/users/MestreLion/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/MestreLion/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MestreLion/subscriptions",
"type": "User",
"url": "https://api.github.com/users/MestreLion",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2023-12-13T13:19:43Z | 2023-12-16T13:30:28Z | 2023-12-16T13:30:18Z | CONTRIBUTOR | null | [As requested](https://github.com/psf/requests/issues/5773#issuecomment-799787382), here's my take on a PR to improve documentation. I've tried to incorporate the [suggestions made by @sigmavirus24 at a previous PR](https://github.com/psf/requests/pull/5776#discussion_r596043195), by shifting the focus from "IPv4+IPv6" particular case to a more general (and correct) "multiple IPs" scenario.
If approved, this PR will also fix #5760, and supersede PRs #5776 and #6597 | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6600/reactions"
} | https://api.github.com/repos/psf/requests/issues/6600/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6600.diff",
"html_url": "https://github.com/psf/requests/pull/6600",
"merged_at": "2023-12-16T13:30:18Z",
"patch_url": "https://github.com/psf/requests/pull/6600.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6600"
} | true | [
"Is there anything I can do on my part to fix the build errors, or are the docs test suite broken?",
"Thank you @MestreLion !"
] |
https://api.github.com/repos/psf/requests/issues/6599 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6599/labels{/name} | https://api.github.com/repos/psf/requests/issues/6599/comments | https://api.github.com/repos/psf/requests/issues/6599/events | https://github.com/psf/requests/pull/6599 | 2,036,014,919 | PR_kwDOABTKOs5hs07I | 6,599 | Bump actions/setup-python from 4.7.0 to 5.0.0 | {
"avatar_url": "https://avatars.githubusercontent.com/in/29110?v=4",
"events_url": "https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/dependabot%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/dependabot",
"id": 49699333,
"login": "dependabot[bot]",
"node_id": "MDM6Qm90NDk2OTkzMzM=",
"organizations_url": "https://api.github.com/users/dependabot%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/dependabot%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/dependabot%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dependabot%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/dependabot%5Bbot%5D",
"user_view_type": "public"
} | [
{
"color": "0366d6",
"default": false,
"description": "Pull requests that update a dependency file",
"id": 1868210094,
"name": "dependencies",
"node_id": "MDU6TGFiZWwxODY4MjEwMDk0",
"url": "https://api.github.com/repos/psf/requests/labels/dependencies"
},
{
"color": "000000",
"default": false,
"description": "Pull requests that update GitHub Actions code",
"id": 5838729011,
"name": "github_actions",
"node_id": "LA_kwDOABTKOs8AAAABXAPvMw",
"url": "https://api.github.com/repos/psf/requests/labels/github_actions"
}
] | closed | false | null | [] | null | 0 | 2023-12-11T16:07:16Z | 2023-12-11T16:11:08Z | 2023-12-11T16:11:07Z | CONTRIBUTOR | null | Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.7.0 to 5.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-python/releases">actions/setup-python's releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<h2>What's Changed</h2>
<p>In scope of this release, we update node version runtime from node16 to node20 (<a href="https://redirect.github.com/actions/setup-python/pull/772">actions/setup-python#772</a>). Besides, we update dependencies to the latest versions.</p>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v4.8.0...v5.0.0">https://github.com/actions/setup-python/compare/v4.8.0...v5.0.0</a></p>
<h2>v4.8.0</h2>
<h2>What's Changed</h2>
<p>In scope of this release we added support for GraalPy (<a href="https://redirect.github.com/actions/setup-python/pull/694">actions/setup-python#694</a>). You can use this snippet to set up GraalPy:</p>
<pre lang="yaml"><code>steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v4
with:
python-version: 'graalpy-22.3'
- run: python my_script.py
</code></pre>
<p>Besides, the release contains such changes as:</p>
<ul>
<li>Trim python version when reading from file by <a href="https://github.com/FerranPares"><code>@FerranPares</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/628">actions/setup-python#628</a></li>
<li>Use non-deprecated versions in examples by <a href="https://github.com/jeffwidman"><code>@jeffwidman</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/724">actions/setup-python#724</a></li>
<li>Change deprecation comment to past tense by <a href="https://github.com/jeffwidman"><code>@jeffwidman</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/723">actions/setup-python#723</a></li>
<li>Bump <code>@babel/traverse</code> from 7.9.0 to 7.23.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/743">actions/setup-python#743</a></li>
<li>advanced-usage.md: Encourage the use actions/checkout@v4 by <a href="https://github.com/cclauss"><code>@cclauss</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/729">actions/setup-python#729</a></li>
<li>Examples now use checkout@v4 by <a href="https://github.com/simonw"><code>@simonw</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/738">actions/setup-python#738</a></li>
<li>Update actions/checkout to v4 by <a href="https://github.com/dmitry-shibanov"><code>@dmitry-shibanov</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/761">actions/setup-python#761</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/FerranPares"><code>@FerranPares</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/628">actions/setup-python#628</a></li>
<li><a href="https://github.com/timfel"><code>@timfel</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/694">actions/setup-python#694</a></li>
<li><a href="https://github.com/jeffwidman"><code>@jeffwidman</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/724">actions/setup-python#724</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v4...v4.8.0">https://github.com/actions/setup-python/compare/v4...v4.8.0</a></p>
<h2>v4.7.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Bump word-wrap from 1.2.3 to 1.2.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/702">actions/setup-python#702</a></li>
<li>Add range validation for toml files by <a href="https://github.com/dmitry-shibanov"><code>@dmitry-shibanov</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/726">actions/setup-python#726</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v4...v4.7.1">https://github.com/actions/setup-python/compare/v4...v4.7.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/setup-python/commit/0a5c61591373683505ea898e09a3ea4f39ef2b9c"><code>0a5c615</code></a> Update action to node20 (<a href="https://redirect.github.com/actions/setup-python/issues/772">#772</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/0ae58361cdfd39e2950bed97a1e26aa20c3d8955"><code>0ae5836</code></a> Add example of GraalPy to docs (<a href="https://redirect.github.com/actions/setup-python/issues/773">#773</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/b64ffcaf5b410884ad320a9cfac8866006a109aa"><code>b64ffca</code></a> update actions/checkout to v4 (<a href="https://redirect.github.com/actions/setup-python/issues/761">#761</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/8d2896179abf658742de432b3f203d2c2d86a587"><code>8d28961</code></a> Examples now use checkout@v4 (<a href="https://redirect.github.com/actions/setup-python/issues/738">#738</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/7bc6abb01e0555719edc2dbca70a2fde309e5e56"><code>7bc6abb</code></a> advanced-usage.md: Encourage the use actions/checkout@v4 (<a href="https://redirect.github.com/actions/setup-python/issues/729">#729</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/e8111cec9d3dc15220d8a3b638f08419f57b906a"><code>e8111ce</code></a> Bump <code>@babel/traverse</code> from 7.9.0 to 7.23.2 (<a href="https://redirect.github.com/actions/setup-python/issues/743">#743</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/a00ea43da65e7c04d2bdae58b3afecd77057eb9e"><code>a00ea43</code></a> add fix for graalpy ci (<a href="https://redirect.github.com/actions/setup-python/issues/741">#741</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/8635b1ccc5934e73ed3510980fd2e7790b85839b"><code>8635b1c</code></a> Change deprecation comment to past tense (<a href="https://redirect.github.com/actions/setup-python/issues/723">#723</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/f6cc428f535856f9c23558d01765a42a4d6cf758"><code>f6cc428</code></a> Use non-deprecated versions in examples (<a href="https://redirect.github.com/actions/setup-python/issues/724">#724</a>)</li>
<li><a href="https://github.com/actions/setup-python/commit/5f2af211d616f86005883b44826180b21abb4060"><code>5f2af21</code></a> Add GraalPy support (<a href="https://redirect.github.com/actions/setup-python/issues/694">#694</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/actions/setup-python/compare/61a6322f88396a6271a6ee3565807d608ecaddd1...0a5c61591373683505ea898e09a3ea4f39ef2b9c">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details> | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6599/reactions"
} | https://api.github.com/repos/psf/requests/issues/6599/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6599.diff",
"html_url": "https://github.com/psf/requests/pull/6599",
"merged_at": "2023-12-11T16:11:07Z",
"patch_url": "https://github.com/psf/requests/pull/6599.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6599"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6598 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6598/labels{/name} | https://api.github.com/repos/psf/requests/issues/6598/comments | https://api.github.com/repos/psf/requests/issues/6598/events | https://github.com/psf/requests/issues/6598 | 2,032,453,981 | I_kwDOABTKOs55JMld | 6,598 | affected urllib3 and certifi packages (older version keeping in setup.py file) | {
"avatar_url": "https://avatars.githubusercontent.com/u/39856426?v=4",
"events_url": "https://api.github.com/users/maraboinavamshi/events{/privacy}",
"followers_url": "https://api.github.com/users/maraboinavamshi/followers",
"following_url": "https://api.github.com/users/maraboinavamshi/following{/other_user}",
"gists_url": "https://api.github.com/users/maraboinavamshi/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/maraboinavamshi",
"id": 39856426,
"login": "maraboinavamshi",
"node_id": "MDQ6VXNlcjM5ODU2NDI2",
"organizations_url": "https://api.github.com/users/maraboinavamshi/orgs",
"received_events_url": "https://api.github.com/users/maraboinavamshi/received_events",
"repos_url": "https://api.github.com/users/maraboinavamshi/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/maraboinavamshi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maraboinavamshi/subscriptions",
"type": "User",
"url": "https://api.github.com/users/maraboinavamshi",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2023-12-08T11:09:48Z | 2023-12-08T11:13:12Z | 2023-12-08T11:13:11Z | NONE | null | <!-- Summary. --> Please upgrade the urllib3 & certifi(2023.7.22) libraries.
use urllib3 >=1.26.18
certifi >= 2023.7.22
## Expected Result
Detecting
<!-- What you expected. --> detecting as vulnerabilites
https://www.cve.org/CVERecord?id=CVE-2023-45803
## Actual Result
<!-- What happened instead. -->
Upgrade to a patched version of urllib3 (v1.26.18 or v2.0.7)
Disable redirects for services that you aren't expecting to respond with redirects with redirects=False.
Disable automatic redirects with redirects=False and handle 303 redirects manually by stripping the HTTP request body.
## Reproduction Steps
```python
import requests
```
## System Information
$ python -m requests.help
```json
{
"paste": "here"
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6598/reactions"
} | https://api.github.com/repos/psf/requests/issues/6598/timeline | null | completed | null | null | false | [
"Both of those versions are compatible with the current version of requests. There's nothing to do here"
] |
https://api.github.com/repos/psf/requests/issues/6597 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6597/labels{/name} | https://api.github.com/repos/psf/requests/issues/6597/comments | https://api.github.com/repos/psf/requests/issues/6597/events | https://github.com/psf/requests/pull/6597 | 2,030,794,603 | PR_kwDOABTKOs5hbLmp | 6,597 | Add Explanation of why Timeout is Doubled. | {
"avatar_url": "https://avatars.githubusercontent.com/u/89538712?v=4",
"events_url": "https://api.github.com/users/PraddyumnYadav/events{/privacy}",
"followers_url": "https://api.github.com/users/PraddyumnYadav/followers",
"following_url": "https://api.github.com/users/PraddyumnYadav/following{/other_user}",
"gists_url": "https://api.github.com/users/PraddyumnYadav/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/PraddyumnYadav",
"id": 89538712,
"login": "PraddyumnYadav",
"node_id": "MDQ6VXNlcjg5NTM4NzEy",
"organizations_url": "https://api.github.com/users/PraddyumnYadav/orgs",
"received_events_url": "https://api.github.com/users/PraddyumnYadav/received_events",
"repos_url": "https://api.github.com/users/PraddyumnYadav/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/PraddyumnYadav/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PraddyumnYadav/subscriptions",
"type": "User",
"url": "https://api.github.com/users/PraddyumnYadav",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2023-12-07T13:44:48Z | 2023-12-16T13:31:11Z | 2023-12-16T13:31:10Z | NONE | null | ## Added Explanation for why Timeout is Doubled.
- In this Pull Request I have Tried to Solve #5773 .
./docs/user/advanced.rst
```diff
+ **You need to be careful when using the timeout argument.**
+ If the specified domain has multiple IP addresses, `urllib3`_ will continue to try another IP address when the specified connection timeout is reached. Also, the connection timeout is applied for each attempt.
+ Requests are affected by this because you are using `urllib3`_.
+ This phenomenon can wait longer than you expect. Maybe it's the time that doubled the connection timeout.
+ Of course there may be more.
+ You can also consider extreme solutions, such as having the specified domain name return only one IP address.
+ For example, if DNS returns both IPv4 DNS records (A) and IPv6 DNS records (AAAA), patch it so that it does not return IPv6.
+ However, new issues may arise.
```
If it Suits Your Needs Consider Merging this Pull Request. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 1,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/6597/reactions"
} | https://api.github.com/repos/psf/requests/issues/6597/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6597.diff",
"html_url": "https://github.com/psf/requests/pull/6597",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6597.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6597"
} | true | [
"Fixed by #6600"
] |
https://api.github.com/repos/psf/requests/issues/6596 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6596/labels{/name} | https://api.github.com/repos/psf/requests/issues/6596/comments | https://api.github.com/repos/psf/requests/issues/6596/events | https://github.com/psf/requests/pull/6596 | 2,020,947,885 | PR_kwDOABTKOs5g5wx9 | 6,596 | Update close-issues.yml | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | false | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
},
{
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
}
] | null | 0 | 2023-12-01T14:06:10Z | 2023-12-20T16:09:55Z | 2023-12-01T17:18:03Z | CONTRIBUTOR | null | I noticed the auto-labeling was working but not the auto-closing. Looking at recent actions runs I see that we need to specify the token even if we're not giving our own special token. See https://github.com/psf/requests/actions/runs/7057701782/job/19211845073#step:2:13 for additional context, namely
```
gh: To use GitHub CLI in a GitHub Actions workflow, set the GH_TOKEN environment variable. Example:
env:
GH_TOKEN: ${{ github.token }}
``` | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6596/reactions"
} | https://api.github.com/repos/psf/requests/issues/6596/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6596.diff",
"html_url": "https://github.com/psf/requests/pull/6596",
"merged_at": "2023-12-01T17:18:03Z",
"patch_url": "https://github.com/psf/requests/pull/6596.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6596"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6595 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6595/labels{/name} | https://api.github.com/repos/psf/requests/issues/6595/comments | https://api.github.com/repos/psf/requests/issues/6595/events | https://github.com/psf/requests/issues/6595 | 2,020,385,112 | I_kwDOABTKOs54bKFY | 6,595 | Is it possible to send async generator as `data` argument of request method? | {
"avatar_url": "https://avatars.githubusercontent.com/u/118155248?v=4",
"events_url": "https://api.github.com/users/EverettDunamu/events{/privacy}",
"followers_url": "https://api.github.com/users/EverettDunamu/followers",
"following_url": "https://api.github.com/users/EverettDunamu/following{/other_user}",
"gists_url": "https://api.github.com/users/EverettDunamu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/EverettDunamu",
"id": 118155248,
"login": "EverettDunamu",
"node_id": "U_kgDOBwrn8A",
"organizations_url": "https://api.github.com/users/EverettDunamu/orgs",
"received_events_url": "https://api.github.com/users/EverettDunamu/received_events",
"repos_url": "https://api.github.com/users/EverettDunamu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/EverettDunamu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/EverettDunamu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/EverettDunamu",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156042717,
"name": "actions/autoclose-qa",
"node_id": "LA_kwDOABTKOs8AAAABbu3B3Q",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-qa"
}
] | closed | false | null | [] | null | 1 | 2023-12-01T08:39:11Z | 2023-12-01T14:06:43Z | 2023-12-01T14:06:43Z | NONE | null | I'm using `requests` module in Python and I want to send data in request streaming way. so I applied chunked-encoded request according to [this document](https://requests.readthedocs.io/en/latest/user/advanced/#chunk-encoded-requests).
However, the data to send is provided with another async method. Honestly speaking, I also use Sanic framework, and I read the stream data from `await sanic.request.stream.read()` and I want to relay the streaming data to `request` method of `requests` module.
```
async def generate_from_sanic_request(request):
while True:
chunk = await request.stream.read()
if chunk is None:
break
yield chunk
...
requests.request(
method="POST",
url="my-own-url",
data=generate_from_sanic_request, # here is the point of this question.
)
...
```
The document says that I can use the non-async generator function as the `data` argument. However, when I use an async generator there, `requests.request` cannot handle the generator.
I want to do this in a memory-efficient way, so I want to bypass the received streaming request body to requests.request method in one-by-one way.
Can I get any help to solve this problem?
Thanks in advance. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6595/reactions"
} | https://api.github.com/repos/psf/requests/issues/6595/timeline | null | completed | null | null | false | [
"It is not possible to use an async generator with requests. For help with your code, please use [StackOverflow](https://stackoverflow.com)."
] |
https://api.github.com/repos/psf/requests/issues/6594 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6594/labels{/name} | https://api.github.com/repos/psf/requests/issues/6594/comments | https://api.github.com/repos/psf/requests/issues/6594/events | https://github.com/psf/requests/pull/6594 | 2,019,960,627 | PR_kwDOABTKOs5g2XZW | 6,594 | Limit werkzeug<3 for CI only, fixes #6541 | {
"avatar_url": "https://avatars.githubusercontent.com/u/225823?v=4",
"events_url": "https://api.github.com/users/bruceadams/events{/privacy}",
"followers_url": "https://api.github.com/users/bruceadams/followers",
"following_url": "https://api.github.com/users/bruceadams/following{/other_user}",
"gists_url": "https://api.github.com/users/bruceadams/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bruceadams",
"id": 225823,
"login": "bruceadams",
"node_id": "MDQ6VXNlcjIyNTgyMw==",
"organizations_url": "https://api.github.com/users/bruceadams/orgs",
"received_events_url": "https://api.github.com/users/bruceadams/received_events",
"repos_url": "https://api.github.com/users/bruceadams/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bruceadams/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bruceadams/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bruceadams",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2023-12-01T03:03:29Z | 2023-12-01T12:21:03Z | 2023-12-01T08:39:36Z | CONTRIBUTOR | null | I believe this change will fix CI run failures, such as [these](https://github.com/psf/requests/actions/runs/7038290331). | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6594/reactions"
} | https://api.github.com/repos/psf/requests/issues/6594/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6594.diff",
"html_url": "https://github.com/psf/requests/pull/6594",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6594.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6594"
} | true | [
"Hi @bruceadams, thanks for the PR. This is already fixed in psf/httpbin#29. Once that's released the test suite will function normally again. I don't think we'd merge this when the long term fix is already done.",
"Cool! This certainly felt like an upstream problem and I'd figured out that werkzeug was being pulled in via httpbin. I hadn't gone to look at either werkzeug or httpbin to see if they might be dealing with the problem. I'm glad that it's getting fixed!"
] |
https://api.github.com/repos/psf/requests/issues/6593 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6593/labels{/name} | https://api.github.com/repos/psf/requests/issues/6593/comments | https://api.github.com/repos/psf/requests/issues/6593/events | https://github.com/psf/requests/issues/6593 | 2,018,889,406 | I_kwDOABTKOs54Vc6- | 6,593 | Local (and build) tests failing | {
"avatar_url": "https://avatars.githubusercontent.com/u/31266487?v=4",
"events_url": "https://api.github.com/users/HJones82493/events{/privacy}",
"followers_url": "https://api.github.com/users/HJones82493/followers",
"following_url": "https://api.github.com/users/HJones82493/following{/other_user}",
"gists_url": "https://api.github.com/users/HJones82493/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/HJones82493",
"id": 31266487,
"login": "HJones82493",
"node_id": "MDQ6VXNlcjMxMjY2NDg3",
"organizations_url": "https://api.github.com/users/HJones82493/orgs",
"received_events_url": "https://api.github.com/users/HJones82493/received_events",
"repos_url": "https://api.github.com/users/HJones82493/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/HJones82493/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HJones82493/subscriptions",
"type": "User",
"url": "https://api.github.com/users/HJones82493",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2023-11-30T15:15:39Z | 2023-11-30T19:10:54Z | 2023-11-30T16:24:43Z | NONE | null | <!-- Summary. -->
One of the first steps in contributing to the repository is running the tests locally. However, the tests are failing with the error stated below. Looking through the latest main build, outside of version 3.7, the tests are failing on build as well (https://github.com/psf/requests/actions/runs/6959204233/job/18935930726)
## Expected Result
<!-- What you expected. -->
Running `python -m pytest tests` will gather and run the test suite, reporting passes and fails.
## Actual Result
<!-- What happened instead. -->
Python fails with the following result
```
Traceback (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "<redacted user directory>/.local/lib/python3.11/site-packages/pytest/__main__.py", line 5, in <module>
raise SystemExit(pytest.console_main())
^^^^^^^^^^^^^^^^^^^^^
File "<redacted user directory>/.local/lib/python3.11/site-packages/_pytest/config/__init__.py", line 185, in console_main
code = main()
^^^^^^
File "<redacted user directory>/.local/lib/python3.11/site-packages/_pytest/config/__init__.py", line 143, in main
config = _prepareconfig(args, plugins)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "<redacted user directory>/.local/lib/python3.11/site-packages/_pytest/config/__init__.py", line 318, in _prepareconfig
config = pluginmanager.hook.pytest_cmdline_parse(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/pluggy/_hooks.py", line 265, in __call__
return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/pluggy/_manager.py", line 80, in _hookexec
return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/pluggy/_callers.py", line 55, in _multicall
gen.send(outcome)
File "<redacted user directory>/.local/lib/python3.11/site-packages/_pytest/helpconfig.py", line 100, in pytest_cmdline_parse
config: Config = outcome.get_result()
^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/site-packages/pluggy/_result.py", line 60, in get_result
raise ex[1].with_traceback(ex[2])
File "/usr/lib/python3.11/site-packages/pluggy/_callers.py", line 39, in _multicall
res = hook_impl.function(*args)
^^^^^^^^^^^^^^^^^^^^^^^^^
File "<redacted user directory>/.local/lib/python3.11/site-packages/_pytest/config/__init__.py", line 1003, in pytest_cmdline_parse
self.parse(args)
File "<redacted user directory>/.local/lib/python3.11/site-packages/_pytest/config/__init__.py", line 1283, in parse
self._preparse(args, addopts=addopts)
File "<redacted user directory>/.local/lib/python3.11/site-packages/_pytest/config/__init__.py", line 1172, in _preparse
self.pluginmanager.load_setuptools_entrypoints("pytest11")
File "/usr/lib/python3.11/site-packages/pluggy/_manager.py", line 287, in load_setuptools_entrypoints
plugin = ep.load()
^^^^^^^^^
File "/usr/lib64/python3.11/importlib/metadata/__init__.py", line 202, in load
module = import_module(match.group('module'))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.11/importlib/__init__.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
File "<redacted user directory>/.local/lib/python3.11/site-packages/_pytest/assertion/rewrite.py", line 170, in exec_module
exec(co, module.__dict__)
File "<redacted user directory>/.local/lib/python3.11/site-packages/pytest_httpbin/plugin.py", line 2, in <module>
from httpbin import app as httpbin_app
File "<redacted user directory>/.local/lib/python3.11/site-packages/httpbin/__init__.py", line 3, in <module>
from .core import *
File "<redacted user directory>/.local/lib/python3.11/site-packages/httpbin/core.py", line 35, in <module>
from werkzeug.http import parse_authorization_header
ImportError: cannot import name 'parse_authorization_header' from 'werkzeug.http' (<redacted user directory>/.local/lib/python3.11/site-packages/werkzeug/http.py)
```
## Reproduction Steps
```
git clone [email protected]:psf/requests.git
cd requests
pip install -r requirements-dev.txt
python -m pytest tests
```
## System Information
$ python -m requests.help
```
{
"chardet": {
"version": "5.2.0"
},
"charset_normalizer": {
"version": "3.1.0"
},
"cryptography": {
"version": "37.0.2"
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "CPython",
"version": "3.11.6"
},
"platform": {
"release": "6.5.12-200.fc38.x86_64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "30000080",
"version": "21.0.0"
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "30000090"
},
"urllib3": {
"version": "1.26.18"
},
"using_charset_normalizer": false,
"using_pyopenssl": true
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6593/reactions"
} | https://api.github.com/repos/psf/requests/issues/6593/timeline | null | completed | null | null | false | [
"In the future, please search **closed and** open issues before creating new ones that are duplicates.",
"@sigmavirus24 i did search and the most recent reference I found was older than a week when the build was still failing. Can you point me to the issue number in which it was closed please?"
] |
https://api.github.com/repos/psf/requests/issues/6592 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6592/labels{/name} | https://api.github.com/repos/psf/requests/issues/6592/comments | https://api.github.com/repos/psf/requests/issues/6592/events | https://github.com/psf/requests/pull/6592 | 2,017,089,836 | PR_kwDOABTKOs5gsjuu | 6,592 | "TOO_EARLY" type definition for status code 425 | {
"avatar_url": "https://avatars.githubusercontent.com/u/85669350?v=4",
"events_url": "https://api.github.com/users/atatuzuner61/events{/privacy}",
"followers_url": "https://api.github.com/users/atatuzuner61/followers",
"following_url": "https://api.github.com/users/atatuzuner61/following{/other_user}",
"gists_url": "https://api.github.com/users/atatuzuner61/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/atatuzuner61",
"id": 85669350,
"login": "atatuzuner61",
"node_id": "MDQ6VXNlcjg1NjY5MzUw",
"organizations_url": "https://api.github.com/users/atatuzuner61/orgs",
"received_events_url": "https://api.github.com/users/atatuzuner61/received_events",
"repos_url": "https://api.github.com/users/atatuzuner61/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/atatuzuner61/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/atatuzuner61/subscriptions",
"type": "User",
"url": "https://api.github.com/users/atatuzuner61",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 0 | 2023-11-29T17:31:32Z | 2023-12-16T22:31:13Z | 2023-12-16T20:24:03Z | CONTRIBUTOR | null | Addressing issue #6584:
- Added "too_early" to type definition of status code 425
- Added tests for retrieving 425 when querying type definitions
- In accordance with RFC 4918 and 8470.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6592/reactions"
} | https://api.github.com/repos/psf/requests/issues/6592/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6592.diff",
"html_url": "https://github.com/psf/requests/pull/6592",
"merged_at": "2023-12-16T20:24:03Z",
"patch_url": "https://github.com/psf/requests/pull/6592.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6592"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6591 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6591/labels{/name} | https://api.github.com/repos/psf/requests/issues/6591/comments | https://api.github.com/repos/psf/requests/issues/6591/events | https://github.com/psf/requests/issues/6591 | 2,016,362,579 | I_kwDOABTKOs54L0BT | 6,591 | Failed to establish a new connection: [Errno -2] Name or service not known | {
"avatar_url": "https://avatars.githubusercontent.com/u/126869573?v=4",
"events_url": "https://api.github.com/users/joseemjr/events{/privacy}",
"followers_url": "https://api.github.com/users/joseemjr/followers",
"following_url": "https://api.github.com/users/joseemjr/following{/other_user}",
"gists_url": "https://api.github.com/users/joseemjr/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/joseemjr",
"id": 126869573,
"login": "joseemjr",
"node_id": "U_kgDOB4_gRQ",
"organizations_url": "https://api.github.com/users/joseemjr/orgs",
"received_events_url": "https://api.github.com/users/joseemjr/received_events",
"repos_url": "https://api.github.com/users/joseemjr/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/joseemjr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/joseemjr/subscriptions",
"type": "User",
"url": "https://api.github.com/users/joseemjr",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156042717,
"name": "actions/autoclose-qa",
"node_id": "LA_kwDOABTKOs8AAAABbu3B3Q",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-qa"
}
] | closed | false | null | [] | null | 1 | 2023-11-29T11:18:00Z | 2023-11-29T12:13:43Z | 2023-11-29T12:13:42Z | NONE | null | I have this code that is trying to divide a wordlist in 20 segments in order to create 20 threads that work with each segment when calling to fuzzer_directiorios and fuzzer_subdomains:
```
import requests
from requests.adapters import HTTPAdapter
from requests.packages.urllib3.util.retry import Retry
from concurrent.futures import ThreadPoolExecutor
from colorama import Fore, Style
import socket
#Función para hacer fuzzer de subdominios o fuzzer de directorios
def Fuzzer():
menu = """
===================================<<< MENU DE FUZZER >>>======================================
[1] Fuzzer de Directorios
[2] Fuzzer de Subdominios
[3] Volver al menu
"""
choosen = False
#Bucle hasta que choosen sea True para permitir al usuario escoger una opcion de escaneo
while not choosen:
print(Style.BRIGHT+Fore.LIGHTYELLOW_EX+menu)
#Muestra mensaje de seleccion y entrada de un valor correspondiente a cada opcion
option = input(Style.BRIGHT+Fore.LIGHTWHITE_EX+"Seleccione una opcion de fuzzer: ")
#Opcion 1: Fuzzer de Directorios
if option == '1':
choosen = True
url = 'https://google.es/'
filename = '/home/test/Descargas/directory-list-2.3-medium.txt'
with open(filename, 'r') as file:
wordlist = file.readlines()
segment_size = len(wordlist) // 20
segments = [wordlist[i:i + segment_size] for i in range(0, len(wordlist), segment_size)]
try:
with ThreadPoolExecutor(max_workers=20) as executor:
executor.map(fuzzer_directorios, [url] * 20, segments, timeout=30)
except KeyboardInterrupt:
print(Style.BRIGHT+Fore.RED+"\n[!] Script terminado (Ctrl + C)")
finally:
file.close()
#Opcion 2: Fuzzer de Subdominios
elif option == '2':
choosen = True
domain = 'google.es'
resolved_address = socket.gethostbyname(domain)
filename = '/home/test/Descargas/subdomains-10000.txt'
with open(filename, 'r') as file:
wordlist = file.readlines()
segment_size = len(wordlist) // 20
segments = [wordlist[i:i + segment_size] for i in range(0, len(wordlist), segment_size)]
try:
with ThreadPoolExecutor(max_workers=20) as executor:
executor.map(fuzzer_subdomains, [domain] * 20, segments, timeout=30)
except KeyboardInterrupt:
print(Style.BRIGHT+Fore.RED+"\n[!] Script terminado (Ctrl + C)")
finally:
file.close()
#Opcion 3: Volver al menu
elif option == '3':
return 0
else:
print(Style.BRIGHT+Fore.RED+"[!] Opcion inválida, intentalo de nuevo!")
sleep(1)
# Función para fuzzear directorios
def fuzzer_directorios(url, wordlist):
for line in wordlist:
url_compl = url + line # Crea la URL completa
# Comprueba si la URL completa existe
try:
session = requests.Session()
retry = Retry(total=2, backoff_factor=0.1)
adapter = HTTPAdapter(max_retries=retry)
session.mount('http://', adapter)
session.mount('https://', adapter)
response = session.get(url_compl, timeout=10)
if response.status_code == 200:
print(Style.BRIGHT + Fore.GREEN + f"Directorio encontrado: {url_compl}")
except requests.RequestException as e:
print(Style.BRIGHT + Fore.RED + f"[!] Se produjo un error durante alguna solicitud: {e}")
except KeyboardInterrupt:
print(Style.BRIGHT+Fore.RED+"\n[!] Script terminado (Ctrl + C)")
# Función para fuzzear subdominios
def fuzzer_subdomains(domain, wordlist):
for entry in wordlist:
subdomain = entry.strip() # Elimina caracteres de espacio en blanco
full_http_url = f"http://{domain}" # URL completa con HTTP
full_https_url = f"https://{domain}" # URL completa con HTTPS
headers = {'Host': f'{subdomain}.{domain}'} # Configura el Host de la cabecera HTTP
# Realiza peticiones HTTP y HTTPS con el subdominio en la cabecera 'Host'
try:
session = requests.Session()
retry = Retry(total=2, backoff_factor=0.1)
adapter = HTTPAdapter(max_retries=retry)
session.mount('http://', adapter)
session.mount('https://', adapter)
response_http = session.get(full_http_url, headers=headers, allow_redirects=False, timeout=10)
response_https = session.get(full_https_url, headers=headers, allow_redirects=False,timeout=10)
# Comprueba si el subdominio fue encontrado
if response_http.status_code == 200 or response_https.status_code == 200:
print(Style.BRIGHT + Fore.GREEN + f"Subdominio encontrado: {subdomain}.{domain}")
except requests.RequestException as e:
print(Style.BRIGHT + Fore.RED + f"[!] Se produjo un error durante alguna solicitud: {e}")
except KeyboardInterrupt:
print(Style.BRIGHT+Fore.RED+"\n[!] Script terminado (Ctrl + C)")
def main():
Fuzzer()
if __name__ == "__main__":
main()
```
My problem is when I execute any of both fuzzers this is what I obtain
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6591/reactions"
} | https://api.github.com/repos/psf/requests/issues/6591/timeline | null | not_planned | null | null | false | [
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here."
] |
https://api.github.com/repos/psf/requests/issues/6590 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6590/labels{/name} | https://api.github.com/repos/psf/requests/issues/6590/comments | https://api.github.com/repos/psf/requests/issues/6590/events | https://github.com/psf/requests/pull/6590 | 2,015,039,310 | PR_kwDOABTKOs5glis0 | 6,590 | Perform correct length measurement for Python strings in HTTP request `data` | {
"avatar_url": "https://avatars.githubusercontent.com/u/59181809?v=4",
"events_url": "https://api.github.com/users/goelbenj/events{/privacy}",
"followers_url": "https://api.github.com/users/goelbenj/followers",
"following_url": "https://api.github.com/users/goelbenj/following{/other_user}",
"gists_url": "https://api.github.com/users/goelbenj/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/goelbenj",
"id": 59181809,
"login": "goelbenj",
"node_id": "MDQ6VXNlcjU5MTgxODA5",
"organizations_url": "https://api.github.com/users/goelbenj/orgs",
"received_events_url": "https://api.github.com/users/goelbenj/received_events",
"repos_url": "https://api.github.com/users/goelbenj/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/goelbenj/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/goelbenj/subscriptions",
"type": "User",
"url": "https://api.github.com/users/goelbenj",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2023-11-28T18:21:21Z | 2023-11-29T13:39:29Z | 2023-11-29T13:39:29Z | NONE | null | This PR addresses the problem detailed in #6586. The fix involves measuring the encoded byte-length of the string as per [RFC 9910](https://www.rfc-editor.org/rfc/rfc9110#field.content-length).
This PR includes two tests that verify the fix addresses the problem. Additionally, all tests pass locally, so no regressions have occurred. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6590/reactions"
} | https://api.github.com/repos/psf/requests/issues/6590/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6590.diff",
"html_url": "https://github.com/psf/requests/pull/6590",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6590.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6590"
} | true | [
"Closing as a duplicate of #6589"
] |
https://api.github.com/repos/psf/requests/issues/6589 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6589/labels{/name} | https://api.github.com/repos/psf/requests/issues/6589/comments | https://api.github.com/repos/psf/requests/issues/6589/events | https://github.com/psf/requests/pull/6589 | 2,015,038,832 | PR_kwDOABTKOs5glimK | 6,589 | Enhance `super_len` to count encoded bytes for str | {
"avatar_url": "https://avatars.githubusercontent.com/u/225823?v=4",
"events_url": "https://api.github.com/users/bruceadams/events{/privacy}",
"followers_url": "https://api.github.com/users/bruceadams/followers",
"following_url": "https://api.github.com/users/bruceadams/following{/other_user}",
"gists_url": "https://api.github.com/users/bruceadams/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bruceadams",
"id": 225823,
"login": "bruceadams",
"node_id": "MDQ6VXNlcjIyNTgyMw==",
"organizations_url": "https://api.github.com/users/bruceadams/orgs",
"received_events_url": "https://api.github.com/users/bruceadams/received_events",
"repos_url": "https://api.github.com/users/bruceadams/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bruceadams/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bruceadams/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bruceadams",
"user_view_type": "public"
} | [] | closed | false | null | [] | {
"closed_at": null,
"closed_issues": 13,
"created_at": "2023-08-13T17:04:53Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
},
"description": "",
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/33",
"id": 9786066,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/33/labels",
"node_id": "MI_kwDOABTKOs4AlVLS",
"number": 33,
"open_issues": 0,
"state": "open",
"title": "2.32.0",
"updated_at": "2024-05-20T14:17:03Z",
"url": "https://api.github.com/repos/psf/requests/milestones/33"
} | 2 | 2023-11-28T18:21:03Z | 2024-02-23T00:53:25Z | 2024-02-23T00:53:25Z | CONTRIBUTOR | null | This is a possible fix for issue #6586.
I am not at all confident that this is an appropriate change for Requests. All of the unit tests pass locally for me (specifically `make ci`). | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6589/reactions"
} | https://api.github.com/repos/psf/requests/issues/6589/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6589.diff",
"html_url": "https://github.com/psf/requests/pull/6589",
"merged_at": "2024-02-23T00:53:25Z",
"patch_url": "https://github.com/psf/requests/pull/6589.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6589"
} | true | [
"@sigmavirus24 would you mind taking at these new changes?",
"closing and re-opening to trigger a new build"
] |
https://api.github.com/repos/psf/requests/issues/6588 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6588/labels{/name} | https://api.github.com/repos/psf/requests/issues/6588/comments | https://api.github.com/repos/psf/requests/issues/6588/events | https://github.com/psf/requests/issues/6588 | 2,014,740,949 | I_kwDOABTKOs54FoHV | 6,588 | Cannot run tests locally | {
"avatar_url": "https://avatars.githubusercontent.com/u/59181809?v=4",
"events_url": "https://api.github.com/users/goelbenj/events{/privacy}",
"followers_url": "https://api.github.com/users/goelbenj/followers",
"following_url": "https://api.github.com/users/goelbenj/following{/other_user}",
"gists_url": "https://api.github.com/users/goelbenj/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/goelbenj",
"id": 59181809,
"login": "goelbenj",
"node_id": "MDQ6VXNlcjU5MTgxODA5",
"organizations_url": "https://api.github.com/users/goelbenj/orgs",
"received_events_url": "https://api.github.com/users/goelbenj/received_events",
"repos_url": "https://api.github.com/users/goelbenj/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/goelbenj/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/goelbenj/subscriptions",
"type": "User",
"url": "https://api.github.com/users/goelbenj",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2023-11-28T15:42:44Z | 2023-11-29T14:17:43Z | 2023-11-29T14:17:43Z | NONE | null | <!-- Summary. -->
I am trying to install the repository and run all the tests as recommended by the [Contribution Instructions](https://requests.readthedocs.io/en/latest/dev/contributing/). I am getting the following error when I perform the following. Importantly, what are the official instructions for installing the dev dependencies for `requests`? I cannot find an official instruction so I'm using the `Makefile`.
## Expected Result
```
Pytest to run successfully.
```
## Actual Result
```
ImportError: cannot import name 'parse_authorization_header' from 'werkzeug.http' (/requests/venv/lib/python3.10/site-packages/werkzeug/http.py)
```
## Reproduction Steps
```
cd requests
python -m venv ./myvenv
make init
pytest tests/
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.6"
},
"implementation": {
"name": "CPython",
"version": "3.10.11"
},
"platform": {
"release": "22.4.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "1010114f"
},
"urllib3": {
"version": "2.1.0"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6588/reactions"
} | https://api.github.com/repos/psf/requests/issues/6588/timeline | null | completed | null | null | false | [
"Based on this commit in the `httpbin` repo, it looks like the werkzeug version is constrained, but the dev dependencies do not constrain it to <2.3. Werkzeug removed the `parse_authorization_headers` func in v3.x.\r\n\r\nhttps://github.com/psf/httpbin/commit/496d0b96c3a8c843803e18ac6d8a379b94b4f215",
"This is a duplicate of other closed issues. Httpbin needs to be released "
] |
https://api.github.com/repos/psf/requests/issues/6587 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6587/labels{/name} | https://api.github.com/repos/psf/requests/issues/6587/comments | https://api.github.com/repos/psf/requests/issues/6587/events | https://github.com/psf/requests/pull/6587 | 2,013,238,250 | PR_kwDOABTKOs5gfYeB | 6,587 | Unit test for string containing multi-byte UTF-8 #6586 | {
"avatar_url": "https://avatars.githubusercontent.com/u/225823?v=4",
"events_url": "https://api.github.com/users/bruceadams/events{/privacy}",
"followers_url": "https://api.github.com/users/bruceadams/followers",
"following_url": "https://api.github.com/users/bruceadams/following{/other_user}",
"gists_url": "https://api.github.com/users/bruceadams/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bruceadams",
"id": 225823,
"login": "bruceadams",
"node_id": "MDQ6VXNlcjIyNTgyMw==",
"organizations_url": "https://api.github.com/users/bruceadams/orgs",
"received_events_url": "https://api.github.com/users/bruceadams/received_events",
"repos_url": "https://api.github.com/users/bruceadams/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bruceadams/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bruceadams/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bruceadams",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 0 | 2023-11-27T22:31:41Z | 2024-02-23T00:53:27Z | 2024-02-23T00:53:27Z | CONTRIBUTOR | null | There are two tests here. One demonstrating existing, correct behavior for `data=bytes`, and another, failing, test for the case where `data=string` and the string contains multi-byte UTF-8. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6587/reactions"
} | https://api.github.com/repos/psf/requests/issues/6587/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6587.diff",
"html_url": "https://github.com/psf/requests/pull/6587",
"merged_at": "2024-02-23T00:53:27Z",
"patch_url": "https://github.com/psf/requests/pull/6587.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6587"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6586 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6586/labels{/name} | https://api.github.com/repos/psf/requests/issues/6586/comments | https://api.github.com/repos/psf/requests/issues/6586/events | https://github.com/psf/requests/issues/6586 | 2,013,237,330 | I_kwDOABTKOs53_5BS | 6,586 | The Content-Length header for string `data` counts Unicode characters in the string when it should count encoded bytes | {
"avatar_url": "https://avatars.githubusercontent.com/u/225823?v=4",
"events_url": "https://api.github.com/users/bruceadams/events{/privacy}",
"followers_url": "https://api.github.com/users/bruceadams/followers",
"following_url": "https://api.github.com/users/bruceadams/following{/other_user}",
"gists_url": "https://api.github.com/users/bruceadams/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bruceadams",
"id": 225823,
"login": "bruceadams",
"node_id": "MDQ6VXNlcjIyNTgyMw==",
"organizations_url": "https://api.github.com/users/bruceadams/orgs",
"received_events_url": "https://api.github.com/users/bruceadams/received_events",
"repos_url": "https://api.github.com/users/bruceadams/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bruceadams/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bruceadams/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bruceadams",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 7 | 2023-11-27T22:31:09Z | 2024-02-23T01:47:24Z | 2024-02-23T01:47:24Z | CONTRIBUTOR | null | A call like this:
```python
response = requests.post("https://example.com", data="👍👎")
```
auto sets the `Content-Length` header in the request to `2` when it should be `8`.
I hit this issue was making a request with a JSON body to a service I own (running behind AWS API Gateway) and having the service complain that there was no closing brace `}` in the JSON body. I was passing the JSON body into requests as a string to the `data` argument. It turns out that API Gateway ignores any body bytes beyond the `Content-Length` in the request. Turning up detailed logging on API Gateway, I can see the request headers and realized the value in the `Content-Length` header didn't match the number of bytes in the body.
A quick workaround is to encode the string into bytes before passing it into Requests.
This produces a Content-Length header with the correct value of `8`:
```python
response = requests.post("https://example.com", data="👍👎".encode("utf-8"))
```
## Expected Result
On a server receiving a POST from Requests, I expect the `Content-Length` header value to match the number of bytes in the body of the request. See [RFC 9110](https://www.rfc-editor.org/rfc/rfc9110#field.content-length).
## Actual Result
In the specific case where Request's `data` argument is set as a string containing characters which encode into multi-byte UTF-8, the value in the `Content-Length` header is incorrect. Requests appears to be counting the number of Unicode characters in the string instead of the number of bytes that will be sent to the server.
## Reproduction Steps
```python
>>> import requests
>>> thumbs_up_down = "👍👎"
>>> len(thumbs_up_down)
2
>>> len(thumbs_up_down.encode())
8
>>> pending_request = requests.Request("POST", "https://example.com", data=thumbs_up_down)
>>> prepared_request = pending_request.prepare()
>>> prepared_request.headers
{'Content-Length': '2'}
```
I opened a pull request, #6587, that adds a failing unit test that demonstrates this problem.
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.6"
},
"implementation": {
"name": "CPython",
"version": "3.9.16"
},
"platform": {
"release": "23.1.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "1010111f"
},
"urllib3": {
"version": "2.1.0"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/225823?v=4",
"events_url": "https://api.github.com/users/bruceadams/events{/privacy}",
"followers_url": "https://api.github.com/users/bruceadams/followers",
"following_url": "https://api.github.com/users/bruceadams/following{/other_user}",
"gists_url": "https://api.github.com/users/bruceadams/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bruceadams",
"id": 225823,
"login": "bruceadams",
"node_id": "MDQ6VXNlcjIyNTgyMw==",
"organizations_url": "https://api.github.com/users/bruceadams/orgs",
"received_events_url": "https://api.github.com/users/bruceadams/received_events",
"repos_url": "https://api.github.com/users/bruceadams/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bruceadams/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bruceadams/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bruceadams",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/6586/reactions"
} | https://api.github.com/repos/psf/requests/issues/6586/timeline | null | completed | null | null | false | [
"I assume that it is incorrect to require the data to be encoded as UTF-8, so I will work on a fix that removes the need for this hack. @bruceadams ",
"> I assume that it is incorrect to require the data to be encoded as UTF-8, so I will work on a fix that removes the need for this hack. @bruceadams\r\n\r\nI do not understand what you are saying. What hack?\r\n\r\nA Python string can contain Unicode characters. To send a Python string as the body of an HTTP request, the string needs to be encoded into bytes. UTF-8 is a common encoding (and I see signs of UTF-8 being assumed elsewhere in the Requests code). In the behavior I saw in the wild, Requests did, in fact, encode the request body as UTF-8.",
"Ah! Your pull request lines up with how I thought this might be properly addressed! Nice! (I just created a similar pull request #6589.)",
"> I do not understand what you are saying. What hack?\r\n\r\nHa, looks like we made the same conclusion here. What I meant regarding the \"hack\" was requiring the user to encode their string data as UTF-8 for the Content-Length header to be correctly initialized.",
"Can I fix this by downgrading to a previous version? I don't want to (and some users probably cannot) change the code to convert to bytes before passing it to the request.\r\n\r\nAlso don't really get your fixes, the body is at some point converted to bytes (there is a `body_to_chunks` in request.py) that also seems to set the content-length header? But that is just a side note, I'm not into the code, so just ignore it if I'm talking nonsense..",
"Bytes are the language of the Internet regardless of whether you think that. Many things try to paper over that. The right thing is to typically send bytes that you know how they should be encoded but barring that, we should be always dealing with bytes internally. Now that we dropped 2.7 support, I'd support always encoding data parameters that are strs to bytes before doing anything else with them (e.g., calculating content length) internally ",
"Fixed by #6589"
] |
https://api.github.com/repos/psf/requests/issues/6585 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6585/labels{/name} | https://api.github.com/repos/psf/requests/issues/6585/comments | https://api.github.com/repos/psf/requests/issues/6585/events | https://github.com/psf/requests/issues/6585 | 2,010,909,439 | I_kwDOABTKOs533Ar_ | 6,585 | (Caused by ProxyError('Cannot connect to proxy.', OSError('Tunnel connection failed: 400 Bad Request'))) | {
"avatar_url": "https://avatars.githubusercontent.com/u/66294702?v=4",
"events_url": "https://api.github.com/users/tilakpatel22/events{/privacy}",
"followers_url": "https://api.github.com/users/tilakpatel22/followers",
"following_url": "https://api.github.com/users/tilakpatel22/following{/other_user}",
"gists_url": "https://api.github.com/users/tilakpatel22/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tilakpatel22",
"id": 66294702,
"login": "tilakpatel22",
"node_id": "MDQ6VXNlcjY2Mjk0NzAy",
"organizations_url": "https://api.github.com/users/tilakpatel22/orgs",
"received_events_url": "https://api.github.com/users/tilakpatel22/received_events",
"repos_url": "https://api.github.com/users/tilakpatel22/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tilakpatel22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tilakpatel22/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tilakpatel22",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 1 | 2023-11-26T06:22:50Z | 2024-05-15T20:06:07Z | 2024-05-15T20:06:06Z | NONE | null | <!-- Summary. -->
I'm developing a program that scrapes news data using the requests library but while running I get this error. my proxy list is working correctly
error: Proxy: 103.21.244.100:80 - Error: HTTPSConnectionPool(host='www.nytimes.com', port=443): Max retries exceeded with url: /section/business/media (Caused by ProxyError('Cannot connect to proxy.', OSError('Tunnel connection failed: 400 Bad Request')))
[proxylist.txt](https://github.com/psf/requests/files/13466044/proxylist.txt)
## Reproduction Steps
```python
import sys
import time
import psycopg2
import newspaper
from PyQt5.QtWidgets import QApplication, QMainWindow, QPushButton
from threading import Thread
import requests
class NewsScraperGUI(QMainWindow):
def __init__(self):
super().__init__()
self.initUI()
self.scraping = False # Flag to control scraping process
def initUI(self):
self.setWindowTitle('News Scraper')
self.setGeometry(100, 100, 400, 200)
self.start_button = QPushButton('Start Scraping', self)
self.start_button.clicked.connect(self.startScraping)
self.start_button.setGeometry(50, 50, 150, 30)
self.stop_button = QPushButton('Stop Scraping', self)
self.stop_button.clicked.connect(self.stopScraping)
self.stop_button.setGeometry(200, 50, 150, 30)
self.stop_button.setEnabled(False) # Initially disabled
def create_table(self):
conn = psycopg2.connect(
dbname='postgres',
user='postgres',
password='12Tilak34##',
host='localhost'
)
cur = conn.cursor()
cur.execute('''
CREATE TABLE IF NOT EXISTS news (
id SERIAL PRIMARY KEY,
source TEXT,
title TEXT,
text TEXT,
url TEXT
);
''')
conn.commit()
conn.close()
def insert_news(self, source, title, text, url):
conn = psycopg2.connect(
dbname='postgres',
user='postgres',
password='12Tilak34##',
host='localhost'
)
cur = conn.cursor()
cur.execute('''
INSERT INTO news (source, title, text, url) VALUES (%s, %s, %s, %s);
''', (source, title, text, url))
conn.commit()
conn.close()
def read_proxies(self, filename):
try:
with open(filename, 'r') as file:
proxies = file.readlines()
# Removing newline characters and any extra whitespace
proxies = [proxy.strip() for proxy in proxies if proxy.strip()]
return proxies
except Exception as e:
print(f"Error reading proxies from file: {e}")
return []
def scrape_news(self, source_url, num_articles, proxies_filename):
proxies = self.read_proxies(proxies_filename)
try:
source = newspaper.build(source_url, memoize_articles=False)
source.download()
source.parse()
articles_scraped = 0
for article in source.articles:
if articles_scraped >= num_articles:
break
proxy = proxies.pop(0) if proxies else None # Get the first proxy from the list
if proxy:
proxies.append(proxy) # Rotate proxies
article_url = article.url
article_title = article.title
article_text = article.text
try:
if proxy:
# Using requests library to send the request with the selected proxy
response = requests.get(article_url, proxies={"http": proxy, "https": proxy}, timeout=10)
if response.status_code == 200:
# If the request was successful, insert news and print proxy used
self.insert_news(source_url, article_title, article_text, article_url)
print(f"Proxy: {proxy} - Success: {article_url}")
else:
print(f"Proxy: {proxy} - Failed: {article_url}")
else:
print("No proxy available for request.")
except Exception as e:
print(f"Proxy: {proxy} - Error: {e}")
articles_scraped += 1
except Exception as e:
print(f"Error scraping from {source_url}: {e}")
def startScraping(self):
self.scraping = True
self.start_button.setEnabled(False)
self.stop_button.setEnabled(True)
self.create_table()
proxies_filename = "proxylist.txt"
# Define websites and the number of articles to scrape from each
websites = [
{'url': 'http://ft.com', 'num_articles': 5},
{'url': 'http://nytimes.com', 'num_articles': 5},
{'url': 'http://www.bloomberg.com/economics', 'num_articles': 5},
{'url': 'http://economictimes.indiatimes.com', 'num_articles': 5},
]
self.threads = []
for site in websites:
thread = Thread(target=self.scrape_news, args=(site['url'], site['num_articles'],proxies_filename))
self.threads.append(thread)
thread.start()
def stopScraping(self):
self.scraping = False
self.start_button.setEnabled(True)
self.stop_button.setEnabled(False)
for thread in self.threads:
thread.join()
def main():
app = QApplication(sys.argv)
window = NewsScraperGUI()
window.show()
sys.exit(app.exec_())
if __name__ == '__main__':
main()
```
## System Information
$ python -m requests.help
```json
C:\Python\Lib\site-packages\requests\__init__.py:102: RequestsDependencyWarning: urllib3 (1.26.15) or chardet (5.2.0)/charset_normalizer (2.0.12) doesn't match a supported version!
warnings.warn("urllib3 ({}) or chardet ({})/charset_normalizer ({}) doesn't match a supported "
C:\Python\Lib\site-packages\requests\help.py:25: DeprecationWarning: 'urllib3.contrib.pyopenssl' module is deprecated and will be removed in a future release of urllib3 2.x. Read more in this issue: https://github.com/urllib3/urllib3/issues/2680
from urllib3.contrib import pyopenssl
{
"chardet": {
"version": "5.2.0"
},
"charset_normalizer": {
"version": "2.0.12"
},
"cryptography": {
"version": "41.0.1"
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "CPython",
"version": "3.11.3"
},
"platform": {
"release": "10",
"system": "Windows"
},
"pyOpenSSL": {
"openssl_version": "30100010",
"version": "23.2.0"
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "1010114f"
},
"urllib3": {
"version": "1.26.15"
},
"using_charset_normalizer": false,
"using_pyopenssl": true
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6585/reactions"
} | https://api.github.com/repos/psf/requests/issues/6585/timeline | null | completed | null | null | false | [
"Hi @12tilak34, it looks like this may be a request for assistance rather than a bug in Requests. We're returning an error showing we're unable to connect to your proxy as it's currently been configured. We'd recommend posting on [StackOverflow](https://stackoverflow.com) for help with general usage/configuration issues. We try to reserve the GitHub issue tracker for bug reports. Thanks!"
] |
https://api.github.com/repos/psf/requests/issues/6584 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6584/labels{/name} | https://api.github.com/repos/psf/requests/issues/6584/comments | https://api.github.com/repos/psf/requests/issues/6584/events | https://github.com/psf/requests/issues/6584 | 2,010,213,698 | I_kwDOABTKOs530W1C | 6,584 | Status Code 425 named incorrectly | {
"avatar_url": "https://avatars.githubusercontent.com/u/1292953?v=4",
"events_url": "https://api.github.com/users/mephinet/events{/privacy}",
"followers_url": "https://api.github.com/users/mephinet/followers",
"following_url": "https://api.github.com/users/mephinet/following{/other_user}",
"gists_url": "https://api.github.com/users/mephinet/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mephinet",
"id": 1292953,
"login": "mephinet",
"node_id": "MDQ6VXNlcjEyOTI5NTM=",
"organizations_url": "https://api.github.com/users/mephinet/orgs",
"received_events_url": "https://api.github.com/users/mephinet/received_events",
"repos_url": "https://api.github.com/users/mephinet/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mephinet/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mephinet/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mephinet",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 4 | 2023-11-24T20:53:31Z | 2023-12-20T08:08:05Z | 2023-12-20T06:33:10Z | NONE | null | HTTP status code 425 is defined as "too early". While the defining RFC defines the code in the context of TLS, I regularly find APIs that use this status code to indicate to a client that an asynchronous job that has been started is still being processed, so the result can not yet be provided.
requests.status_codes however doesn't know the reason "too early", and instead calls 425 "unordered_collection" and "unordered". I believe, this is a bug.
The defendent: https://github.com/psf/requests/blob/main/src/requests/status_codes.py#L82
I call to the witness stand:
* https://datatracker.ietf.org/doc/html/rfc8470
* https://http.cat/425
* https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#4xx_client_errors
## Expected Result
>>> requests.codes.get("TOO_EARLY")
425
## Actual Result
>>> requests.codes.get("TOO_EARLY")
## Reproduction Steps
```python
import requests
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.0"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "CPython",
"version": "3.11.6"
},
"platform": {
"release": "6.6.1-arch1-1",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "30100040"
},
"urllib3": {
"version": "2.0.7"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6584/reactions"
} | https://api.github.com/repos/psf/requests/issues/6584/timeline | null | completed | null | null | false | [
"I would merge a change to add that to the type definition. Keep in mind unordered was in wide use before that rfc though which is why it has that definition. I doubt anyone is using it from us but we can't remove it. ",
"Implementing this in an upcoming PR.",
"Here is a PR with relevant changes that I believe are backwards compatible and generalizable. Could you take a look and give your initial thoughts? @nateprewitt",
"Resolving now that #6592 is merged."
] |
https://api.github.com/repos/psf/requests/issues/6583 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6583/labels{/name} | https://api.github.com/repos/psf/requests/issues/6583/comments | https://api.github.com/repos/psf/requests/issues/6583/events | https://github.com/psf/requests/pull/6583 | 2,009,562,420 | PR_kwDOABTKOs5gTMfk | 6,583 | Fix broken links in docs | {
"avatar_url": "https://avatars.githubusercontent.com/u/20516159?v=4",
"events_url": "https://api.github.com/users/EFord36/events{/privacy}",
"followers_url": "https://api.github.com/users/EFord36/followers",
"following_url": "https://api.github.com/users/EFord36/following{/other_user}",
"gists_url": "https://api.github.com/users/EFord36/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/EFord36",
"id": 20516159,
"login": "EFord36",
"node_id": "MDQ6VXNlcjIwNTE2MTU5",
"organizations_url": "https://api.github.com/users/EFord36/orgs",
"received_events_url": "https://api.github.com/users/EFord36/received_events",
"repos_url": "https://api.github.com/users/EFord36/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/EFord36/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/EFord36/subscriptions",
"type": "User",
"url": "https://api.github.com/users/EFord36",
"user_view_type": "public"
} | [] | closed | false | null | [] | {
"closed_at": null,
"closed_issues": 13,
"created_at": "2023-08-13T17:04:53Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
},
"description": "",
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/33",
"id": 9786066,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/33/labels",
"node_id": "MI_kwDOABTKOs4AlVLS",
"number": 33,
"open_issues": 0,
"state": "open",
"title": "2.32.0",
"updated_at": "2024-05-20T14:17:03Z",
"url": "https://api.github.com/repos/psf/requests/milestones/33"
} | 6 | 2023-11-24T11:23:44Z | 2024-02-23T11:30:47Z | 2024-02-23T11:30:46Z | CONTRIBUTOR | null | Hi,
I noticed a broken link to rfc2988 in the [timeout section of the docs](https://requests.readthedocs.io/en/latest/user/advanced/#timeouts) and thought I would fix it.
While doing that, I thought I would run the sphinx `linkcheck` builder to check for other broken links and fix them.
There were a few, some where I've 'fixed'/updated the link are hopefully uncontroversial.
Some are more controversial - removing sections written by the original author of requests that now have dead links, removing talks with dead links to slides, removing people's now dead GitHub account links. I wasn't sure what the right thing to do here was, but I went with my intuition, and kept commits pretty discrete so I can drop/amend them if the maintainers want me to do something different. If some are controversial enough to slow down the PR, I can always pull out the uncontroversial ones into their own PR for faster merging. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/6583/reactions"
} | https://api.github.com/repos/psf/requests/issues/6583/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6583.diff",
"html_url": "https://github.com/psf/requests/pull/6583",
"merged_at": "2024-02-23T11:30:46Z",
"patch_url": "https://github.com/psf/requests/pull/6583.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6583"
} | true | [
"@sigmavirus24 Thanks for your comments - I think this is ready to look at again whenever you have time. No rush from my side, I'm sure you're busy, just didn't want it to get stuck in process if you thought I was still working on it!",
"Thanks @Jamim for the review!\r\n\r\nIt looks like GitHub still wants an approval from a reviewer with write access - I'm guessing you don't have write access (just checking in case something has gone wrong with the process)?\r\n\r\nI've just rebased against main so this is fresh and to give the GitHub checks another change to pass - looks like the `build` checks for any python >3.7 are failing with this error:\r\n\r\n```\r\nImportError: cannot import name 'parse_authorization_header' from 'werkzeug.http' (/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/werkzeug/http.py)\r\n```\r\n\r\nBut the 3.7 ones pass, and this error also occurred in the checks for the latest commit to main, so this seems to be an unrelated `wekzeug` dependency-related issue to me.\r\n\r\n",
"> I'm guessing you don't have write access\r\n\r\nThat's true. I just wanted to support your contribution 😃",
"@EFord36 would you be willing to rebase/resolve the conflicts here?",
"> @EFord36 would you be willing to rebase/resolve the conflicts here?\r\n\r\nHi,\r\n\r\nI've done that now, thanks for the reminder!",
"Thank you! "
] |
https://api.github.com/repos/psf/requests/issues/6582 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6582/labels{/name} | https://api.github.com/repos/psf/requests/issues/6582/comments | https://api.github.com/repos/psf/requests/issues/6582/events | https://github.com/psf/requests/issues/6582 | 2,008,770,091 | I_kwDOABTKOs53u2Yr | 6,582 | "Recommended Packages and Extensions" page asyncio recommendations are outdated | {
"avatar_url": "https://avatars.githubusercontent.com/u/1574099?v=4",
"events_url": "https://api.github.com/users/ngie-eign/events{/privacy}",
"followers_url": "https://api.github.com/users/ngie-eign/followers",
"following_url": "https://api.github.com/users/ngie-eign/following{/other_user}",
"gists_url": "https://api.github.com/users/ngie-eign/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ngie-eign",
"id": 1574099,
"login": "ngie-eign",
"node_id": "MDQ6VXNlcjE1NzQwOTk=",
"organizations_url": "https://api.github.com/users/ngie-eign/orgs",
"received_events_url": "https://api.github.com/users/ngie-eign/received_events",
"repos_url": "https://api.github.com/users/ngie-eign/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ngie-eign/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ngie-eign/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ngie-eign",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2023-11-23T20:41:53Z | 2023-12-28T02:07:05Z | null | NONE | null | While looking for an asyncio compatible recommendation for requests, I stumbled on the [documentation](https://requests.readthedocs.io/en/latest/community/recommended/) provided by the project. It recommends Request-Threads, which does not seem to be actively developed (no new changes/releases in the past 5 years). txrequests is an alternative Twisted-based package that seems to be more recommended these days: https://pypi.org/project/txrequests/ .
Moreover, requests.Async is not mentioned; this support was moved to https://pypi.org/project/gevent-requests/ (mentioned in History.md). [1]
1. Note to other readers: gevent-requests is the library that requires gevent/greenlet and achieves asynchronous processing via green threads: it doesn't achieve this via native python asyncio coroutines. | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6582/reactions"
} | https://api.github.com/repos/psf/requests/issues/6582/timeline | null | null | null | null | false | [] |
https://api.github.com/repos/psf/requests/issues/6581 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6581/labels{/name} | https://api.github.com/repos/psf/requests/issues/6581/comments | https://api.github.com/repos/psf/requests/issues/6581/events | https://github.com/psf/requests/pull/6581 | 2,006,152,633 | PR_kwDOABTKOs5gHuwm | 6,581 | fix docstring typo: a -> as | {
"avatar_url": "https://avatars.githubusercontent.com/u/20516159?v=4",
"events_url": "https://api.github.com/users/EFord36/events{/privacy}",
"followers_url": "https://api.github.com/users/EFord36/followers",
"following_url": "https://api.github.com/users/EFord36/following{/other_user}",
"gists_url": "https://api.github.com/users/EFord36/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/EFord36",
"id": 20516159,
"login": "EFord36",
"node_id": "MDQ6VXNlcjIwNTE2MTU5",
"organizations_url": "https://api.github.com/users/EFord36/orgs",
"received_events_url": "https://api.github.com/users/EFord36/received_events",
"repos_url": "https://api.github.com/users/EFord36/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/EFord36/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/EFord36/subscriptions",
"type": "User",
"url": "https://api.github.com/users/EFord36",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 0 | 2023-11-22T11:36:50Z | 2023-12-28T02:09:19Z | 2023-11-22T15:10:48Z | CONTRIBUTOR | null | Hi,
I noticed a typo in this docstring, thought I would write a quick PR to fix it.
As far as I can see, this docstring doesn't get added to the rendered html docs on https://requests.readthedocs.io/en/latest/ - they are only visible when viewing the source code.
I've not bothered running tests etc. given its such a small change, but please let me know if there's more you want me to do for this.
Thanks for requests! | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6581/reactions"
} | https://api.github.com/repos/psf/requests/issues/6581/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6581.diff",
"html_url": "https://github.com/psf/requests/pull/6581",
"merged_at": "2023-11-22T15:10:48Z",
"patch_url": "https://github.com/psf/requests/pull/6581.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6581"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6580 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6580/labels{/name} | https://api.github.com/repos/psf/requests/issues/6580/comments | https://api.github.com/repos/psf/requests/issues/6580/events | https://github.com/psf/requests/pull/6580 | 2,002,577,817 | PR_kwDOABTKOs5f7iea | 6,580 | Bump dessant/lock-threads from 4.0.1 to 5.0.0 | {
"avatar_url": "https://avatars.githubusercontent.com/in/29110?v=4",
"events_url": "https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/dependabot%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/dependabot",
"id": 49699333,
"login": "dependabot[bot]",
"node_id": "MDM6Qm90NDk2OTkzMzM=",
"organizations_url": "https://api.github.com/users/dependabot%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/dependabot%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/dependabot%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dependabot%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/dependabot%5Bbot%5D",
"user_view_type": "public"
} | [
{
"color": "0366d6",
"default": false,
"description": "Pull requests that update a dependency file",
"id": 1868210094,
"name": "dependencies",
"node_id": "MDU6TGFiZWwxODY4MjEwMDk0",
"url": "https://api.github.com/repos/psf/requests/labels/dependencies"
},
{
"color": "000000",
"default": false,
"description": "Pull requests that update GitHub Actions code",
"id": 5838729011,
"name": "github_actions",
"node_id": "LA_kwDOABTKOs8AAAABXAPvMw",
"url": "https://api.github.com/repos/psf/requests/labels/github_actions"
}
] | closed | false | null | [] | null | 0 | 2023-11-20T16:28:18Z | 2023-11-20T16:37:08Z | 2023-11-20T16:37:07Z | CONTRIBUTOR | null | Bumps [dessant/lock-threads](https://github.com/dessant/lock-threads) from 4.0.1 to 5.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dessant/lock-threads/releases">dessant/lock-threads's releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<p>Learn more about this release from the <a href="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md#changelog">changelog</a>.</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md">dessant/lock-threads's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<p>All notable changes to this project will be documented in this file. See <a href="https://github.com/absolute-version/commit-and-tag-version">commit-and-tag-version</a> for commit guidelines.</p>
<h2><a href="https://github.com/dessant/lock-threads/compare/v4.0.1...v5.0.0">5.0.0</a> (2023-11-14)</h2>
<h3>⚠ BREAKING CHANGES</h3>
<ul>
<li>Discussions are also processed by default,
set the <code>process-only</code> input parameter to preserve the old behavior</li>
</ul>
<pre lang="yaml"><code> steps:
- uses: dessant/lock-threads@v5
with:
process-only: 'issues, prs'
</code></pre>
<ul>
<li>the action now requires Node.js 20</li>
</ul>
<h3>Features</h3>
<ul>
<li>lock discussions (<a href="https://github.com/dessant/lock-threads/commit/0a0976f3ded51c88c6128dd96dd115c9f14fa764">0a0976f</a>), closes <a href="https://redirect.github.com/dessant/lock-threads/issues/25">#25</a></li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>update dependencies (<a href="https://github.com/dessant/lock-threads/commit/5a25b54eae3e7a5580d09ef0f7cbc5b18376db67">5a25b54</a>)</li>
</ul>
<h3><a href="https://github.com/dessant/lock-threads/compare/v4.0.0...v4.0.1">4.0.1</a> (2023-06-12)</h3>
<h3>Bug Fixes</h3>
<ul>
<li>retry and throttle GitHub API requests (<a href="https://github.com/dessant/lock-threads/commit/1618e91da69b9fe614fb9837ac673ea4600eb529">1618e91</a>), closes <a href="https://redirect.github.com/dessant/lock-threads/issues/35">#35</a></li>
</ul>
<h2><a href="https://github.com/dessant/lock-threads/compare/v3.0.0...v4.0.0">4.0.0</a> (2022-12-04)</h2>
<h3>⚠ BREAKING CHANGES</h3>
<ul>
<li>the action now requires Node.js 16</li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>update dependencies (<a href="https://github.com/dessant/lock-threads/commit/38e918558115222435d26c0639870cdbe3572929">38e9185</a>)</li>
<li>update docs (<a href="https://github.com/dessant/lock-threads/commit/32986e26965060a85db09e98ef7e5958c961ae84">32986e2</a>)</li>
</ul>
<h2><a href="https://github.com/dessant/lock-threads/compare/v2.1.2...v3.0.0">3.0.0</a> (2021-09-27)</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/dessant/lock-threads/commit/d42e5f49803f3c4e14ffee0378e31481265dda22"><code>d42e5f4</code></a> chore(release): 5.0.0</li>
<li><a href="https://github.com/dessant/lock-threads/commit/d8da6c1485cbe748b5b632f1a52cf2a52941cbf9"><code>d8da6c1</code></a> chore: update package</li>
<li><a href="https://github.com/dessant/lock-threads/commit/c1eab4b45f97073a922fbd226afab0e34a70cf5f"><code>c1eab4b</code></a> chore: update workflow</li>
<li><a href="https://github.com/dessant/lock-threads/commit/0a0976f3ded51c88c6128dd96dd115c9f14fa764"><code>0a0976f</code></a> feat: lock discussions</li>
<li><a href="https://github.com/dessant/lock-threads/commit/53f3f0c0b9158bece84746885adc5f4bf2dd1ddc"><code>53f3f0c</code></a> chore: migrate package to ESM</li>
<li><a href="https://github.com/dessant/lock-threads/commit/5a25b54eae3e7a5580d09ef0f7cbc5b18376db67"><code>5a25b54</code></a> fix: update dependencies</li>
<li>See full diff in <a href="https://github.com/dessant/lock-threads/compare/be8aa5be94131386884a6da4189effda9b14aa21...d42e5f49803f3c4e14ffee0378e31481265dda22">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details> | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6580/reactions"
} | https://api.github.com/repos/psf/requests/issues/6580/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6580.diff",
"html_url": "https://github.com/psf/requests/pull/6580",
"merged_at": "2023-11-20T16:37:07Z",
"patch_url": "https://github.com/psf/requests/pull/6580.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6580"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6579 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6579/labels{/name} | https://api.github.com/repos/psf/requests/issues/6579/comments | https://api.github.com/repos/psf/requests/issues/6579/events | https://github.com/psf/requests/pull/6579 | 2,002,471,745 | PR_kwDOABTKOs5f7LRa | 6,579 | Call url.lower() once inside get_adapter | {
"avatar_url": "https://avatars.githubusercontent.com/u/1334295?v=4",
"events_url": "https://api.github.com/users/bfontaine/events{/privacy}",
"followers_url": "https://api.github.com/users/bfontaine/followers",
"following_url": "https://api.github.com/users/bfontaine/following{/other_user}",
"gists_url": "https://api.github.com/users/bfontaine/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bfontaine",
"id": 1334295,
"login": "bfontaine",
"node_id": "MDQ6VXNlcjEzMzQyOTU=",
"organizations_url": "https://api.github.com/users/bfontaine/orgs",
"received_events_url": "https://api.github.com/users/bfontaine/received_events",
"repos_url": "https://api.github.com/users/bfontaine/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bfontaine/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bfontaine/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bfontaine",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2023-11-20T15:36:18Z | 2023-11-21T09:19:10Z | 2023-11-21T09:19:06Z | NONE | null | This is a re-proposal of https://github.com/psf/requests/pull/5497 three years later. The typical use-case for adaptaters is to create one and then mount it for both `http://` and `https://`. When using https:// URLs, this result in two calls to `url.lower()`, whereas with the optimization by @dbaxa this is computed only once.
IMHO the `prefix.lower()` thing should also be computed only once when we add the adapter, but I don’t know if this could break some code. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1334295?v=4",
"events_url": "https://api.github.com/users/bfontaine/events{/privacy}",
"followers_url": "https://api.github.com/users/bfontaine/followers",
"following_url": "https://api.github.com/users/bfontaine/following{/other_user}",
"gists_url": "https://api.github.com/users/bfontaine/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bfontaine",
"id": 1334295,
"login": "bfontaine",
"node_id": "MDQ6VXNlcjEzMzQyOTU=",
"organizations_url": "https://api.github.com/users/bfontaine/orgs",
"received_events_url": "https://api.github.com/users/bfontaine/received_events",
"repos_url": "https://api.github.com/users/bfontaine/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bfontaine/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bfontaine/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bfontaine",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/6579/reactions"
} | https://api.github.com/repos/psf/requests/issues/6579/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6579.diff",
"html_url": "https://github.com/psf/requests/pull/6579",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6579.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6579"
} | true | [
"@bfontaine the real issue here is that in the past reasonable, low risk changes like this lead to nonsensical \"optimization\" PRs that do break things and otherwise look low risk. As with this PR there are no benchmarks showing the actual improvement. And we have a dependency preventing our CI from being reliable. Finally, in general small improvements like this if we start accepting them add up and obfuscate the history of the project which given it's complexity is helpful for Nate and I in our very limited time",
"Understood. From my quick benchmark the performance gain would be of 0.05s for 1M requests, which is nothing. Sorry for the noise."
] |
https://api.github.com/repos/psf/requests/issues/6578 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6578/labels{/name} | https://api.github.com/repos/psf/requests/issues/6578/comments | https://api.github.com/repos/psf/requests/issues/6578/events | https://github.com/psf/requests/issues/6578 | 2,000,644,097 | I_kwDOABTKOs53P2gB | 6,578 | Weird behaviour with https and proxy authentication | {
"avatar_url": "https://avatars.githubusercontent.com/u/121585704?v=4",
"events_url": "https://api.github.com/users/sigscanner/events{/privacy}",
"followers_url": "https://api.github.com/users/sigscanner/followers",
"following_url": "https://api.github.com/users/sigscanner/following{/other_user}",
"gists_url": "https://api.github.com/users/sigscanner/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigscanner",
"id": 121585704,
"login": "sigscanner",
"node_id": "U_kgDOBz9AKA",
"organizations_url": "https://api.github.com/users/sigscanner/orgs",
"received_events_url": "https://api.github.com/users/sigscanner/received_events",
"repos_url": "https://api.github.com/users/sigscanner/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigscanner/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigscanner/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigscanner",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 4 | 2023-11-19T00:56:06Z | 2023-11-24T08:05:43Z | null | NONE | null | <!-- Summary. -->
requests.get is getting weird with some combinations of dictionary keys and proxy authentication.
## Expected Result
```python
print(requests.get('https://google.com', proxies={"https" : 'https://user:pass@ip:port'}))
```
Output:
`<Response [200]>`
<!-- What you expected. -->
## Actual Result
Doesn't run? (Maybe timeout)
But it somehow fixes itself with these changes
```python
print(requests.get('https://google.com', proxies={"http" : 'http://user:pass@ip:port'}))
```
Output:
`<Response [200]>`
<!-- What happened instead. -->
## Reproduction Steps
```python
import requests
print(requests.get('https://google.com', proxies={"https" : 'https://user:pass@ip:port'}))
print(requests.get('https://google.com', proxies={"http" : 'http://user:pass@ip:port'}))
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.12"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "CPython",
"version": "3.10.11"
},
"platform": {
"release": "10",
"system": "Windows"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.27.1"
},
"system_ssl": {
"version": "1010114f"
},
"urllib3": {
"version": "1.26.9"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
````
$ python --version
Python 3.10.11
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/121585704?v=4",
"events_url": "https://api.github.com/users/sigscanner/events{/privacy}",
"followers_url": "https://api.github.com/users/sigscanner/followers",
"following_url": "https://api.github.com/users/sigscanner/following{/other_user}",
"gists_url": "https://api.github.com/users/sigscanner/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigscanner",
"id": 121585704,
"login": "sigscanner",
"node_id": "U_kgDOBz9AKA",
"organizations_url": "https://api.github.com/users/sigscanner/orgs",
"received_events_url": "https://api.github.com/users/sigscanner/received_events",
"repos_url": "https://api.github.com/users/sigscanner/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigscanner/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigscanner/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigscanner",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6578/reactions"
} | https://api.github.com/repos/psf/requests/issues/6578/timeline | null | reopened | null | null | false | [
"proxies im using are https capable",
"misclick",
"its most likely that your proxies only support http protocol, it should work the way you have it, so its probably proxy issues.",
"> proxies im using are https capable\r\n\r\n\r\n\r\n> its most likely that your proxies only support http protocol, it should work the way you have it, so its probably proxy issues.\r\n\r\n"
] |
https://api.github.com/repos/psf/requests/issues/6577 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6577/labels{/name} | https://api.github.com/repos/psf/requests/issues/6577/comments | https://api.github.com/repos/psf/requests/issues/6577/events | https://github.com/psf/requests/issues/6577 | 2,000,033,224 | I_kwDOABTKOs53NhXI | 6,577 | Improper URL serialization of boolean GET parameters | {
"avatar_url": "https://avatars.githubusercontent.com/u/78057064?v=4",
"events_url": "https://api.github.com/users/mspi21/events{/privacy}",
"followers_url": "https://api.github.com/users/mspi21/followers",
"following_url": "https://api.github.com/users/mspi21/following{/other_user}",
"gists_url": "https://api.github.com/users/mspi21/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mspi21",
"id": 78057064,
"login": "mspi21",
"node_id": "MDQ6VXNlcjc4MDU3MDY0",
"organizations_url": "https://api.github.com/users/mspi21/orgs",
"received_events_url": "https://api.github.com/users/mspi21/received_events",
"repos_url": "https://api.github.com/users/mspi21/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mspi21/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mspi21/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mspi21",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2023-11-17T22:36:19Z | 2023-11-18T10:40:43Z | 2023-11-18T01:05:00Z | NONE | null | <!-- Summary. -->
Constructing a GET request with a boolean parameter `foo` set to `True` results in `&foo=True` being appended to the URL path, instead of just `&foo`. This makes it inoperable with some APIs (such as the [NIST CVE API](https://nvd.nist.gov/developers/vulnerabilities)) that return an error when a string value is set for a boolean GET parameter.
Example:
```py
>>> import requests
>>> API_URL = "https://services.nvd.nist.gov/rest/json/cves/2.0"
>>> res = requests.get(API_URL, params={"noRejected": True})
>>> res
<Response [404]>
>>> res.headers["message"]
'noRejected parameter cannot have a value.'
```
It's a mystery to me how such a basic feature of the de-facto standard library for making HTTP requests in Python hasn't yet been addressed and I would greatly appreciate if it could be fixed, or at least if a special value/object was added that could be passed as a value in `params` to produce the expected result. Working around this limitation by constructing the URL with all its parameters myself as a programmer does not inspire confidence in the security and correctness of the code.
## Expected Result
```py
>>> res.request.path_url
'/rest/json/cves/2.0?noRejected'
```
## Actual Result
```py
>>> res.request.path_url
'/rest/json/cves/2.0?noRejected=True'
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": "5.1.0"
},
"charset_normalizer": {
"version": "3.0.1"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.3"
},
"implementation": {
"name": "CPython",
"version": "3.11.2"
},
"platform": {
"release": "6.1.0-13-amd64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.28.1"
},
"system_ssl": {
"version": "300000b0"
},
"urllib3": {
"version": "1.26.12"
},
"using_charset_normalizer": false,
"using_pyopenssl": false
}
``` | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6577/reactions"
} | https://api.github.com/repos/psf/requests/issues/6577/timeline | null | completed | null | null | false | [
"In the future, please search **closed and** open issues before creating new ones that are duplicates.",
"> In the future, please search **closed and** open issues before creating new ones that are duplicates.\r\n\r\nWhat makes you think I haven't done that? Instead of lecturing me, the minimum you can do is provide a link or an ID. @sigmavirus24 "
] |
https://api.github.com/repos/psf/requests/issues/6576 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6576/labels{/name} | https://api.github.com/repos/psf/requests/issues/6576/comments | https://api.github.com/repos/psf/requests/issues/6576/events | https://github.com/psf/requests/issues/6576 | 1,997,783,822 | I_kwDOABTKOs53E8MO | 6,576 | Possible regression with how MaxRetryError is handled | {
"avatar_url": "https://avatars.githubusercontent.com/u/3455235?v=4",
"events_url": "https://api.github.com/users/mike406/events{/privacy}",
"followers_url": "https://api.github.com/users/mike406/followers",
"following_url": "https://api.github.com/users/mike406/following{/other_user}",
"gists_url": "https://api.github.com/users/mike406/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mike406",
"id": 3455235,
"login": "mike406",
"node_id": "MDQ6VXNlcjM0NTUyMzU=",
"organizations_url": "https://api.github.com/users/mike406/orgs",
"received_events_url": "https://api.github.com/users/mike406/received_events",
"repos_url": "https://api.github.com/users/mike406/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mike406/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mike406/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mike406",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2023-11-16T21:07:04Z | 2023-11-17T13:31:11Z | 2023-11-17T01:45:56Z | NONE | null | Since requests does not retry failed connections, a somewhat confusion exception is encountered by doing something like this.
```
>>> requests.get('http://localhost:12121')
...
requests.exceptions.ConnectionError: HTTPConnectionPool(host='localhost', port=12121): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x0000029B47D92CF8>: Failed to establish a new connection: [WinError 10061] No connection could be made because the target machine actively refused it',))
```
I found in my searches about this exception that years ago this issue was reported and resolved in urllib3 by adding the ability to specify `retries=False` in the request: https://github.com/psf/requests/issues/1198#issuecomment-34582901
The result of the change back then gave a nicer exception output: https://github.com/psf/requests/issues/1198#issuecomment-57952852
Is this a regression, and if possible, could there once again be a way to get a cleaner exception message for this case? Thank you. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6576/reactions"
} | https://api.github.com/repos/psf/requests/issues/6576/timeline | null | completed | null | null | false | [
"There is no regression here. That thread allows that for retries=False but requests always configures retries by default. You'll want to customize an HTTPAdapter to specify different behavior if you don't want to see a MaxRetryError in the exception message ",
"So how many retries does requests configure? The docs say requests does not do any unless you use Session() https://requests.readthedocs.io/en/latest/user/advanced/#example-automatic-retries\r\n\r\nAlso I tried configuring HTTPAdapter with max_retries=0 or max_retries=False and the exception did not change. Am I doing something incorrectly?\r\n\r\n```\r\nfrom requests import Session\r\nfrom requests.adapters import HTTPAdapter\r\n\r\ns = Session()\r\na = HTTPAdapter(max_retries=0)\r\ns.mount('http://', a)\r\ns.get('http://localhost:12121')\r\n```"
] |
https://api.github.com/repos/psf/requests/issues/6575 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6575/labels{/name} | https://api.github.com/repos/psf/requests/issues/6575/comments | https://api.github.com/repos/psf/requests/issues/6575/events | https://github.com/psf/requests/issues/6575 | 1,996,617,355 | I_kwDOABTKOs53AfaL | 6,575 | Requests post not working with long processing time. | {
"avatar_url": "https://avatars.githubusercontent.com/u/105340843?v=4",
"events_url": "https://api.github.com/users/luisbnzsa/events{/privacy}",
"followers_url": "https://api.github.com/users/luisbnzsa/followers",
"following_url": "https://api.github.com/users/luisbnzsa/following{/other_user}",
"gists_url": "https://api.github.com/users/luisbnzsa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/luisbnzsa",
"id": 105340843,
"login": "luisbnzsa",
"node_id": "U_kgDOBkdfqw",
"organizations_url": "https://api.github.com/users/luisbnzsa/orgs",
"received_events_url": "https://api.github.com/users/luisbnzsa/received_events",
"repos_url": "https://api.github.com/users/luisbnzsa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/luisbnzsa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/luisbnzsa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/luisbnzsa",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156042717,
"name": "actions/autoclose-qa",
"node_id": "LA_kwDOABTKOs8AAAABbu3B3Q",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-qa"
}
] | closed | false | null | [] | null | 1 | 2023-11-16T11:10:35Z | 2023-11-29T12:35:09Z | 2023-11-29T12:12:19Z | NONE | null | Hello.
I am creating server API using FASTAPI/Uvicorn.
I am processing files with big AI models that are slow to process. When the file is lower than 10 Mb, everything works fine. But when longer, it implies that it will take more than 3 minutes. By doing the request post, on large files, the post does not get the response. The server continues as the process and shows 200 OK. So on the server side, everything seems fine but the request keeps running and does not get the ok code neither the data back. If I don´t add a timeout it will keep forever. If I add the timeout, it gives the error because it did not get the response.
I am running the server like this
`uvicorn app.main:app --host 0.0.0.0 --port 8080 --reload --timeout-keep-alive 600 --ws-ping-timeout 500`
Adding a timeout keep alive of 600 seconds to make sure it can handle big files.
Now when I do the request, it won´t work. Then I tested this to check when it loses connection
`@app.post("/pru/")
async def pru():
print("Comenzamos")
time.sleep(275)
return "Devolucion " + time.strftime("%Y-%m-%d %H:%M:%S", time.gmtime())
`
After making a post request to /pru/ using a sleep timer, I found out that 275 seconds is the time threshold when requests loses connection with the server and does not get anything back. Anything lower works fine.
Now, if I change the post to get, and I do it on Google Chrome browser, it works fine, even with 500 seconds.
Does anyone knows why the requests loses connection with the server or why it does not receives the message back from the server?
I investigated more, and some people recommended using TCPKeepAliveAdapter and stream = True. but that works with GET but not with POST. I have it like this.
`keep_alive = TCPKeepAliveAdapter(idle=5, count=60, interval=10)
s = requests.Session()
s.mount("http://20.30.30.30:8080/aupro/tran-d/", keep_alive)
r = s.post(url="http://20.30.30.30:8080/aupro/tran-d/", files=archivo, stream=True,timeout=400)`
Any advise? I don´t know what else to try.
Thanks in advance. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6575/reactions"
} | https://api.github.com/repos/psf/requests/issues/6575/timeline | null | not_planned | null | null | false | [
"At the end the solution I found, if anyone needs it, was not on the client side but in the server side. Something underneath is closing the connection after 275 seconds, so the solution was to create function in a threding.Thread, while the process is alive. It sends text messages every 30 seconds. In that way, both sides know that the connection is alive. I tested with a 5 minutes process. I used StreamingResponse to make it happen.\r\n\r\n que = queue.Queue()\r\n def director():\r\n # Esta funcion se utiliza para poder enviar mensajes periodicamente cada 30 segundos\r\n # es necesaria para mantener la conexión activa con el cliente en archivos que requeren \r\n # más de 270 segundos para procesar\r\n resultado = \"\"\r\n t = Thread(target=lambda q, arg : q.put(trandia(arg)), args=(que, resultado,))\r\n t.start()\r\n while t.is_alive():\r\n t.join(30)\r\n yield \"#processing...#\"\r\n \r\n yield que.get()\r\n \r\n return StreamingResponse(director(), media_type='text/event-stream')\r\n\r\n"
] |
https://api.github.com/repos/psf/requests/issues/6574 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6574/labels{/name} | https://api.github.com/repos/psf/requests/issues/6574/comments | https://api.github.com/repos/psf/requests/issues/6574/events | https://github.com/psf/requests/pull/6574 | 1,995,849,469 | PR_kwDOABTKOs5fk4ok | 6,574 | Fix missing space in error message | {
"avatar_url": "https://avatars.githubusercontent.com/u/2788918?v=4",
"events_url": "https://api.github.com/users/msea1/events{/privacy}",
"followers_url": "https://api.github.com/users/msea1/followers",
"following_url": "https://api.github.com/users/msea1/following{/other_user}",
"gists_url": "https://api.github.com/users/msea1/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/msea1",
"id": 2788918,
"login": "msea1",
"node_id": "MDQ6VXNlcjI3ODg5MTg=",
"organizations_url": "https://api.github.com/users/msea1/orgs",
"received_events_url": "https://api.github.com/users/msea1/received_events",
"repos_url": "https://api.github.com/users/msea1/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/msea1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/msea1/subscriptions",
"type": "User",
"url": "https://api.github.com/users/msea1",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 0 | 2023-11-16T01:08:02Z | 2023-11-16T22:26:46Z | 2023-11-16T07:44:49Z | CONTRIBUTOR | null | InvalidHeader got a smushed together error message due to no trailing space on first line. | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6574/reactions"
} | https://api.github.com/repos/psf/requests/issues/6574/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6574.diff",
"html_url": "https://github.com/psf/requests/pull/6574",
"merged_at": "2023-11-16T07:44:49Z",
"patch_url": "https://github.com/psf/requests/pull/6574.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6574"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6573 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6573/labels{/name} | https://api.github.com/repos/psf/requests/issues/6573/comments | https://api.github.com/repos/psf/requests/issues/6573/events | https://github.com/psf/requests/issues/6573 | 1,994,290,940 | I_kwDOABTKOs523nb8 | 6,573 | The connection does not close automatically; it is not possible to close the session manually in recent versions of requests. | {
"avatar_url": "https://avatars.githubusercontent.com/u/61022210?v=4",
"events_url": "https://api.github.com/users/snooppr/events{/privacy}",
"followers_url": "https://api.github.com/users/snooppr/followers",
"following_url": "https://api.github.com/users/snooppr/following{/other_user}",
"gists_url": "https://api.github.com/users/snooppr/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/snooppr",
"id": 61022210,
"login": "snooppr",
"node_id": "MDQ6VXNlcjYxMDIyMjEw",
"organizations_url": "https://api.github.com/users/snooppr/orgs",
"received_events_url": "https://api.github.com/users/snooppr/received_events",
"repos_url": "https://api.github.com/users/snooppr/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/snooppr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/snooppr/subscriptions",
"type": "User",
"url": "https://api.github.com/users/snooppr",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 3 | 2023-11-15T08:30:36Z | 2023-11-17T14:28:10Z | 2023-11-17T10:32:20Z | NONE | null | ## When it worked correctly.
Configuration:
OS debian 10;
python3.8;
requests=2.28.0;
urllib=1.26.14
1.
`$python`
```python
import requests
r = requests.get("https://fantlab.ru")
# After processing the request, the connection was automatically closed with the status TIME_WAIT.
```
2.
`$python`
```python
import requests
s = requests.Session()
r = s.get("https://fantlab.ru")
# The connection is held until it is closed manually, the status is ESTABLISHED
s.close() #The connection is closed successfully, status is TIME_WAIT
```
## Doesn't work correctly. Update libraries
requests=2.31.0;
urllib3=2.1.0.
1.
`$python`
```python
import requests
r = requests.get("https://fantlab.ru")
#The behavior is now different and the connection is not closed after it has been processed, the status is ESTABLISHED
r.close() #Trying to close the connection manually also doesn't work
#Console exit (ctrl+d) successfully closes connection, status is TIME_WAIT
```
2.
`$python`
```python
import requests
s = requests.Session()
r = s.get("https://fantlab.ru")
# The connection is held until it is closed manually, the status is ESTABLISHED
s.close()
r.close()
#forced attempt to close connection manually does not work, status is ESTABLISHED
#The connection is closed only when the console exits.
```
**Thus, after library updates, the connection cannot be managed manually (closed), it stopped working.** | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6573/reactions"
} | https://api.github.com/repos/psf/requests/issues/6573/timeline | null | completed | null | null | false | [
"Hi @snooppr, can you help limit the scope of changes? Does this combination of dependencies produce the issue? If not, this is likely related to urllib3 2.x.\n\n```\nrequests=2.31.0\nurllib=1.26.14\n```",
"@nateprewitt HI!\r\n\r\nYes, I checked, this problem occurs due to urllib3.\r\nIn configuration:\r\nrequests=2.31.0\r\nurllib3=1.26.14\r\nThe connection is manually closed as usual.\r\n\r\nShould we open issues in urllib3 or will the requests developers do it? (requests is completely dependent on urllib3)\r\n\r\nupd.\r\n>related to urllib3 2.x.\r\n\r\nThis problem also occurs due to urllib3.\r\nIn configuration:\r\nrequests=2.31.0\r\nurllib=**1.26.18**\r\nThe connection is not closed either manually or after a request.",
"Rewrite the documentation, urllib3 behavior has changed. And it will confuse users of requests.\r\n\r\n> close()\r\nCloses all adapters and as such the session\r\n\r\n[doc](https://docs.python-requests.org/en/latest/api/#request-sessions)"
] |
https://api.github.com/repos/psf/requests/issues/6572 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6572/labels{/name} | https://api.github.com/repos/psf/requests/issues/6572/comments | https://api.github.com/repos/psf/requests/issues/6572/events | https://github.com/psf/requests/issues/6572 | 1,992,833,917 | I_kwDOABTKOs52yDt9 | 6,572 | Documentation Improvement - Add more code examples | {
"avatar_url": "https://avatars.githubusercontent.com/u/13994701?v=4",
"events_url": "https://api.github.com/users/sarah-afiya/events{/privacy}",
"followers_url": "https://api.github.com/users/sarah-afiya/followers",
"following_url": "https://api.github.com/users/sarah-afiya/following{/other_user}",
"gists_url": "https://api.github.com/users/sarah-afiya/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sarah-afiya",
"id": 13994701,
"login": "sarah-afiya",
"node_id": "MDQ6VXNlcjEzOTk0NzAx",
"organizations_url": "https://api.github.com/users/sarah-afiya/orgs",
"received_events_url": "https://api.github.com/users/sarah-afiya/received_events",
"repos_url": "https://api.github.com/users/sarah-afiya/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sarah-afiya/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sarah-afiya/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sarah-afiya",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 3 | 2023-11-14T14:15:27Z | 2023-11-20T20:56:46Z | 2023-11-17T10:31:49Z | NONE | null | Hi,
While looking at Requests’ [Documentation](https://requests.readthedocs.io/en/latest/), I noticed that some APIs do not have code examples.
Specifically, I found that out of the 89 API methods that appear in the documentation, 68 methods do not have code examples. Looking at Stack Overflow, I see that there are several questions regarding those methods, which suggests that adding code examples for them might be useful.
For example:
- The method _**requests.Session.close**_ has no examples in the documentation, but there are 10 questions in stackoverflow regarding this method. [Here](https://stackoverflow.com/questions/49253246/how-to-close-requests-session) is an example.
- The method _**requests.cookies.RequestsCookieJar.set**_ has no examples in the documentation, but there are several questions in stackoverflow regarding this method. [Here](https://stackoverflow.com/questions/75514573/where-can-i-find-python-requests-library-functions-kwargs-parameters-documente) is an example.
Do you agree that adding code examples for these methods can improve requests’ documentation? If yes, would you like me to create a PR updating the documentation?
Note that I got the above results from our [documentation quality analysis tool](https://github.com/ualberta-smr/DocumentationQuality), which analyzes a library's documentation and source code to determine the documentation quality. We developed this tool at the University of Alberta as part of our research on assessing documentation quality.
Requests version used: v2.31.0.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6572/reactions"
} | https://api.github.com/repos/psf/requests/issues/6572/timeline | null | completed | null | null | false | [
"> * The method _**requests.Session.close**_ has no examples in the documentation, but there are 10 questions in stackoverflow regarding this method. [Here](https://stackoverflow.com/questions/49253246/how-to-close-requests-session) is an example.\r\n\r\nThe existence of questions does not imply the need for a code example. For this one in particular, what kind of example do you think would be useful here?\r\n\r\n> * The method _**requests.cookies.RequestsCookieJar.set**_ has no examples in the documentation, but there are several questions in stackoverflow regarding this method. [Here](https://stackoverflow.com/questions/75514573/where-can-i-find-python-requests-library-functions-kwargs-parameters-documente) is an example.\r\n\r\nAgain, an example here would look like what? This isn't users should be using often if at all. So what code example would be useful?\r\n\r\n---\r\n\r\nStackOverflow is full of people doing things they shouldn't with this library's internals. That doesn't mean we should add documentation to help them do things that 99.9% of the time they don't need to care about.",
"Closing since the has been no response",
"Apologies for the late response, as I was investigating the problem with Session.close below. \r\n\r\n> > * The method _**requests.Session.close**_ has no examples in the documentation, but there are 10 questions in stackoverflow regarding this method. [Here](https://stackoverflow.com/questions/49253246/how-to-close-requests-session) is an example.\r\n> \r\n> The existence of questions does not imply the need for a code example. For this one in particular, what kind of example do you think would be useful here?\r\n> \r\nThe primary intuition of a developer would be that once a session has been closed, it is unusable. (For example, while working with a file.) But it seems like for Session.close it is not the same. \r\n\r\nSo, for this particular case, an example that shows that a Session object can still be used after closing would be useful. Also, if we look at the number of views of this question (17K views), it shows that many developers might be facing the same issue, and having a code example (or clarification) in the documentation might be useful.\r\n\r\n\r\nHowever, I am not sure if this is the expected behavior or a bug because a part of the doc says, \r\n\r\n> ```\r\n> with requests.Session() as s:\r\n> s.get('https://httpbin.org/cookies/set/sessioncookie/123456789')\r\n> ```\r\n> \r\n> This will make sure the session is closed as soon as the with block is exited, even if unhandled exceptions occurred.\r\n\r\n \r\n\r\nBut when I tried the example code below, it showed that the session was still not closed.\r\n\r\n```\r\nuserName = {'username': 'JohnDoe'}\r\nlocation = {'location': 'XYZ'}\r\n\r\nsetCookieUrl = 'https://httpbin.org/cookies/set'\r\ngetCookieUrl = 'https://httpbin.org/cookies'\r\n\r\nwith requests.Session() as s:\r\n s.get(setCookieUrl, params=userName)\r\n s.get(setCookieUrl, params=location)\r\n r = s.get(getCookieUrl)\r\n print(r.text) # Prints the cookies\r\n\r\n\r\nr2 = s.get(getCookieUrl)\r\nprint(r2.text) # Still prints the same cookies\r\n```\r\nThus, the expected behavior should be misleading. This could be fixed by updating the quoted documentation sentence above and/or adding an illustrative code example about expected behavior.\r\n\r\n> > * The method _**requests.cookies.RequestsCookieJar.set**_ has no examples in the documentation, but there are several questions in stackoverflow regarding this method. [Here](https://stackoverflow.com/questions/75514573/where-can-i-find-python-requests-library-functions-kwargs-parameters-documente) is an example.\r\n> \r\n> Again, an example here would look like what? This isn't users should be using often if at all. So what code example would be useful?\r\n> \r\n\r\n> StackOverflow is full of people doing things they shouldn't with this library's internals. That doesn't mean we should add documentation to help them do things that 99.9% of the time they don't need to care about.\r\n\r\nI agree with you that this method might not be used that often. \r\n\r\nMy intuition was that since this is a method that appears in the API reference documentation (rather than one that only appears in the source code), then we can expect that users will end up using it -- even if they should not. However, as you said, not every method deserves an example. Thus, my goal was to prioritize which methods need code examples (or clarifications) by looking at which ones users struggle with on Stack Overflow. I would love to hear your opinion on other prioritization mechanisms that make more sense to you.\r\n\r\n\r\n"
] |
https://api.github.com/repos/psf/requests/issues/6571 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6571/labels{/name} | https://api.github.com/repos/psf/requests/issues/6571/comments | https://api.github.com/repos/psf/requests/issues/6571/events | https://github.com/psf/requests/issues/6571 | 1,988,833,240 | I_kwDOABTKOs52iy_Y | 6,571 | adding url parser | {
"avatar_url": "https://avatars.githubusercontent.com/u/20878986?v=4",
"events_url": "https://api.github.com/users/MohammadRaziei/events{/privacy}",
"followers_url": "https://api.github.com/users/MohammadRaziei/followers",
"following_url": "https://api.github.com/users/MohammadRaziei/following{/other_user}",
"gists_url": "https://api.github.com/users/MohammadRaziei/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/MohammadRaziei",
"id": 20878986,
"login": "MohammadRaziei",
"node_id": "MDQ6VXNlcjIwODc4OTg2",
"organizations_url": "https://api.github.com/users/MohammadRaziei/orgs",
"received_events_url": "https://api.github.com/users/MohammadRaziei/received_events",
"repos_url": "https://api.github.com/users/MohammadRaziei/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/MohammadRaziei/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MohammadRaziei/subscriptions",
"type": "User",
"url": "https://api.github.com/users/MohammadRaziei",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156041422,
"name": "actions/autoclose-feat",
"node_id": "LA_kwDOABTKOs8AAAABbu28zg",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-feat"
}
] | closed | true | null | [] | null | 1 | 2023-11-11T08:22:49Z | 2023-11-11T12:31:37Z | 2023-11-11T12:31:35Z | NONE | null | hi, I wrote a urlparser named liburlparser with cpp for Python (https://pypi.org/project/liburlparser/)
it can parse the URL and its host part including domain, suffix, subdomain etc. for suffix extraction it looks for it in this URL
https://publicsuffix.org/list/public_suffix_list.dat
I highly recommend that use it in your project. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6571/reactions"
} | https://api.github.com/repos/psf/requests/issues/6571/timeline | null | not_planned | null | null | false | [
"No, thank you"
] |
https://api.github.com/repos/psf/requests/issues/6570 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6570/labels{/name} | https://api.github.com/repos/psf/requests/issues/6570/comments | https://api.github.com/repos/psf/requests/issues/6570/events | https://github.com/psf/requests/pull/6570 | 1,988,368,738 | PR_kwDOABTKOs5fLmp8 | 6,570 | Document that Response.iter_lines is broken and should be avoided | {
"avatar_url": "https://avatars.githubusercontent.com/u/7748246?v=4",
"events_url": "https://api.github.com/users/bemoody/events{/privacy}",
"followers_url": "https://api.github.com/users/bemoody/followers",
"following_url": "https://api.github.com/users/bemoody/following{/other_user}",
"gists_url": "https://api.github.com/users/bemoody/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bemoody",
"id": 7748246,
"login": "bemoody",
"node_id": "MDQ6VXNlcjc3NDgyNDY=",
"organizations_url": "https://api.github.com/users/bemoody/orgs",
"received_events_url": "https://api.github.com/users/bemoody/received_events",
"repos_url": "https://api.github.com/users/bemoody/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bemoody/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bemoody/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bemoody",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2023-11-10T20:48:59Z | 2023-12-05T08:34:38Z | null | NONE | null | The `Response.iter_lines` method is seriously broken (it inserts fake blank lines in unpredictable places.)
The earliest report of this I've found is pull #2431 (January 2015).
The behavior was apparently fixed in the 3.0.0 branch, by pulls #3923 and #3984. (I think #3923 fixes the `delimiter!=None` case and #3984 fixes the `delimiter=None` case. But I haven't tested it.)
The problem was raised again in issues #3980, #4121, and #5540.
Pull #4629 attempted to partially fix the issue in the master branch, and was rejected.
Personally, I am skeptical that there is any benefit in preserving this broken behavior. But folks who know better than I do have said that it needs to be maintained.
As long as this *isn't* fixed, people using the library should be informed that method is broken and they shouldn't use it.
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6570/reactions"
} | https://api.github.com/repos/psf/requests/issues/6570/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6570.diff",
"html_url": "https://github.com/psf/requests/pull/6570",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6570.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6570"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6569 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6569/labels{/name} | https://api.github.com/repos/psf/requests/issues/6569/comments | https://api.github.com/repos/psf/requests/issues/6569/events | https://github.com/psf/requests/issues/6569 | 1,986,638,475 | I_kwDOABTKOs52abKL | 6,569 | HTTPSConnectionPool(port=443): Max retries exceeded with url:(Caused by SSLError(SSLZeroReturnError(6, 'TLS/SSL connection has been closed (EOF) (_ssl.c:1129)'))) | {
"avatar_url": "https://avatars.githubusercontent.com/u/32769732?v=4",
"events_url": "https://api.github.com/users/Hsgngr/events{/privacy}",
"followers_url": "https://api.github.com/users/Hsgngr/followers",
"following_url": "https://api.github.com/users/Hsgngr/following{/other_user}",
"gists_url": "https://api.github.com/users/Hsgngr/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Hsgngr",
"id": 32769732,
"login": "Hsgngr",
"node_id": "MDQ6VXNlcjMyNzY5NzMy",
"organizations_url": "https://api.github.com/users/Hsgngr/orgs",
"received_events_url": "https://api.github.com/users/Hsgngr/received_events",
"repos_url": "https://api.github.com/users/Hsgngr/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Hsgngr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Hsgngr/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Hsgngr",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
},
{
"color": "000000",
"default": false,
"description": "Used for automation to auto-close an issue",
"id": 6156042717,
"name": "actions/autoclose-qa",
"node_id": "LA_kwDOABTKOs8AAAABbu3B3Q",
"url": "https://api.github.com/repos/psf/requests/labels/actions/autoclose-qa"
}
] | closed | false | null | [] | null | 1 | 2023-11-10T00:44:41Z | 2023-12-21T02:51:24Z | 2023-12-21T02:51:24Z | NONE | null | I having a long lasting problem with my request connection is getting shutdown using Cloud Run. I couldnt solve it yet so here I am to get support.
Here is the full error:
```
Error occurred: HTTPSConnectionPool(host='google.serper.dev', port=443): Max retries exceeded with url: /search (Caused by SSLError(SSLZeroReturnError(6, 'TLS/SSL connection has been closed (EOF) (_ssl.c:1129)')))
```
Here is how I use request:
```
def serper_search(self, arguments):
query = arguments["q"]
url = "https://google.serper.dev/search"
payload = json.dumps({"q": query})
headers = {
'X-API-KEY': self.api_key,
'Content-Type': 'application/json'
}
try:
response = requests.request(
"POST", url, headers=headers, data=payload)
# Will raise an HTTPError if the HTTP request returned an unsuccessful status code
response.raise_for_status()
# Parse the response and make it ready
parsed_response = self.parse_response(response, number_of_results=3)
return parsed_response # Assuming the response content is in JSON format
except requests.exceptions.HTTPError as http_err:
logger.error(f"HTTP error occurred: {http_err}")
return None
except Exception as e:
logger.error(f"Error occurred: {e}")
return None
```
This only happens in Cloud Run although the error should be on those side, there must a setting to override this issue on the request side as well.
**I tried:**
- verify = False
didnt help.
**More info:**
Also I use this with fastapi and adding as a backgroundTask.
fastapi==0.103.1
requests==2.31.0
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 3,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 3,
"url": "https://api.github.com/repos/psf/requests/issues/6569/reactions"
} | https://api.github.com/repos/psf/requests/issues/6569/timeline | null | not_planned | null | null | false | [
"Saw your comment in:\r\nhttps://github.com/psf/requests/issues/6429\r\n\r\nJust wanted to remind anyone reading that Cloud Run does not allocate CPU outside request unless the revision is explicitly configured to do so; here are the docs:\r\n\r\nhttps://cloud.google.com/run/docs/configuring/cpu-allocation\r\n\r\nand here's a sample:\r\n\r\n\r\n"
] |
https://api.github.com/repos/psf/requests/issues/6568 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6568/labels{/name} | https://api.github.com/repos/psf/requests/issues/6568/comments | https://api.github.com/repos/psf/requests/issues/6568/events | https://github.com/psf/requests/pull/6568 | 1,978,580,987 | PR_kwDOABTKOs5eqIcI | 6,568 | Bug/6294 zero bytes files are chunked | {
"avatar_url": "https://avatars.githubusercontent.com/u/1540378?v=4",
"events_url": "https://api.github.com/users/eivindt/events{/privacy}",
"followers_url": "https://api.github.com/users/eivindt/followers",
"following_url": "https://api.github.com/users/eivindt/following{/other_user}",
"gists_url": "https://api.github.com/users/eivindt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/eivindt",
"id": 1540378,
"login": "eivindt",
"node_id": "MDQ6VXNlcjE1NDAzNzg=",
"organizations_url": "https://api.github.com/users/eivindt/orgs",
"received_events_url": "https://api.github.com/users/eivindt/received_events",
"repos_url": "https://api.github.com/users/eivindt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/eivindt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/eivindt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/eivindt",
"user_view_type": "public"
} | [] | open | false | null | [] | {
"closed_at": null,
"closed_issues": 0,
"created_at": "2024-05-20T14:16:54Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
},
"description": "",
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/35",
"id": 11076316,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/35/labels",
"node_id": "MI_kwDOABTKOs4AqQLc",
"number": 35,
"open_issues": 3,
"state": "open",
"title": "2.33.0",
"updated_at": "2024-05-21T12:26:27Z",
"url": "https://api.github.com/repos/psf/requests/milestones/35"
} | 4 | 2023-11-06T08:35:26Z | 2024-05-20T14:17:03Z | null | NONE | null | See bug #6294 for original bug report.
This PR provides a possible fix for this, reverting the change in #2896.
The change in #2896 definitely causes some bad side effects, since not all web servers handle "chunked" transfer encoding (i.e. some don't handle it, some don't handle it well).
### Problem demonstration
Given a simple bottle application:
```python
from bottle import run, put, request, default_app
app = default_app()
@app.put("/")
def receive_file():
upload = request.body.read()
for head, val in request.headers.items():
print("%-30s:\t%s" % (head, val))
clength = request.headers.get("Content-Length", "not-set")
cencoding = request.headers.get("Transfer-Encoding", "not-set")
return { 'size': len(upload), 'content-length': clength, 'transfer-encoding': cencoding }
if __name__ == '__main__':
app.run(host='localhost', port=8880)
```
And a simple requests script:
```python
import requests
import io
empty_obj = io.BytesIO(b'')
resp = requests.put('http://localhost:8880/', data=empty_obj)
print(resp.status_code)
if resp.status_code == 200:
print(resp.json())
```
## Working Scenario
```
$ python server.py
Bottle v0.12.25 server starting up (using WSGIRefServer())...
Listening on http://localhost:8880/
Hit Ctrl-C to quit.
Content-Length :
Content-Type : text/plain
Host : localhost:8880
User-Agent : python-requests/2.31.0
Accept-Encoding : gzip, deflate, br
Accept : */*
Connection : keep-alive
Transfer-Encoding : chunked
127.0.0.1 - - [03/Nov/2023 15:51:51] "PUT / HTTP/1.1" 200 65
```
Test script output:
```
200
{'size': 0, 'content-length': '', 'transfer-encoding': 'chunked'}
```
## Failing Scenario
```
$ gunicorn -b localhost:8880 server:app
[2023-11-03 15:52:05 +0100] [1326049] [INFO] Starting gunicorn 21.2.0
[2023-11-03 15:52:05 +0100] [1326049] [INFO] Listening at: http://127.0.0.1:8880 (1326049)
[2023-11-03 15:52:05 +0100] [1326049] [INFO] Using worker: sync
[2023-11-03 15:52:05 +0100] [1326050] [INFO] Booting worker with pid: 1326050
```
Test script output:
```
400
```
### The Original Issue
The change causing this problem in the first place was due to failing to upload data read from a subprocess pipe.
This patch adds a check to `super_len` that avoids returning length 0 for file handles that are not regular files. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6568/reactions"
} | https://api.github.com/repos/psf/requests/issues/6568/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6568.diff",
"html_url": "https://github.com/psf/requests/pull/6568",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6568.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6568"
} | true | [
"closing & reopening to trigger a new build",
"@eivindt would you be willing to fix the lint errors?",
"Give me a couple of days and I'll fix them.",
"Sorry for the delay, there were some windows specific issues I couldn't easily fix without a windows pc."
] |
https://api.github.com/repos/psf/requests/issues/6567 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6567/labels{/name} | https://api.github.com/repos/psf/requests/issues/6567/comments | https://api.github.com/repos/psf/requests/issues/6567/events | https://github.com/psf/requests/issues/6567 | 1,977,925,763 | I_kwDOABTKOs515MCD | 6,567 | Requests doesn't work on emscripten / webassembly | {
"avatar_url": "https://avatars.githubusercontent.com/u/1436795?v=4",
"events_url": "https://api.github.com/users/joemarshall/events{/privacy}",
"followers_url": "https://api.github.com/users/joemarshall/followers",
"following_url": "https://api.github.com/users/joemarshall/following{/other_user}",
"gists_url": "https://api.github.com/users/joemarshall/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/joemarshall",
"id": 1436795,
"login": "joemarshall",
"node_id": "MDQ6VXNlcjE0MzY3OTU=",
"organizations_url": "https://api.github.com/users/joemarshall/orgs",
"received_events_url": "https://api.github.com/users/joemarshall/received_events",
"repos_url": "https://api.github.com/users/joemarshall/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/joemarshall/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/joemarshall/subscriptions",
"type": "User",
"url": "https://api.github.com/users/joemarshall",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2023-11-05T19:23:45Z | 2023-12-28T02:05:14Z | 2023-12-01T00:19:34Z | NONE | null | This is maybe verging on a feature request, I'm not sure...
Webassembly with emscripten is now an official python platform. However because it runs inside a browser sandbox environment, networking doesn't work normally, and hence nothing in requests works at all. However there is easy access to http(s) requests via the environment it is running in.
Right now, we have a monkeypatch module which patches a new BaseAdapter subclass into `Session.__init__` (see link below).
https://github.com/koenvo/pyodide-http/blob/main/pyodide_http/_requests.py
It isn't masses of code, because most of the stuff that is handled by lower level things in requests is just passed directly off to the browser fetch.
It would be really nice if a version of this adapter could be added to requests (and the emscripten platform added to requests CI also, so we can see how much functionality works and how much doesn't.)
I did a bunch of work on the monkeypatch code above, so I'd be happy to help on this, but obviously I don't want to spend the time doing a PR for it if it isn't going to have a chance of being merged, hence opening this issue to discuss. | {
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6567/reactions"
} | https://api.github.com/repos/psf/requests/issues/6567/timeline | null | completed | null | null | false | [
"Hey @joemarshall, thanks for opening this issue. We actually have a very similar issue on urllib3 (the underlying library of Requests) that has a bounty available. If you wanted to contribute there then many libraries would gain the ability to use WASM Python.\n\nhttps://github.com/urllib3/urllib3/issues/2951",
"I'm going to close this one now that https://github.com/urllib3/urllib3/issues/2951 is closed, Emscripten support isn't stable yet but should be at least possible once urllib3 is released."
] |
https://api.github.com/repos/psf/requests/issues/6566 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6566/labels{/name} | https://api.github.com/repos/psf/requests/issues/6566/comments | https://api.github.com/repos/psf/requests/issues/6566/events | https://github.com/psf/requests/issues/6566 | 1,977,666,493 | I_kwDOABTKOs514Mu9 | 6,566 | Import error with werkzeug | {
"avatar_url": "https://avatars.githubusercontent.com/u/55189266?v=4",
"events_url": "https://api.github.com/users/amkarn258/events{/privacy}",
"followers_url": "https://api.github.com/users/amkarn258/followers",
"following_url": "https://api.github.com/users/amkarn258/following{/other_user}",
"gists_url": "https://api.github.com/users/amkarn258/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/amkarn258",
"id": 55189266,
"login": "amkarn258",
"node_id": "MDQ6VXNlcjU1MTg5MjY2",
"organizations_url": "https://api.github.com/users/amkarn258/orgs",
"received_events_url": "https://api.github.com/users/amkarn258/received_events",
"repos_url": "https://api.github.com/users/amkarn258/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/amkarn258/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/amkarn258/subscriptions",
"type": "User",
"url": "https://api.github.com/users/amkarn258",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2023-11-05T07:13:53Z | 2024-11-05T00:04:28Z | 2023-11-05T11:30:32Z | CONTRIBUTOR | resolved | When I run `make ci` on the main branch, it throws this import error with werkzeug
```
ImportError: cannot import name 'parse_authorization_header' from 'werkzeug.http' (/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/werkzeug/http.py)
make: *** [Makefile:8: ci] Error 1
```
## Expected Result
To run make ci successfully on the main branch.
## Actual Result
Import error with latest version of werkzeug. I tried downgrading to a 2.3.X version of werkzeug and it ran without any issue.
## Reproduction Steps
``make ci``
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6566/reactions"
} | https://api.github.com/repos/psf/requests/issues/6566/timeline | null | completed | null | null | false | [
"This is being tracked in psf/httpbin"
] |
https://api.github.com/repos/psf/requests/issues/6565 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6565/labels{/name} | https://api.github.com/repos/psf/requests/issues/6565/comments | https://api.github.com/repos/psf/requests/issues/6565/events | https://github.com/psf/requests/issues/6565 | 1,971,661,689 | I_kwDOABTKOs51hSt5 | 6,565 | CA-certs bundles and requests.certs.where - Improved documentation | {
"avatar_url": "https://avatars.githubusercontent.com/u/4488298?v=4",
"events_url": "https://api.github.com/users/velle/events{/privacy}",
"followers_url": "https://api.github.com/users/velle/followers",
"following_url": "https://api.github.com/users/velle/following{/other_user}",
"gists_url": "https://api.github.com/users/velle/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/velle",
"id": 4488298,
"login": "velle",
"node_id": "MDQ6VXNlcjQ0ODgyOTg=",
"organizations_url": "https://api.github.com/users/velle/orgs",
"received_events_url": "https://api.github.com/users/velle/received_events",
"repos_url": "https://api.github.com/users/velle/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/velle/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/velle/subscriptions",
"type": "User",
"url": "https://api.github.com/users/velle",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
}
] | open | false | null | [] | null | 1 | 2023-11-01T04:09:52Z | 2024-10-04T16:45:49Z | null | NONE | null | I initially thought `requests.certs.where` (as well as `certifi.where`) returned the location of the cacert file _actually_ being used, and I could use it to verify that the correct file was loaded. I am not the only one to make this mistake: https://stackoverflow.com/a/42982144/735070.
I have realized though, that it simply return the path of the bundled cacert file that comes included with the library.
### Demonstration of this behavior:
#test.py
import requests, certifi,os
print('os.environ.get("REQUESTS_CA_BUNDLE") -> ',repr(os.environ.get("REQUESTS_CA_BUNDLE")))
print('os.environ.get("CURL_CA_BUNDLE") -> ',repr(os.environ.get("CURL_CA_BUNDLE")))
print('requests.cert.where()) -> ',repr(requests.certs.where()))
print('certifi.where()) -> ',repr(certifi.where()))
Running test.py in shell with REQUESTS_CA_BUNDLE set:
$ REQUESTS_CA_BUNDLE=/home/jdoe/catest/my_cacert.pem python test.py
os.environ.get("REQUESTS_CA_BUNDLE") -> '/home/jdoe/catest/my_cacert.pem'
os.environ.get("CURL_CA_BUNDLE") -> None
requests.cert.where()) -> '/home/jdoe/.local/lib/python3.10/site-packages/certifi/cacert.pem'
certifi.where()) -> '/home/jdoe/.local/lib/python3.10/site-packages/certifi/cacert.pem'
### Improve documentation - requests.certs.where-function
Currently `requests.certs.where.__doc__` returns null. How about
_returns the path of the CA-certs bundle that is included with the requests package, ie not necessarily the bundle actually being used._
### Improve documentation - How is CA-bundle chosen
Maybe the simplest way of making this clear is to add a section with a list or decision tree that shows which file (if any) will be used as CA-certs bundle.
### Add some way of getting the bundle _actually_ being used
In my case a static function, `requests.cacerts_loaded()`. I realize this may return a file different from the one being used, if the user specifies `verify` (and maybe its possible to change in other ways too).
### Demonstration run on
- certifi version: 2023.05.07
- requests version: 2.25.1
- Python 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] on linux
| null | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 1,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 2,
"url": "https://api.github.com/repos/psf/requests/issues/6565/reactions"
} | https://api.github.com/repos/psf/requests/issues/6565/timeline | null | null | null | null | false | [
"I was so confused when I set REQUEST_CA_BUNDLE and the where() functions didn't change."
] |
https://api.github.com/repos/psf/requests/issues/6564 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6564/labels{/name} | https://api.github.com/repos/psf/requests/issues/6564/comments | https://api.github.com/repos/psf/requests/issues/6564/events | https://github.com/psf/requests/issues/6564 | 1,971,180,719 | I_kwDOABTKOs51fdSv | 6,564 | HTTP/2 support - For real (even HTTP/3 is a reality right now!) | {
"avatar_url": "https://avatars.githubusercontent.com/u/64521741?v=4",
"events_url": "https://api.github.com/users/rfc-st/events{/privacy}",
"followers_url": "https://api.github.com/users/rfc-st/followers",
"following_url": "https://api.github.com/users/rfc-st/following{/other_user}",
"gists_url": "https://api.github.com/users/rfc-st/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/rfc-st",
"id": 64521741,
"login": "rfc-st",
"node_id": "MDQ6VXNlcjY0NTIxNzQx",
"organizations_url": "https://api.github.com/users/rfc-st/orgs",
"received_events_url": "https://api.github.com/users/rfc-st/received_events",
"repos_url": "https://api.github.com/users/rfc-st/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/rfc-st/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rfc-st/subscriptions",
"type": "User",
"url": "https://api.github.com/users/rfc-st",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
}
] | closed | false | null | [] | null | 4 | 2023-10-31T19:38:40Z | 2024-01-30T12:32:04Z | 2023-10-31T20:15:08Z | NONE | null | Hi!,
[HTTP/2](https://en.wikipedia.org/wiki/HTTP/2) was introduced 8 years ago!.
Is there any intention to support it, its characteristics, in the **short** term?.
If not: is it for lack of time, interest, people?. Perhaps it would be interesting, in this case, to transfer this library to an organization that would have the necessary resources to update it; or, at least, to provide it with the required resources: has it been tried, is it of interest?. Anchoring in the past, I think, has never been a good idea.
If the answer is "**no**", or **"never**", I think the best option would be to abandon, and give up, this project so that others can make it even **bigger**.
Thank you (really) from someone who appreciates your work.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6564/reactions"
} | https://api.github.com/repos/psf/requests/issues/6564/timeline | null | completed | null | null | false | [
"Going to mark this as a \"answered\" by https://github.com/urllib3/urllib3/pull/3030, which has an extremely thorough description of what it would take for HTTP/2 support in urllib3, the underlying library of Requests. There is a lack of people and time, so if you have access to those things and want to solve the problem it would be much appreciated.",
"Thank you for your response. I still think that investing time in maintaining an already obsolete library is a waste of time.\r\n\r\nBut it is your time. I assure you it won't be mine :).\r\n\r\nThanks for speeding up my decision. And good luck, always.\r\n\r\nRegards,",
"> maintaining an already obsolete library is a waste of time.\r\n\r\nGiven it's the 4th most downloaded Python package globally, it must be serving _some_ purpose :) We wish you well.",
"Hi!,\r\n\r\nOf course it is, of course this library is important, of course it is (or was?) necessary ... but you are eight years late. At least you are. And that, in our young ecosystem, is too long. And living on past achievements has never ensured either the present or the future.\r\n\r\nAnd I am sorry, my apologies, if I sounded rude, but I insist on my idea: I sincerely believe that you are wasting your time. And, by extension, ours.\r\n\r\nOf course I am not able to match what you have achieved, I do not have that knowledge, but I have ideas, some absurd: that this library, today, does not even allow me to carry them out.\r\n\r\nTherefore, I repeat: Thank you, ample. For everything. And that perhaps it would be interesting to point out in your page that you have no intention to support neither the present nor the future, at least in the short term.\r\n\r\nSince we are sincere, let's be completely sincere. Don't you agree? :).\r\n\r\nRegards,"
] |
https://api.github.com/repos/psf/requests/issues/6563 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6563/labels{/name} | https://api.github.com/repos/psf/requests/issues/6563/comments | https://api.github.com/repos/psf/requests/issues/6563/events | https://github.com/psf/requests/pull/6563 | 1,969,556,179 | PR_kwDOABTKOs5eLyKN | 6,563 | Optimized 2 functions + added Doc Strings + fixed formatting issues(non-technical just prettyness issues) | {
"avatar_url": "https://avatars.githubusercontent.com/u/72662612?v=4",
"events_url": "https://api.github.com/users/HPD1155/events{/privacy}",
"followers_url": "https://api.github.com/users/HPD1155/followers",
"following_url": "https://api.github.com/users/HPD1155/following{/other_user}",
"gists_url": "https://api.github.com/users/HPD1155/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/HPD1155",
"id": 72662612,
"login": "HPD1155",
"node_id": "MDQ6VXNlcjcyNjYyNjEy",
"organizations_url": "https://api.github.com/users/HPD1155/orgs",
"received_events_url": "https://api.github.com/users/HPD1155/received_events",
"repos_url": "https://api.github.com/users/HPD1155/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/HPD1155/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HPD1155/subscriptions",
"type": "User",
"url": "https://api.github.com/users/HPD1155",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2023-10-31T03:16:26Z | 2024-10-31T00:07:28Z | 2023-10-31T10:41:03Z | NONE | resolved | Optimized the following functions
- `help._implementation()` - Made it faster, doesn't really make an effect but nice to have. `Confirmed to still work on my system`
- `utils.urldefragauth(url)` - removes the fragment and authentication parts from a URL in a more concise and efficient manner by directly modifying the `netloc` variable and avoiding unnecessary assignments. `Confimed to still work on my system`
Added or modified doc strings:
- `exceptions.JSONDecodeError()` - Capitalized json -> JSON so it matches the rest of the code in that file.
- `status_codes.py` - Modified some of the formatting for the code, so they all match. (No random lines of code that use multiline args )
- Added a few doc strings to functions in `utils.py`
- Added a doc string to `test_lowlevel.test_json_decode_compatibility_for_alt_utf_encodings() | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6563/reactions"
} | https://api.github.com/repos/psf/requests/issues/6563/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6563.diff",
"html_url": "https://github.com/psf/requests/pull/6563",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6563.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6563"
} | true | [
"Thanks for the contribution. Unfortunately we don't accept cleaned charges and changing the names of exception classes is a backwards incompatible change we will not accept. Finally the formatting changes you made conflict with black which we use to format the entire codebase"
] |
https://api.github.com/repos/psf/requests/issues/6562 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6562/labels{/name} | https://api.github.com/repos/psf/requests/issues/6562/comments | https://api.github.com/repos/psf/requests/issues/6562/events | https://github.com/psf/requests/pull/6562 | 1,969,062,442 | PR_kwDOABTKOs5eKGgx | 6,562 | every chardet package maps to requests.packages.chardet.* package respectively | {
"avatar_url": "https://avatars.githubusercontent.com/u/55189266?v=4",
"events_url": "https://api.github.com/users/amkarn258/events{/privacy}",
"followers_url": "https://api.github.com/users/amkarn258/followers",
"following_url": "https://api.github.com/users/amkarn258/following{/other_user}",
"gists_url": "https://api.github.com/users/amkarn258/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/amkarn258",
"id": 55189266,
"login": "amkarn258",
"node_id": "MDQ6VXNlcjU1MTg5MjY2",
"organizations_url": "https://api.github.com/users/amkarn258/orgs",
"received_events_url": "https://api.github.com/users/amkarn258/received_events",
"repos_url": "https://api.github.com/users/amkarn258/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/amkarn258/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/amkarn258/subscriptions",
"type": "User",
"url": "https://api.github.com/users/amkarn258",
"user_view_type": "public"
} | [] | closed | false | null | [] | {
"closed_at": null,
"closed_issues": 13,
"created_at": "2023-08-13T17:04:53Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
},
"description": "",
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/33",
"id": 9786066,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/33/labels",
"node_id": "MI_kwDOABTKOs4AlVLS",
"number": 33,
"open_issues": 0,
"state": "open",
"title": "2.32.0",
"updated_at": "2024-05-20T14:17:03Z",
"url": "https://api.github.com/repos/psf/requests/milestones/33"
} | 4 | 2023-10-30T19:23:56Z | 2024-02-23T12:26:38Z | 2024-02-23T12:26:38Z | CONTRIBUTOR | null | Added a fix for the issue mentioned here - https://github.com/psf/requests/issues/6223
Checked in the code, only one package of chardet was being mapped to requests.packages.chardet despite the for loop.
Have added the fix so each chardet package maps to it's corresponding requests.packages.chardet.* respectively. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6562/reactions"
} | https://api.github.com/repos/psf/requests/issues/6562/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6562.diff",
"html_url": "https://github.com/psf/requests/pull/6562",
"merged_at": "2024-02-23T12:26:38Z",
"patch_url": "https://github.com/psf/requests/pull/6562.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6562"
} | true | [
"Your PR as is will _still_ have the same issue you reported and does not fix it. I've added a suggestion",
"Same checks are failing on the main branch - https://github.com/psf/requests/issues/6566\r\n\r\nI think the issue is with werkzeug latest version which gets downloaded due to dependency with `httpbin`",
"Is there anything more required in this PR to be merged? Or is it on standby until the httpbin issue gets resolved @sigmavirus24 ",
"closing & reopening to trigger new build"
] |
https://api.github.com/repos/psf/requests/issues/6561 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6561/labels{/name} | https://api.github.com/repos/psf/requests/issues/6561/comments | https://api.github.com/repos/psf/requests/issues/6561/events | https://github.com/psf/requests/pull/6561 | 1,966,661,607 | PR_kwDOABTKOs5eCEdk | 6,561 | url param gets added when empty param is passed | {
"avatar_url": "https://avatars.githubusercontent.com/u/55189266?v=4",
"events_url": "https://api.github.com/users/amkarn258/events{/privacy}",
"followers_url": "https://api.github.com/users/amkarn258/followers",
"following_url": "https://api.github.com/users/amkarn258/following{/other_user}",
"gists_url": "https://api.github.com/users/amkarn258/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/amkarn258",
"id": 55189266,
"login": "amkarn258",
"node_id": "MDQ6VXNlcjU1MTg5MjY2",
"organizations_url": "https://api.github.com/users/amkarn258/orgs",
"received_events_url": "https://api.github.com/users/amkarn258/received_events",
"repos_url": "https://api.github.com/users/amkarn258/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/amkarn258/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/amkarn258/subscriptions",
"type": "User",
"url": "https://api.github.com/users/amkarn258",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 0 | 2023-10-28T16:41:07Z | 2023-12-05T08:36:07Z | null | CONTRIBUTOR | null | Have added the fix for the issue mentioned here - https://github.com/psf/requests/issues/6557
Since empty lists, dicts, tuples aren't of none type they should be added in the url string. | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6561/reactions"
} | https://api.github.com/repos/psf/requests/issues/6561/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6561.diff",
"html_url": "https://github.com/psf/requests/pull/6561",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6561.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6561"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6560 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6560/labels{/name} | https://api.github.com/repos/psf/requests/issues/6560/comments | https://api.github.com/repos/psf/requests/issues/6560/events | https://github.com/psf/requests/issues/6560 | 1,964,775,557 | I_kwDOABTKOs51HBiF | 6,560 | Unsuccessful TLS handshake when using `requests` in multiple threads on Ubuntu Jammy | {
"avatar_url": "https://avatars.githubusercontent.com/u/437360?v=4",
"events_url": "https://api.github.com/users/ohaibbq/events{/privacy}",
"followers_url": "https://api.github.com/users/ohaibbq/followers",
"following_url": "https://api.github.com/users/ohaibbq/following{/other_user}",
"gists_url": "https://api.github.com/users/ohaibbq/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ohaibbq",
"id": 437360,
"login": "ohaibbq",
"node_id": "MDQ6VXNlcjQzNzM2MA==",
"organizations_url": "https://api.github.com/users/ohaibbq/orgs",
"received_events_url": "https://api.github.com/users/ohaibbq/received_events",
"repos_url": "https://api.github.com/users/ohaibbq/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ohaibbq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ohaibbq/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ohaibbq",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2023-10-27T05:06:49Z | 2024-10-28T00:04:33Z | 2023-10-27T23:30:48Z | NONE | resolved | This is a bit deeper into the SSL/TLS stack than I've been before, so apologies if I'm off on anything here.
When issuing requests across multiple threads, `requests` does not successfully negotiate TLS versions. When issuing requests in a single thread, connections are opened and successfully negotiate TLSv1.3.
When utilizing retries, the connections do eventually negotiate TLSv1.3 and succeed, but all connections are initially opened with TLSv1.
## Expected Result
Handshake completes successfully, TLS v1.3 is selected for further communication and an unexpected EOFError is not raised.
```
requests.exceptions.SSLError: HTTPSConnectionPool(host='google.com', port=443): Max retries exceeded with url: / (Caused by SSLError(SSLEOFError(8, '[SSL: UNEXPECTED_EOF_WHILE_READING] EOF occurred in violation of protocol (_ssl.c:1007)')))
```
## Actual Result
Handshake fails to complete.
`Alert (Level: Fatal, Description: Decode Error)`
## Reproduction steps
[I've attached `tcpdump` captures and TLS log (`(Pre)-Master-Secret log`) files for each of the provided test cases.](https://github.com/psf/requests/files/13185052/tcpdump.zip)
Additionally, here are screenshots of the Wireshark sessions, notice that the multi-threaded tcpdump cannot complete the TLS handshake successfully.
### `requests` single-threaded tcpdump
<img width="1195" alt="Screenshot 2023-10-26 at 10 02 11 PM" src="https://github.com/psf/requests/assets/437360/9e995fd0-f69e-4866-860e-337821c0044b">
### `requests` multi-threaded tcpdump
<img width="1271" alt="Screenshot 2023-10-26 at 10 01 52 PM" src="https://github.com/psf/requests/assets/437360/55c6fdcf-559f-4d88-8d9d-47f917d70aff">
### `urllib3` tcpdump
<img width="1266" alt="Screenshot 2023-10-26 at 10 02 24 PM" src="https://github.com/psf/requests/assets/437360/e492d76f-935d-46a1-afad-49caae421d45">
---
```dockerfile
# Dockerfile
FROM ubuntu:jammy
RUN apt update -y && \
apt install -y \
python3.10-dev python3.10-distutils python3-pip
RUN pip install requests
```
```python
# main.py
import logging
import os
import sys
import warnings
from concurrent import futures
import requests
import urllib3.poolmanager
WORKER_COUNT = 128
def test_requests():
session = requests.Session()
for i in range(48):
session.get('https://google.com')
def test_requests_threaded():
executor = futures.ThreadPoolExecutor(max_workers=WORKER_COUNT)
def get():
session = requests.Session()
return session.get('https://google.com')
return [
future.result()
for future in futures.as_completed([executor.submit(get) for i in range(48)])
]
def test_urllib3_threaded():
executor = futures.ThreadPoolExecutor(max_workers=WORKER_COUNT)
connection_manager = urllib3.poolmanager.PoolManager(num_pools=WORKER_COUNT, maxsize=WORKER_COUNT)
def get(connection_manager):
return connection_manager.request('GET', 'https://google.com')
return [
future.result()
for future in futures.as_completed([executor.submit(get, connection_manager) for i in range(48)])
]
tests = {
"test_requests": test_requests,
"test_requests_threaded": test_requests_threaded,
"test_urllib3_threaded": test_urllib3_threaded,
}
if __name__ == "__main__":
os.environ["SSLKEYLOGFILE"] = "/app/tls.log"
# Enable all logging and warnings
warnings.simplefilter("always")
logging.basicConfig(level=logging.DEBUG)
loggers = [logging.getLogger(name) for name in logging.root.manager.loggerDict]
for logger in loggers:
logger.setLevel(logging.DEBUG)
try:
tests[sys.argv[1]]()
finally:
with open(os.environ["SSLKEYLOGFILE"], "r", encoding="utf-8") as file:
print(file.read())
```
```bash
docker build . -t requests-tls-repro
docker run --entrypoint=bash -v .:/app/ -it requests-tls-repro
$ cd /app/
$ python3 main.py test_requests
$ python3 main.py test_requests_threaded
$ python3 main.py test_urllib3_threaded
```
## System Information
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.1"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "CPython",
"version": "3.10.12"
},
"platform": {
"release": "5.15.49-linuxkit-pr",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "30000020"
},
"urllib3": {
"version": "2.0.7"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6560/reactions"
} | https://api.github.com/repos/psf/requests/issues/6560/timeline | null | completed | null | null | false | [
"The low-level sockets API always successfully negotiates to TLS v1.3, too.\r\n```python\r\ndef test_sockets():\r\n executor = futures.ThreadPoolExecutor(max_workers=WORKER_COUNT)\r\n def get():\r\n ctx = ssl.SSLContext(\r\n protocol=ssl.PROTOCOL_TLS_CLIENT,\r\n )\r\n ctx.load_default_certs()\r\n\r\n s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)\r\n s.connect(('www.google.com', 443))\r\n s = ctx.wrap_socket(s, server_hostname='google.com')\r\n s.sendall(b\"GET / HTTP/1.1\\r\\nHost: google.com\\r\\nConnection: close\\r\\n\\r\\n\")\r\n\r\n while True:\r\n new = s.recv(4096)\r\n if not new:\r\n s.close()\r\n break\r\n print(new)\r\n\r\n return [\r\n future.result()\r\n for future in futures.as_completed([executor.submit(get) for i in range(48)])\r\n ]\r\n```",
"Does this also happen with https://pypi.org/project/requests-futures/?",
"Thanks for the response @sigmavirus24! I see the same issue with `requests-futures`.\r\n```python\r\n\r\ndef test_requests_futures_threaded():\r\n executor = futures.ThreadPoolExecutor(max_workers=WORKER_COUNT)\r\n\r\n session = FuturesSession(executor=executor)\r\n request_futures = [session.get('https://google.com') for i in range(48)]\r\n\r\n return [\r\n future.result()\r\n\r\n for future in futures.as_completed(request_futures)\r\n ]\r\n```\r\n\r\n<img width=\"1090\" alt=\"Screenshot 2023-10-27 at 9 49 50 AM\" src=\"https://github.com/psf/requests/assets/437360/732d5f1f-ce3d-439c-a73c-fd5d4058f0a8\">\r\n\r\n---\r\n\r\nI've tried setting custom `SSLContext` options by subclassing `HTTPAdapter` and modifying the `PoolManager`, but that seems to have had no effect.",
"This reproduces in Jammy across Python 3.9, 3.10, 3.11, and 3.12.\r\nI can get the correct behavior by installing OpenSSL v3.0.7 from source.\r\n\r\n```dockerfile\r\nFROM ubuntu:jammy\r\nENV DEBIAN_FRONTEND noninteractive\r\n\r\n\r\nRUN apt update -y && \\\r\n apt install -y software-properties-common wget && \\\r\n add-apt-repository ppa:deadsnakes/ppa\r\nRUN apt-get install -y build-essential cmake zlib1g-dev libcppunit-dev git subversion\r\nRUN wget http://www.openssl.org/source/openssl-3.0.7.tar.gz\r\nRUN tar -xzvf openssl-3.0.7.tar.gz\r\nRUN cd openssl-3.0.7 && ./config --prefix=/usr/local/openssl --openssldir=/usr/local/openssl && make && make install\r\nENV LDFLAGS=\"-L/usr/local/openssl/lib/ -L/usr/local/openssl/lib64/\"\r\nENV LD_LIBRARY_PATH=\"/usr/local/openssl/lib/:/usr/local/openssl/lib64/\"\r\nENV CPPFLAGS=\"-I/usr/local/openssl/include -I/usr/local/openssl/include/openssl\"\r\n# Add a package repo to get archived python versions.\r\nRUN apt install -y software-properties-common python3.11-dev python3.11-distutils python3-pip vim\r\n\r\n\r\nRUN pip install requests requests-futures\r\n```\r\n\r\n",
"Ubuntu Lunar Lobster uses OpenSSL v3.0.8 and does not reproduce the issue. \r\n\r\nI've bisected the issue to be fixed by OpenSSL v3.0.4.\r\n\r\nThis is probably safe to close, but will await a response before doing so.",
"I'm intrigued but there's nothing for us to do because python itself binds to OpenSSL for us and we don't control that layer. Genuinely not sure why this wouldn't reproduce with urllib3 directly but again, I can't think of what we could be doing differently except using a different cert bundle (maybe).",
"I should also say this was a truly excellent report. Thank you for the details and the investigation you did. Hopefully it helps someone else",
"Thanks. There were a number of memory-related fixes [between OpenSSL v3.0.3 and v3.0.4](https://github.com/openssl/openssl/compare/openssl-3.0.3...openssl-3.0.4) which may play into why this behavior is exhibited when using threading.\r\n\r\nFor now our fix will be to use Ubuntu > 23.04."
] |
https://api.github.com/repos/psf/requests/issues/6559 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6559/labels{/name} | https://api.github.com/repos/psf/requests/issues/6559/comments | https://api.github.com/repos/psf/requests/issues/6559/events | https://github.com/psf/requests/issues/6559 | 1,964,097,924 | I_kwDOABTKOs51EcGE | 6,559 | Include NOTICE file in distribution | {
"avatar_url": "https://avatars.githubusercontent.com/u/388671?v=4",
"events_url": "https://api.github.com/users/stevecj/events{/privacy}",
"followers_url": "https://api.github.com/users/stevecj/followers",
"following_url": "https://api.github.com/users/stevecj/following{/other_user}",
"gists_url": "https://api.github.com/users/stevecj/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/stevecj",
"id": 388671,
"login": "stevecj",
"node_id": "MDQ6VXNlcjM4ODY3MQ==",
"organizations_url": "https://api.github.com/users/stevecj/orgs",
"received_events_url": "https://api.github.com/users/stevecj/received_events",
"repos_url": "https://api.github.com/users/stevecj/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/stevecj/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stevecj/subscriptions",
"type": "User",
"url": "https://api.github.com/users/stevecj",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
}
] | closed | true | null | [] | null | 2 | 2023-10-26T18:15:17Z | 2024-05-06T21:31:27Z | 2023-10-31T22:05:46Z | NONE | null | Since the Apache license requires inclusion of the copyright notice, it would be really helpful to have the NOTICE file included in the distribution along with the LICENSE file so it can be collected from there by scripts instead of having to retrieve it separately from the source repository. | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6559/reactions"
} | https://api.github.com/repos/psf/requests/issues/6559/timeline | null | completed | null | null | false | [
"Hi @stevecj, the NOTICE file is currently available in the source distribution on PyPI and the published release assets on GitHub:\r\n* [PyPI .tar.gz](https://files.pythonhosted.org/packages/9d/be/10918a2eac4ae9f02f6cfe6414b7a155ccd8f7f9d4380d62fd5b955065c3/requests-2.31.0.tar.gz)\r\n* [GitHub release .tar.gz](https://github.com/psf/requests/archive/refs/tags/v2.31.0.tar.gz)\r\n\r\n\r\nBoth of these should be straight forward to automate, could you clarify where you're expecting to see it?",
"Resolving since we haven't heard back."
] |
https://api.github.com/repos/psf/requests/issues/6558 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6558/labels{/name} | https://api.github.com/repos/psf/requests/issues/6558/comments | https://api.github.com/repos/psf/requests/issues/6558/events | https://github.com/psf/requests/pull/6558 | 1,962,960,538 | PR_kwDOABTKOs5d1hPE | 6,558 | Update index.rst | {
"avatar_url": "https://avatars.githubusercontent.com/u/146543944?v=4",
"events_url": "https://api.github.com/users/DirtyD240/events{/privacy}",
"followers_url": "https://api.github.com/users/DirtyD240/followers",
"following_url": "https://api.github.com/users/DirtyD240/following{/other_user}",
"gists_url": "https://api.github.com/users/DirtyD240/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/DirtyD240",
"id": 146543944,
"login": "DirtyD240",
"node_id": "U_kgDOCLwVSA",
"organizations_url": "https://api.github.com/users/DirtyD240/orgs",
"received_events_url": "https://api.github.com/users/DirtyD240/received_events",
"repos_url": "https://api.github.com/users/DirtyD240/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/DirtyD240/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/DirtyD240/subscriptions",
"type": "User",
"url": "https://api.github.com/users/DirtyD240",
"user_view_type": "public"
} | [
{
"color": "d16014",
"default": false,
"description": "",
"id": 2392364523,
"name": "spam",
"node_id": "MDU6TGFiZWwyMzkyMzY0NTIz",
"url": "https://api.github.com/repos/psf/requests/labels/spam"
}
] | closed | true | null | [] | null | 0 | 2023-10-26T08:13:18Z | 2024-10-28T00:04:35Z | 2023-10-26T13:19:40Z | NONE | resolved | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6558/reactions"
} | https://api.github.com/repos/psf/requests/issues/6558/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6558.diff",
"html_url": "https://github.com/psf/requests/pull/6558",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6558.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6558"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6557 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6557/labels{/name} | https://api.github.com/repos/psf/requests/issues/6557/comments | https://api.github.com/repos/psf/requests/issues/6557/events | https://github.com/psf/requests/issues/6557 | 1,960,808,790 | I_kwDOABTKOs5035FW | 6,557 | URL parameter is added when the value is an empty string but not when it is an empty list | {
"avatar_url": "https://avatars.githubusercontent.com/u/38792700?v=4",
"events_url": "https://api.github.com/users/Lalee10/events{/privacy}",
"followers_url": "https://api.github.com/users/Lalee10/followers",
"following_url": "https://api.github.com/users/Lalee10/following{/other_user}",
"gists_url": "https://api.github.com/users/Lalee10/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lalee10",
"id": 38792700,
"login": "Lalee10",
"node_id": "MDQ6VXNlcjM4NzkyNzAw",
"organizations_url": "https://api.github.com/users/Lalee10/orgs",
"received_events_url": "https://api.github.com/users/Lalee10/received_events",
"repos_url": "https://api.github.com/users/Lalee10/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lalee10/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lalee10/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lalee10",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 2 | 2023-10-25T08:11:38Z | 2023-11-16T11:25:04Z | null | NONE | null | <!-- Summary. -->
Both an empty string `''` and an empty list `[]` are not of NoneType and are considered a falsy value and therefore should behave the same when being added as a URL parameter. But in requests when passing an empty string `''` as a parameter value the final URL contains the parameter but not when an empty list `[]` is passed as the value.
## Expected Result
When passing an empty list as parameter value, the final URL **should contain** the parameter.
<!-- What you expected. -->
## Actual Result
When passing an empty list as parameter value, the final URL **does not contain** the parameter.
<!-- What happened instead. -->
## Reproduction Steps
```python
import requests
base_url = 'https://jsonplaceholder.typicode.com/todos'
params = {'_limit': 5, 'id__in': ''}
response = requests.get(base_url, params)
print(response.request.url)
# Output: https://jsonplaceholder.typicode.com/todos?_limit=5&id__in=
params = {'_limit': 5, 'id__in': []}
response = requests.get(base_url, params)
print(response.request.url)
# Output: https://jsonplaceholder.typicode.com/todos?_limit=5
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.1.0"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "CPython",
"version": "3.10.11"
},
"platform": {
"release": "22.6.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.28.2"
},
"system_ssl": {
"version": "1010115f"
},
"urllib3": {
"version": "1.26.15"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| null | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/6557/reactions"
} | https://api.github.com/repos/psf/requests/issues/6557/timeline | null | null | null | null | false | [
"Yes as observed this is the case when using any other empty datatype, except a **str()**, as it gives an empty string.\r\n\r\nFrom Documentation:\r\n*\\\" Note that any dictionary key whose value is None will not be added to the URL’s query string. \\\"* \r\n\r\nBut as known, an empty list is not of None type, so i guess since it does not know what to do with empty datatypes it just treats then as None.",
"Proposed a fix here - https://github.com/psf/requests/pull/6561"
] |
https://api.github.com/repos/psf/requests/issues/6556 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6556/labels{/name} | https://api.github.com/repos/psf/requests/issues/6556/comments | https://api.github.com/repos/psf/requests/issues/6556/events | https://github.com/psf/requests/issues/6556 | 1,956,576,747 | I_kwDOABTKOs50nv3r | 6,556 | Certificates are printed to stdout when running requests.get | {
"avatar_url": "https://avatars.githubusercontent.com/u/8197659?v=4",
"events_url": "https://api.github.com/users/alexiswl/events{/privacy}",
"followers_url": "https://api.github.com/users/alexiswl/followers",
"following_url": "https://api.github.com/users/alexiswl/following{/other_user}",
"gists_url": "https://api.github.com/users/alexiswl/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alexiswl",
"id": 8197659,
"login": "alexiswl",
"node_id": "MDQ6VXNlcjgxOTc2NTk=",
"organizations_url": "https://api.github.com/users/alexiswl/orgs",
"received_events_url": "https://api.github.com/users/alexiswl/received_events",
"repos_url": "https://api.github.com/users/alexiswl/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alexiswl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alexiswl/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alexiswl",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 3 | 2023-10-23T07:58:43Z | 2024-01-08T08:11:57Z | 2023-10-23T22:59:05Z | NONE | null | <!-- Summary. -->
## Expected Result
<!-- What you expected. -->
Any warnings not to be printed to stdout, (stderr instead)
## Actual Result
Certificate line is printed to stdout
<!-- What happened instead. -->
## Reproduction Steps
```python
import requests
a = requests.get("https://github.com")
b = requests.get("https://github.com", verify=False)
```
Returns
```
/home/cwl_ica_user/.icav2-cli-plugins/pyenv/lib/pypy3.9/site-packages/certifi/cacert.pem None
/etc/ssl/certs/ca-certificates.crt /etc/ssl/certs
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.3.1"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "PyPy",
"version": "7.3.13"
},
"platform": {
"release": "6.2.0-35-generic",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "30100030"
},
"urllib3": {
"version": "1.26.18"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/8197659?v=4",
"events_url": "https://api.github.com/users/alexiswl/events{/privacy}",
"followers_url": "https://api.github.com/users/alexiswl/followers",
"following_url": "https://api.github.com/users/alexiswl/following{/other_user}",
"gists_url": "https://api.github.com/users/alexiswl/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alexiswl",
"id": 8197659,
"login": "alexiswl",
"node_id": "MDQ6VXNlcjgxOTc2NTk=",
"organizations_url": "https://api.github.com/users/alexiswl/orgs",
"received_events_url": "https://api.github.com/users/alexiswl/received_events",
"repos_url": "https://api.github.com/users/alexiswl/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alexiswl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alexiswl/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alexiswl",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6556/reactions"
} | https://api.github.com/repos/psf/requests/issues/6556/timeline | null | completed | null | null | false | [
"I can't reproduce this. Something is clearly missing from your reproduction steps",
"Hmm, seems to be an issue with Python 3.9.18 when packaged by conda-forge (not an issue when using 3.9.17). My clipboard from terminal also appears to be broken so I cannot currently share my outputs. \r\n\r\nI don't believe this is a requests library issue, but something underneath. \r\n\r\nClosing for now. \r\n\r\n",
"@sigmavirus24 I have found the offending code - nothing to do with the requests library - but from https://github.com/pypy/pypy/issues/4009. Credit to @elliotwutingfeng for the link"
] |
https://api.github.com/repos/psf/requests/issues/6555 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6555/labels{/name} | https://api.github.com/repos/psf/requests/issues/6555/comments | https://api.github.com/repos/psf/requests/issues/6555/events | https://github.com/psf/requests/pull/6555 | 1,955,613,935 | PR_kwDOABTKOs5dc3yz | 6,555 | Do not overwrite the Authorization header | {
"avatar_url": "https://avatars.githubusercontent.com/u/4950179?v=4",
"events_url": "https://api.github.com/users/hellosputnik/events{/privacy}",
"followers_url": "https://api.github.com/users/hellosputnik/followers",
"following_url": "https://api.github.com/users/hellosputnik/following{/other_user}",
"gists_url": "https://api.github.com/users/hellosputnik/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hellosputnik",
"id": 4950179,
"login": "hellosputnik",
"node_id": "MDQ6VXNlcjQ5NTAxNzk=",
"organizations_url": "https://api.github.com/users/hellosputnik/orgs",
"received_events_url": "https://api.github.com/users/hellosputnik/received_events",
"repos_url": "https://api.github.com/users/hellosputnik/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hellosputnik/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hellosputnik/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hellosputnik",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2023-10-21T18:24:30Z | 2024-10-22T00:08:27Z | 2023-10-22T19:54:29Z | NONE | resolved | ## Summary
If the Authorization header has been explicitly set by the user, `requests` should not try to overwrite the header with credentials in `.netrc`.
Anecdotally, I was confused for a solid half hour, wondering why any token I passed yielded the same user before I made an unauthenticated call, dumped headers, and suspected `.netrc`.
See [principle of least surprise](https://en.wikipedia.org/wiki/Principle_of_least_astonishment).
## Changes
- Updated the authentication conditional in `prepare_request` to check whether the Authorization header (case-insensitive per [RFC9110#5.1](https://datatracker.ietf.org/doc/html/rfc9110#section-5.1)) is set.
- [Bonus] Added a period at the end of the sentence in a nearby comment.
## Related Issues
- Closes https://github.com/psf/requests/issues/3929 | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6555/reactions"
} | https://api.github.com/repos/psf/requests/issues/6555/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6555.diff",
"html_url": "https://github.com/psf/requests/pull/6555",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6555.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6555"
} | true | [
"If you're specifying headers yourself manually, you should always set trust_env to False for those requests (assuming you want to trust it otherwise). We already have mechanisms to avoid this but certain headers we document our right to muck with, and Authorization is one of them. We will outright remove it in certain circumstances which are also documented. ",
"One should only use `trust_env` for its intended purpose. To set `trust_env` to `False` as a means of avoiding overriding user-set Authorization will introduce unintended consequences as `trust_env` controls more than just headers. \r\n\r\nConsider the following excerpt from `merge_environment_settings(...)` in `sessions.py`.\r\n\r\n```python\r\n# Gather clues from the surrounding environment.\r\nif self.trust_env:\r\n # Set environment's proxies.\r\n no_proxy = proxies.get(\"no_proxy\") if proxies is not None else None\r\n env_proxies = get_environ_proxies(url, no_proxy=no_proxy)\r\n for k, v in env_proxies.items():\r\n proxies.setdefault(k, v)\r\n\r\n # Look for requests environment configuration\r\n # and be compatible with cURL.\r\n if verify is True or verify is None:\r\n verify = (\r\n os.environ.get(\"REQUESTS_CA_BUNDLE\")\r\n or os.environ.get(\"CURL_CA_BUNDLE\")\r\n or verify\r\n )\r\n```\r\n\r\nIt is not uncommon for the user to set the Authorization header _and_ use proxy and/or certificate settings from the user's environment. This workaround may be acceptable in some cases and will work for some users, but I would not agree that it is an excellent design choice.\r\n\r\nAs for circumstances in which the Authorization header is mucked around by the module, I do see the Authorization header is sometimes stripped when resolving redirects to avoid leaking credentials and I agree that this is very useful. The proposed changes will not inhibit this security measure.",
"I know full well what other settings trust_env controls. Our advice has consistently been to disable that to disable netrc being picked up.\n\nAs I said, the way to achieve what you want today is to write an auth adapter to provide the value you want as the header if you're unwilling to accept best current practices for specifying that header directly.\n\nOur reservation of the right to always mess with certain headers isn't conditional. The are many behaviours that are affected by the environment in ways we don't think are optimal anymore but we have a strict backwards compatibility policy which this change and others like it violate ",
"I find it strange to advise on the basis of \"this is what we always tell people\" instead of collaborating with the community in an effort to introduce improvements that benefit all users. I thought that was the entire point of open source.\r\n\r\nIn any case, you're the maintainer, you have final say, and you've closed the PR. The point is taken. Thanks anyways!",
"> I know full well what other settings trust_env controls. Our advice has consistently been to disable that to disable netrc being picked up.\r\n> \r\n> As I said, the way to achieve what you want today is to write an auth adapter to provide the value you want as the header if you're unwilling to accept best current practices for specifying that header directly.\r\n> \r\n> Our reservation of the right to always mess with certain headers isn't conditional. The are many behaviours that are affected by the environment in ways we don't think are optimal anymore but we have a strict backwards compatibility policy which this change and others like it violate\r\n\r\nIf \"strict backwards compatibility\" means not fixing behavior the community deems broken, perhaps your policy is broken."
] |
https://api.github.com/repos/psf/requests/issues/6554 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6554/labels{/name} | https://api.github.com/repos/psf/requests/issues/6554/comments | https://api.github.com/repos/psf/requests/issues/6554/events | https://github.com/psf/requests/issues/6554 | 1,950,391,072 | I_kwDOABTKOs50QJsg | 6,554 | xcfxcfxcfxcf | {
"avatar_url": "https://avatars.githubusercontent.com/u/137421089?v=4",
"events_url": "https://api.github.com/users/Parvezkhan0/events{/privacy}",
"followers_url": "https://api.github.com/users/Parvezkhan0/followers",
"following_url": "https://api.github.com/users/Parvezkhan0/following{/other_user}",
"gists_url": "https://api.github.com/users/Parvezkhan0/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Parvezkhan0",
"id": 137421089,
"login": "Parvezkhan0",
"node_id": "U_kgDOCDDhIQ",
"organizations_url": "https://api.github.com/users/Parvezkhan0/orgs",
"received_events_url": "https://api.github.com/users/Parvezkhan0/received_events",
"repos_url": "https://api.github.com/users/Parvezkhan0/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Parvezkhan0/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Parvezkhan0/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Parvezkhan0",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
}
] | closed | true | null | [] | null | 0 | 2023-10-18T18:31:59Z | 2024-10-18T00:04:15Z | 2023-10-18T18:32:04Z | NONE | resolved | Please refer to our [Stack Overflow tag](https://stackoverflow.com/questions/tagged/python-requests) for guidance.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/137421089?v=4",
"events_url": "https://api.github.com/users/Parvezkhan0/events{/privacy}",
"followers_url": "https://api.github.com/users/Parvezkhan0/followers",
"following_url": "https://api.github.com/users/Parvezkhan0/following{/other_user}",
"gists_url": "https://api.github.com/users/Parvezkhan0/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Parvezkhan0",
"id": 137421089,
"login": "Parvezkhan0",
"node_id": "U_kgDOCDDhIQ",
"organizations_url": "https://api.github.com/users/Parvezkhan0/orgs",
"received_events_url": "https://api.github.com/users/Parvezkhan0/received_events",
"repos_url": "https://api.github.com/users/Parvezkhan0/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Parvezkhan0/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Parvezkhan0/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Parvezkhan0",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6554/reactions"
} | https://api.github.com/repos/psf/requests/issues/6554/timeline | null | completed | null | null | false | [] |
https://api.github.com/repos/psf/requests/issues/6553 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6553/labels{/name} | https://api.github.com/repos/psf/requests/issues/6553/comments | https://api.github.com/repos/psf/requests/issues/6553/events | https://github.com/psf/requests/pull/6553 | 1,949,696,623 | PR_kwDOABTKOs5dI45y | 6,553 | docs(socks): same block as other sections | {
"avatar_url": "https://avatars.githubusercontent.com/u/28842337?v=4",
"events_url": "https://api.github.com/users/magsen/events{/privacy}",
"followers_url": "https://api.github.com/users/magsen/followers",
"following_url": "https://api.github.com/users/magsen/following{/other_user}",
"gists_url": "https://api.github.com/users/magsen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/magsen",
"id": 28842337,
"login": "magsen",
"node_id": "MDQ6VXNlcjI4ODQyMzM3",
"organizations_url": "https://api.github.com/users/magsen/orgs",
"received_events_url": "https://api.github.com/users/magsen/received_events",
"repos_url": "https://api.github.com/users/magsen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/magsen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/magsen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/magsen",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 6 | 2023-10-18T13:00:02Z | 2023-10-18T19:07:48Z | null | NONE | null | strange formatting:
https://docs.python-requests.org/en/latest/user/advanced/#socks | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6553/reactions"
} | https://api.github.com/repos/psf/requests/issues/6553/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6553.diff",
"html_url": "https://github.com/psf/requests/pull/6553",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6553.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6553"
} | true | [
"The current formatting looks correct to me. What looks wrong to you? ",
"i have some kind of strange underscore\r\n\r\n\r\n\r\nIn a private firefox without dark theme\r\n\r\n\r\n\r\n***\r\n\r\nhttps://github.com/psf/requests/blob/main/docs/user/advanced.rst\r\n\r\nIn the rst preview you can see that this bash code block is not the same as the other bash code bloc\r\n",
"I cannot replicate that on Firefox on macOS or Linux",
"I cannot replicate that on Firefox on macOS or Linux.\n\nI would be willing to entertain a PR, however that adds sphinx-prompt to our docs dependencies and switches this to using `.. prompt::` instead because that's more correct ",
"I am actually able to replicate this on macOS in Firefox 115.3.1esr (64-bit). It appears whitespace in these blocks are being replaced with `span` tags with the `w` CSS class from pygments. This adds a faint white (#f8f8f8) underline to each whitespace.\r\n\r\n<img width=\"327\" alt=\"Screenshot 2023-10-18 at 12 26 22 PM\" src=\"https://github.com/psf/requests/assets/5271761/249056bc-c256-4784-8d51-0128b9eca4e2\">\r\n\r\nI don't however immediately see why this is being added specifically for the bash codeblock. I'm fine moving to the simplified syntax (`::`) (or `.. prompt::` as Ian noted) in this case since the bash formatting doesn't materially change the output, but it would be interesting to understand why it's happening.",
"To find out why it's happening I suspect we'll need a pygments bug to investigate.\n\nThe span doesn't change what you copy out of the text though "
] |
https://api.github.com/repos/psf/requests/issues/6552 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6552/labels{/name} | https://api.github.com/repos/psf/requests/issues/6552/comments | https://api.github.com/repos/psf/requests/issues/6552/events | https://github.com/psf/requests/pull/6552 | 1,948,644,028 | PR_kwDOABTKOs5dFSN3 | 6,552 | #6551 - assert statements for test test_header_validation | {
"avatar_url": "https://avatars.githubusercontent.com/u/49934133?v=4",
"events_url": "https://api.github.com/users/swims-hjkl/events{/privacy}",
"followers_url": "https://api.github.com/users/swims-hjkl/followers",
"following_url": "https://api.github.com/users/swims-hjkl/following{/other_user}",
"gists_url": "https://api.github.com/users/swims-hjkl/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/swims-hjkl",
"id": 49934133,
"login": "swims-hjkl",
"node_id": "MDQ6VXNlcjQ5OTM0MTMz",
"organizations_url": "https://api.github.com/users/swims-hjkl/orgs",
"received_events_url": "https://api.github.com/users/swims-hjkl/received_events",
"repos_url": "https://api.github.com/users/swims-hjkl/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/swims-hjkl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/swims-hjkl/subscriptions",
"type": "User",
"url": "https://api.github.com/users/swims-hjkl",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2023-10-18T02:19:46Z | 2024-10-18T00:04:17Z | 2023-10-18T06:08:52Z | CONTRIBUTOR | resolved | added assert statements tests/test_requests/test_header_validation in regards to the issue #6551 | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6552/reactions"
} | https://api.github.com/repos/psf/requests/issues/6552/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6552.diff",
"html_url": "https://github.com/psf/requests/pull/6552",
"merged_at": "2023-10-18T06:08:52Z",
"patch_url": "https://github.com/psf/requests/pull/6552.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6552"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6551 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6551/labels{/name} | https://api.github.com/repos/psf/requests/issues/6551/comments | https://api.github.com/repos/psf/requests/issues/6551/events | https://github.com/psf/requests/issues/6551 | 1,946,835,073 | I_kwDOABTKOs50CliB | 6,551 | Missing assert in test_requests.py test_header_validation | {
"avatar_url": "https://avatars.githubusercontent.com/u/113030?v=4",
"events_url": "https://api.github.com/users/Sjord/events{/privacy}",
"followers_url": "https://api.github.com/users/Sjord/followers",
"following_url": "https://api.github.com/users/Sjord/following{/other_user}",
"gists_url": "https://api.github.com/users/Sjord/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Sjord",
"id": 113030,
"login": "Sjord",
"node_id": "MDQ6VXNlcjExMzAzMA==",
"organizations_url": "https://api.github.com/users/Sjord/orgs",
"received_events_url": "https://api.github.com/users/Sjord/received_events",
"repos_url": "https://api.github.com/users/Sjord/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Sjord/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Sjord/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Sjord",
"user_view_type": "public"
} | [
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"name": "Contributor Friendly",
"node_id": "MDU6TGFiZWwxOTEyNzQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Contributor%20Friendly"
},
{
"color": "69ccdb",
"default": false,
"description": null,
"id": 773540467,
"name": "PR(s) Wanted",
"node_id": "MDU6TGFiZWw3NzM1NDA0Njc=",
"url": "https://api.github.com/repos/psf/requests/labels/PR(s)%20Wanted"
}
] | closed | true | null | [] | null | 2 | 2023-10-17T08:18:52Z | 2024-10-18T00:04:16Z | 2023-10-18T06:09:39Z | NONE | resolved | [requests/tests/test\_requests.py at main · psf/requests](https://github.com/psf/requests/blob/main/tests/test_requests.py#L1705)
```
def test_header_validation(self, httpbin):
"""Ensure prepare_headers regex isn't flagging valid header contents."""
valid_headers = {
"foo": "bar baz qux",
"bar": b"fbbq",
"baz": "",
"qux": "1",
}
r = requests.get(httpbin("get"), headers=valid_headers)
for key in valid_headers.keys():
valid_headers[key] == r.request.headers[key]
```
`valid_headers[key] == r.request.headers[key]` should probably be `assert valid_headers[key] == r.request.headers[key]`. | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6551/reactions"
} | https://api.github.com/repos/psf/requests/issues/6551/timeline | null | completed | null | null | false | [
"I would like to contribute to solve this issue. @sigmavirus24 can I take this up?",
"Resolved in #6552"
] |
https://api.github.com/repos/psf/requests/issues/6550 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6550/labels{/name} | https://api.github.com/repos/psf/requests/issues/6550/comments | https://api.github.com/repos/psf/requests/issues/6550/events | https://github.com/psf/requests/pull/6550 | 1,945,599,788 | PR_kwDOABTKOs5c67G7 | 6,550 | making some careless changes | {
"avatar_url": "https://avatars.githubusercontent.com/u/56771141?v=4",
"events_url": "https://api.github.com/users/jack17davis/events{/privacy}",
"followers_url": "https://api.github.com/users/jack17davis/followers",
"following_url": "https://api.github.com/users/jack17davis/following{/other_user}",
"gists_url": "https://api.github.com/users/jack17davis/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jack17davis",
"id": 56771141,
"login": "jack17davis",
"node_id": "MDQ6VXNlcjU2NzcxMTQx",
"organizations_url": "https://api.github.com/users/jack17davis/orgs",
"received_events_url": "https://api.github.com/users/jack17davis/received_events",
"repos_url": "https://api.github.com/users/jack17davis/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jack17davis/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jack17davis/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jack17davis",
"user_view_type": "public"
} | [
{
"color": "d16014",
"default": false,
"description": "",
"id": 2392364523,
"name": "spam",
"node_id": "MDU6TGFiZWwyMzkyMzY0NTIz",
"url": "https://api.github.com/repos/psf/requests/labels/spam"
}
] | closed | true | null | [] | null | 0 | 2023-10-16T16:04:59Z | 2024-10-16T00:04:19Z | 2023-10-16T16:05:25Z | NONE | resolved | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/56771141?v=4",
"events_url": "https://api.github.com/users/jack17davis/events{/privacy}",
"followers_url": "https://api.github.com/users/jack17davis/followers",
"following_url": "https://api.github.com/users/jack17davis/following{/other_user}",
"gists_url": "https://api.github.com/users/jack17davis/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jack17davis",
"id": 56771141,
"login": "jack17davis",
"node_id": "MDQ6VXNlcjU2NzcxMTQx",
"organizations_url": "https://api.github.com/users/jack17davis/orgs",
"received_events_url": "https://api.github.com/users/jack17davis/received_events",
"repos_url": "https://api.github.com/users/jack17davis/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jack17davis/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jack17davis/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jack17davis",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6550/reactions"
} | https://api.github.com/repos/psf/requests/issues/6550/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6550.diff",
"html_url": "https://github.com/psf/requests/pull/6550",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6550.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6550"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6549 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6549/labels{/name} | https://api.github.com/repos/psf/requests/issues/6549/comments | https://api.github.com/repos/psf/requests/issues/6549/events | https://github.com/psf/requests/issues/6549 | 1,938,524,962 | I_kwDOABTKOs5zi4si | 6,549 | Meaning of logo | {
"avatar_url": "https://avatars.githubusercontent.com/u/1161465?v=4",
"events_url": "https://api.github.com/users/oddsun/events{/privacy}",
"followers_url": "https://api.github.com/users/oddsun/followers",
"following_url": "https://api.github.com/users/oddsun/following{/other_user}",
"gists_url": "https://api.github.com/users/oddsun/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/oddsun",
"id": 1161465,
"login": "oddsun",
"node_id": "MDQ6VXNlcjExNjE0NjU=",
"organizations_url": "https://api.github.com/users/oddsun/orgs",
"received_events_url": "https://api.github.com/users/oddsun/received_events",
"repos_url": "https://api.github.com/users/oddsun/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/oddsun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oddsun/subscriptions",
"type": "User",
"url": "https://api.github.com/users/oddsun",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
}
] | closed | true | null | [] | null | 1 | 2023-10-11T19:05:03Z | 2024-10-12T00:04:09Z | 2023-10-12T02:38:54Z | NONE | resolved | I've been trying to find the meaning/story behind the requests logo. But I can't seem to find it in the documentation. I'm curious what it means and why it has a Caduceus symbol. It might be worth adding to the documentation. | {
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/6549/reactions"
} | https://api.github.com/repos/psf/requests/issues/6549/timeline | null | completed | null | null | false | [
"The logo is designed by Kenneth Reitz, the creator of `requests`. It's one of his own tattoos. \r\nhttps://kennethreitz.org/tattoos\r\n"
] |
https://api.github.com/repos/psf/requests/issues/6548 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6548/labels{/name} | https://api.github.com/repos/psf/requests/issues/6548/comments | https://api.github.com/repos/psf/requests/issues/6548/events | https://github.com/psf/requests/pull/6548 | 1,933,428,221 | PR_kwDOABTKOs5cR3Lr | 6,548 | Bump github/codeql-action from 2.21.3 to 2.22.1 | {
"avatar_url": "https://avatars.githubusercontent.com/in/29110?v=4",
"events_url": "https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/dependabot%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/dependabot",
"id": 49699333,
"login": "dependabot[bot]",
"node_id": "MDM6Qm90NDk2OTkzMzM=",
"organizations_url": "https://api.github.com/users/dependabot%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/dependabot%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/dependabot%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dependabot%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/dependabot%5Bbot%5D",
"user_view_type": "public"
} | [
{
"color": "0366d6",
"default": false,
"description": "Pull requests that update a dependency file",
"id": 1868210094,
"name": "dependencies",
"node_id": "MDU6TGFiZWwxODY4MjEwMDk0",
"url": "https://api.github.com/repos/psf/requests/labels/dependencies"
},
{
"color": "000000",
"default": false,
"description": "Pull requests that update GitHub Actions code",
"id": 5838729011,
"name": "github_actions",
"node_id": "LA_kwDOABTKOs8AAAABXAPvMw",
"url": "https://api.github.com/repos/psf/requests/labels/github_actions"
}
] | closed | true | null | [] | null | 0 | 2023-10-09T16:29:56Z | 2024-10-09T00:04:26Z | 2023-10-09T16:49:28Z | CONTRIBUTOR | resolved | Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.3 to 2.22.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<ul>
<li>Improve the log output when an error occurs in an invocation of the CodeQL CLI. <a href="https://redirect.github.com/github/codeql-action/pull/1927">#1927</a></li>
</ul>
<h2>2.22.1 - 09 Oct 2023</h2>
<ul>
<li>Add a workaround for Python 3.12, which is not supported in CodeQL CLI version 2.14.6 or earlier. If you are running an analysis on Windows and using Python 3.12 or later, the CodeQL Action will switch to running Python 3.11. In this case, if Python 3.11 is not found, then the workflow will fail. <a href="https://redirect.github.com/github/codeql-action/pull/1928">#1928</a></li>
</ul>
<h2>2.22.0 - 06 Oct 2023</h2>
<ul>
<li>The CodeQL Action now requires CodeQL version 2.10.5 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.21.8. <a href="https://redirect.github.com/github/codeql-action/pull/1907">#1907</a></li>
<li>The CodeQL Action no longer runs ML-powered queries. For more information, including details on our investment in AI-powered security technology, see <a href="https://github.blog/changelog/2023-09-29-codeql-code-scanning-deprecates-ml-powered-alerts/">"CodeQL code scanning deprecates ML-powered alerts."</a> <a href="https://redirect.github.com/github/codeql-action/pull/1910">#1910</a></li>
<li>Fix a bug which prevented tracing of projects using Go 1.21 and above on Linux. <a href="https://redirect.github.com/github/codeql-action/pull/1909">#1909</a></li>
</ul>
<h2>2.21.9 - 27 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.6. <a href="https://redirect.github.com/github/codeql-action/pull/1897">#1897</a></li>
<li>We are rolling out a feature in October 2023 that will improve the success rate of C/C++ autobuild. <a href="https://redirect.github.com/github/codeql-action/pull/1889">#1889</a></li>
<li>We are rolling out a feature in October 2023 that will provide specific file coverage information for C and C++, Java and Kotlin, and JavaScript and TypeScript. Currently file coverage information for each of these pairs of languages is grouped together. <a href="https://redirect.github.com/github/codeql-action/pull/1903">#1903</a></li>
<li>Add a warning to help customers avoid inadvertently analyzing the same CodeQL language in multiple matrix jobs. <a href="https://redirect.github.com/github/codeql-action/pull/1901">#1901</a></li>
</ul>
<h2>2.21.8 - 19 Sep 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.10.4 and earlier. These versions of CodeQL were discontinued on 12 September 2023 alongside GitHub Enterprise Server 3.6, and will be unsupported by the next minor release of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/1884">#1884</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.10.5 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.9.5 and 2.10.4, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.21.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
<li>Enable the following language aliases when using CodeQL 2.14.4 and later: <code>c-cpp</code> for C/C++ analysis, <code>java-kotlin</code> for Java/Kotlin analysis, and <code>javascript-typescript</code> for JavaScript/TypeScript analysis. <a href="https://redirect.github.com/github/codeql-action/pull/1883">#1883</a></li>
</ul>
<h2>2.21.7 - 14 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.5. <a href="https://redirect.github.com/github/codeql-action/pull/1882">#1882</a></li>
</ul>
<h2>2.21.6 - 13 Sep 2023</h2>
<ul>
<li>Better error message when there is a failure to determine the merge base of the code to analysis. <a href="https://redirect.github.com/github/codeql-action/pull/1860">#1860</a></li>
<li>Improve the calculation of default amount of RAM used for query execution on GitHub Enterprise Server. This now reduces in proportion to the runner's total memory to better account for system memory usage, helping to avoid out-of-memory failures on larger runners. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/1866">#1866</a></li>
<li>Enable improved file coverage information for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/1867">#1867</a></li>
<li>Update default CodeQL bundle version to 2.14.4. <a href="https://redirect.github.com/github/codeql-action/pull/1873">#1873</a></li>
</ul>
<h2>2.21.5 - 28 Aug 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.3. <a href="https://redirect.github.com/github/codeql-action/pull/1845">#1845</a></li>
<li>Fixed a bug in CodeQL Action 2.21.3 onwards that affected beta support for <a href="https://projectlombok.org/">Project Lombok</a> when analyzing Java. The environment variable <code>CODEQL_EXTRACTOR_JAVA_RUN_ANNOTATION_PROCESSORS</code> will now be respected if it was manually configured in the workflow. <a href="https://redirect.github.com/github/codeql-action/pull/1844">#1844</a></li>
<li>Enable support for Kotlin 1.9.20 when running with CodeQL CLI v2.13.4 through v2.14.3. <a href="https://redirect.github.com/github/codeql-action/pull/1853">#1853</a></li>
</ul>
<h2>2.21.4 - 14 Aug 2023</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/fdcae64e1484d349b3366718cdfef3d404390e85"><code>fdcae64</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1932">#1932</a> from github/update-v2.22.1-18e6c398c</li>
<li><a href="https://github.com/github/codeql-action/commit/8554648f4166b879f10ae85f988366f33c141e98"><code>8554648</code></a> Update changelog for v2.22.1</li>
<li><a href="https://github.com/github/codeql-action/commit/18e6c398cedeb4cbcc309db7368bce694114d557"><code>18e6c39</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1930">#1930</a> from github/aeisenberg-patch-1</li>
<li><a href="https://github.com/github/codeql-action/commit/5e34d08d9e10dfaf5fb9687cdc86cca9a464d3da"><code>5e34d08</code></a> Link PR and fix case of Python</li>
<li><a href="https://github.com/github/codeql-action/commit/faf91ca6bdfbb188e08c26988cb8f7dcedcff3b1"><code>faf91ca</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1926">#1926</a> from github/mbg/suppress-go-workaround-warning</li>
<li><a href="https://github.com/github/codeql-action/commit/ffaea6c83728a7e5cc45649783ad7df1a269b538"><code>ffaea6c</code></a> Merge branch 'main' into mbg/suppress-go-workaround-warning</li>
<li><a href="https://github.com/github/codeql-action/commit/0a0988c4b2b3e3d28e737f37754ce5a4398df4fd"><code>0a0988c</code></a> Update CHANGELOG.md</li>
<li><a href="https://github.com/github/codeql-action/commit/0d5c2e0228a3cc9f86bf47c899e6c37286189a70"><code>0d5c2e0</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1928">#1928</a> from github/aeisenberg/fix-python312</li>
<li><a href="https://github.com/github/codeql-action/commit/94b6970619642ae1a60a8a65a875ed636a9d1e0c"><code>94b6970</code></a> Update CHANGELOG.md</li>
<li><a href="https://github.com/github/codeql-action/commit/669c61022cfc3e7ad3cb72077890e6352782a071"><code>669c610</code></a> Add a feature flag to turn this off for newer versions of codeql</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/5b6282e01c62d02e720b81eb8a51204f527c3624...fdcae64e1484d349b3366718cdfef3d404390e85">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details> | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6548/reactions"
} | https://api.github.com/repos/psf/requests/issues/6548/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6548.diff",
"html_url": "https://github.com/psf/requests/pull/6548",
"merged_at": "2023-10-09T16:49:28Z",
"patch_url": "https://github.com/psf/requests/pull/6548.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6548"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6547 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6547/labels{/name} | https://api.github.com/repos/psf/requests/issues/6547/comments | https://api.github.com/repos/psf/requests/issues/6547/events | https://github.com/psf/requests/issues/6547 | 1,931,740,158 | I_kwDOABTKOs5zJAP- | 6,547 | http3 support | {
"avatar_url": "https://avatars.githubusercontent.com/u/62409625?v=4",
"events_url": "https://api.github.com/users/finalparanoia/events{/privacy}",
"followers_url": "https://api.github.com/users/finalparanoia/followers",
"following_url": "https://api.github.com/users/finalparanoia/following{/other_user}",
"gists_url": "https://api.github.com/users/finalparanoia/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/finalparanoia",
"id": 62409625,
"login": "finalparanoia",
"node_id": "MDQ6VXNlcjYyNDA5NjI1",
"organizations_url": "https://api.github.com/users/finalparanoia/orgs",
"received_events_url": "https://api.github.com/users/finalparanoia/received_events",
"repos_url": "https://api.github.com/users/finalparanoia/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/finalparanoia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/finalparanoia/subscriptions",
"type": "User",
"url": "https://api.github.com/users/finalparanoia",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2023-10-08T10:04:23Z | 2024-10-08T00:06:41Z | 2023-10-08T14:39:37Z | NONE | resolved | will this lib support http3? | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6547/reactions"
} | https://api.github.com/repos/psf/requests/issues/6547/timeline | null | not_planned | null | null | false | [
"Not directly, no"
] |
https://api.github.com/repos/psf/requests/issues/6546 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6546/labels{/name} | https://api.github.com/repos/psf/requests/issues/6546/comments | https://api.github.com/repos/psf/requests/issues/6546/events | https://github.com/psf/requests/issues/6546 | 1,931,080,465 | I_kwDOABTKOs5zGfMR | 6,546 | @ethanroy No additional consideration beyond my suggestion of using a session-level auth handler, in the comment directly above yours. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1348991?v=4",
"events_url": "https://api.github.com/users/skeggse/events{/privacy}",
"followers_url": "https://api.github.com/users/skeggse/followers",
"following_url": "https://api.github.com/users/skeggse/following{/other_user}",
"gists_url": "https://api.github.com/users/skeggse/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/skeggse",
"id": 1348991,
"login": "skeggse",
"node_id": "MDQ6VXNlcjEzNDg5OTE=",
"organizations_url": "https://api.github.com/users/skeggse/orgs",
"received_events_url": "https://api.github.com/users/skeggse/received_events",
"repos_url": "https://api.github.com/users/skeggse/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/skeggse/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/skeggse/subscriptions",
"type": "User",
"url": "https://api.github.com/users/skeggse",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2023-10-07T00:34:43Z | 2024-10-07T00:04:27Z | 2023-10-07T22:32:45Z | NONE | resolved | > @ethanroy No additional consideration beyond my suggestion of using a session-level auth handler, in the comment directly above yours.
_Originally posted by @Lukasa in https://github.com/psf/requests/issues/2949#issuecomment-234553490_
I'm not sure if this used to work, or if something broke in the interim, but attaching an auth handler to a session does not cause the handler to get invoked for each redirect after the first request. Oddly, it seems like that's also the case for adapters, so it doesn't seem that there's a way to correctly set auth headers after a redirect. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6546/reactions"
} | https://api.github.com/repos/psf/requests/issues/6546/timeline | null | not_planned | null | null | false | [
"Responding to a conversation by opening an issue is not a valid bug report. If you need assistance with your auth handler, please use StackOverflow "
] |
https://api.github.com/repos/psf/requests/issues/6545 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6545/labels{/name} | https://api.github.com/repos/psf/requests/issues/6545/comments | https://api.github.com/repos/psf/requests/issues/6545/events | https://github.com/psf/requests/pull/6545 | 1,930,875,841 | PR_kwDOABTKOs5cJXUX | 6,545 | Fix urllib3 pin in setup.cfg | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2023-10-06T20:10:28Z | 2024-10-06T00:04:31Z | 2023-10-06T22:34:24Z | MEMBER | resolved | This should resolve #6544. | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6545/reactions"
} | https://api.github.com/repos/psf/requests/issues/6545/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6545.diff",
"html_url": "https://github.com/psf/requests/pull/6545",
"merged_at": "2023-10-06T22:34:24Z",
"patch_url": "https://github.com/psf/requests/pull/6545.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6545"
} | true | [
"LGTM, thanks for fixing.",
"Currently blocked on Flask 3.0.0 issues. We'll need to get those fixed first.",
"psf/httpbin#28",
"I've put up psf/httpbin#29 to address the test suite issues. We'll go ahead and merge this since I'm not concerned about the test suite with this change."
] |
https://api.github.com/repos/psf/requests/issues/6544 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6544/labels{/name} | https://api.github.com/repos/psf/requests/issues/6544/comments | https://api.github.com/repos/psf/requests/issues/6544/events | https://github.com/psf/requests/issues/6544 | 1,930,870,756 | I_kwDOABTKOs5zFr_k | 6,544 | Conflicting requirements for urllib3 | {
"avatar_url": "https://avatars.githubusercontent.com/u/2747104?v=4",
"events_url": "https://api.github.com/users/xypron/events{/privacy}",
"followers_url": "https://api.github.com/users/xypron/followers",
"following_url": "https://api.github.com/users/xypron/following{/other_user}",
"gists_url": "https://api.github.com/users/xypron/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/xypron",
"id": 2747104,
"login": "xypron",
"node_id": "MDQ6VXNlcjI3NDcxMDQ=",
"organizations_url": "https://api.github.com/users/xypron/orgs",
"received_events_url": "https://api.github.com/users/xypron/received_events",
"repos_url": "https://api.github.com/users/xypron/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/xypron/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xypron/subscriptions",
"type": "User",
"url": "https://api.github.com/users/xypron",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
}
] | closed | true | null | [] | null | 1 | 2023-10-06T20:05:38Z | 2024-10-06T00:04:29Z | 2023-10-06T22:34:25Z | NONE | resolved | In origin/main ee93fac6b2f7 I find conflicting required urllib3 version information:
```
setup.cfg:10: urllib3>=1.21.1,<1.27
setup.py:64: "urllib3>=1.21.1,<3",
```
Shouldn't both files have the same restrictions?
Best regards
Heinrich | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6544/reactions"
} | https://api.github.com/repos/psf/requests/issues/6544/timeline | null | completed | null | null | false | [
"They should, good catch xypron. We'll work on getting those aligned."
] |
https://api.github.com/repos/psf/requests/issues/6543 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6543/labels{/name} | https://api.github.com/repos/psf/requests/issues/6543/comments | https://api.github.com/repos/psf/requests/issues/6543/events | https://github.com/psf/requests/issues/6543 | 1,930,138,362 | I_kwDOABTKOs5zC5L6 | 6,543 | EOF occurred in violation of protocol starting Python3.10 on large requests | {
"avatar_url": "https://avatars.githubusercontent.com/u/1726895?v=4",
"events_url": "https://api.github.com/users/3asm/events{/privacy}",
"followers_url": "https://api.github.com/users/3asm/followers",
"following_url": "https://api.github.com/users/3asm/following{/other_user}",
"gists_url": "https://api.github.com/users/3asm/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/3asm",
"id": 1726895,
"login": "3asm",
"node_id": "MDQ6VXNlcjE3MjY4OTU=",
"organizations_url": "https://api.github.com/users/3asm/orgs",
"received_events_url": "https://api.github.com/users/3asm/received_events",
"repos_url": "https://api.github.com/users/3asm/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/3asm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/3asm/subscriptions",
"type": "User",
"url": "https://api.github.com/users/3asm",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2023-10-06T13:00:42Z | 2024-10-06T00:04:30Z | 2023-10-06T15:23:42Z | NONE | resolved | # Bug report
### Bug description:
We have identified a regression starting with Python 3.10 when making a large request over TLS.
```python
import requests
requests.post('https://google.com', data=b'A'*1000000)
```
```python
urllib3.exceptions.SSLError: EOF occurred in violation of protocol (_ssl.c:2426)
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/requests/adapters.py", line 486, in send
resp = conn.urlopen(
File "/usr/local/lib/python3.10/site-packages/urllib3/connectionpool.py", line 844, in urlopen
retries = retries.increment(
File "/usr/local/lib/python3.10/site-packages/urllib3/util/retry.py", line 515, in increment
raise MaxRetryError(_pool, url, reason) from reason # type: ignore[arg-type]
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='google.com', port=443): Max retries exceeded with url: / (Caused by SSLError(SSLEOFError(8, 'EOF occurred in violation of protocol (_ssl.c:2426)')))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python3.10/site-packages/requests/api.py", line 115, in post
return request("post", url, data=data, json=json, **kwargs)
File "/usr/local/lib/python3.10/site-packages/requests/api.py", line 59, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python3.10/site-packages/requests/sessions.py", line 589, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python3.10/site-packages/requests/sessions.py", line 703, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python3.10/site-packages/requests/adapters.py", line 517, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: HTTPSConnectionPool(host='google.com', port=443): Max retries exceeded with url: / (Caused by SSLError(SSLEOFError(8, 'EOF occurred in violation of protocol (_ssl.c:2426)')))
```
The same request works fine on Python 3.9.
### CPython versions tested on:
3.10, 3.11, 3.12
### Operating systems tested on:
Linux | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6543/reactions"
} | https://api.github.com/repos/psf/requests/issues/6543/timeline | null | completed | null | null | false | [
"Closing to track on https://github.com/urllib3/urllib3/issues/3148 which you opened simultaneously."
] |
https://api.github.com/repos/psf/requests/issues/6542 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6542/labels{/name} | https://api.github.com/repos/psf/requests/issues/6542/comments | https://api.github.com/repos/psf/requests/issues/6542/events | https://github.com/psf/requests/issues/6542 | 1,920,380,338 | I_kwDOABTKOs5ydq2y | 6,542 | Cookies with `Secure` are not sent for `localhost` via unencrypted `http` | {
"avatar_url": "https://avatars.githubusercontent.com/u/31801109?v=4",
"events_url": "https://api.github.com/users/42triangles/events{/privacy}",
"followers_url": "https://api.github.com/users/42triangles/followers",
"following_url": "https://api.github.com/users/42triangles/following{/other_user}",
"gists_url": "https://api.github.com/users/42triangles/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/42triangles",
"id": 31801109,
"login": "42triangles",
"node_id": "MDQ6VXNlcjMxODAxMTA5",
"organizations_url": "https://api.github.com/users/42triangles/orgs",
"received_events_url": "https://api.github.com/users/42triangles/received_events",
"repos_url": "https://api.github.com/users/42triangles/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/42triangles/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/42triangles/subscriptions",
"type": "User",
"url": "https://api.github.com/users/42triangles",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 2 | 2023-09-30T19:50:23Z | 2024-09-09T15:54:34Z | 2023-09-30T23:33:02Z | NONE | null | See the title, `Secure` cookies are not sent in requests to `localhost` if those requests are not encrypted. There should probably be an exception for `localhost` (as there is in browsers, as well) to aid in developing servers.
## Expected Result
The cookies should be sent with the request.
## Actual Result
They aren't.
## Reproduction Steps
```python
import requests
session = requests.Session()
session.post("http://localhost:8080/login")
session.get("http://localhost:8080/only-with-login").raise_for_status()
```
and
```python
from flask import Flask, request, make_response
app = Flask(__name__)
@app.route("/login")
def login():
resp = make_response("Logged in")
resp.set_cookie("token", "token", secure=True)
return resp
@app.route("/only-with-login")
def only_with_login():
if request.cookies.get("token") != "token":
return "Not logged in", 403
return "Logged in"
```
Running the flask app with `flask --app server run --port 8080` and then running the requests with `python3 do_requests.py` throws an exception in `do_requests`, while in a browser the page does show "Logged in" after visiting `http://localhost:8080/login`.
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": "5.2.0"
},
"charset_normalizer": {
"version": "3.2.0"
},
"cryptography": {
"version": "41.0.3"
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "CPython",
"version": "3.11.5"
},
"platform": {
"release": "6.5.4-arch2-1",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "30100020",
"version": "23.2.0"
},
"requests": {
"version": "2.28.2"
},
"system_ssl": {
"version": "30100030"
},
"urllib3": {
"version": "1.26.15"
},
"using_charset_normalizer": false,
"using_pyopenssl": true
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6542/reactions"
} | https://api.github.com/repos/psf/requests/issues/6542/timeline | null | not_planned | null | null | false | [
"No we'll not be introducing code to handle this. Use something like trustme to generate certs and validate them with requests instead and you'll get the correct behavior 100% of the time. ",
"This resolution is counterintuitive since it puts Requests at odds with browser behaviour:\r\n\r\n* Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1648993\r\n* Chromium: https://issues.chromium.org/issues/40120372\r\n\r\n[MDN also documents this special-case](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#secure):\r\n\r\n> The `https:` requirements are ignored when the `Secure` attribute is set by localhost (since Chrome 89 and Firefox 75)."
] |
https://api.github.com/repos/psf/requests/issues/6541 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6541/labels{/name} | https://api.github.com/repos/psf/requests/issues/6541/comments | https://api.github.com/repos/psf/requests/issues/6541/events | https://github.com/psf/requests/issues/6541 | 1,920,280,168 | I_kwDOABTKOs5ydSZo | 6,541 | 'parse_authorization_header' not found in werkzeug 3.0.0 | {
"avatar_url": "https://avatars.githubusercontent.com/u/47403620?v=4",
"events_url": "https://api.github.com/users/psriram4/events{/privacy}",
"followers_url": "https://api.github.com/users/psriram4/followers",
"following_url": "https://api.github.com/users/psriram4/following{/other_user}",
"gists_url": "https://api.github.com/users/psriram4/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/psriram4",
"id": 47403620,
"login": "psriram4",
"node_id": "MDQ6VXNlcjQ3NDAzNjIw",
"organizations_url": "https://api.github.com/users/psriram4/orgs",
"received_events_url": "https://api.github.com/users/psriram4/received_events",
"repos_url": "https://api.github.com/users/psriram4/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/psriram4/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/psriram4/subscriptions",
"type": "User",
"url": "https://api.github.com/users/psriram4",
"user_view_type": "public"
} | [] | closed | false | null | [] | null | 4 | 2023-09-30T14:32:16Z | 2023-11-27T23:33:44Z | 2023-09-30T15:02:55Z | NONE | null | I run in to the following error:
`ImportError: cannot import name 'parse_authorization_header' from 'werkzeug.http' (/usr/local/lib/python3.9/site-packages/werkzeug/http.py)`.
## Reproduction Steps
```
pip install -r requirements_dev.txt
```
I'm able to resolve it if I downgrade werkzeug to a lower version (2.3.7). I think this needs to be accounted for in the dependencies or code.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6541/reactions"
} | https://api.github.com/repos/psf/requests/issues/6541/timeline | null | completed | null | null | false | [
"This does not seem to be a bug with requests as we do not rely on werkzeug. Please file this in a more appropriate place with much more detail for that project to be able to help you",
"I hit this problem on MacOS 14.1.1.\r\n\r\nIn this example, I'm running Python 3.9.16. I saw the same failure on 3.11.4 on a different Mac.\r\n\r\nIn a fresh checkout:\r\n\r\n```\r\n% python -m venv venv\r\n% source venv/bin/activate\r\n% make\r\n. . . no failure here . . .\r\n% make ci\r\npython -m pytest tests --junitxml=report.xml\r\nTraceback (most recent call last):\r\n File \"/Users/bruce/.pyenv/versions/3.9.16/lib/python3.9/runpy.py\", line 197, in _run_module_as_main\r\n return _run_code(code, main_globals, None,\r\n File \"/Users/bruce/.pyenv/versions/3.9.16/lib/python3.9/runpy.py\", line 87, in _run_code\r\n exec(code, run_globals)\r\n File \"/Users/bruce/github/requests/venv/lib/python3.9/site-packages/pytest/__main__.py\", line 5, in <module>\r\n raise SystemExit(pytest.console_main())\r\n File \"/Users/bruce/github/requests/venv/lib/python3.9/site-packages/_pytest/config/__init__.py\", line 185, in console_main\r\n code = main()\r\n File \"/Users/bruce/github/requests/venv/lib/python3.9/site-packages/_pytest/config/__init__.py\", line 143, in main\r\n config = _prepareconfig(args, plugins)\r\n File \"/Users/bruce/github/requests/venv/lib/python3.9/site-packages/_pytest/config/__init__.py\", line 318, in _prepareconfig\r\n config = pluginmanager.hook.pytest_cmdline_parse(\r\n File \"/Users/bruce/github/requests/venv/lib/python3.9/site-packages/pluggy/_hooks.py\", line 493, in __call__\r\n return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)\r\n File \"/Users/bruce/github/requests/venv/lib/python3.9/site-packages/pluggy/_manager.py\", line 115, in _hookexec\r\n return self._inner_hookexec(hook_name, methods, kwargs, firstresult)\r\n File \"/Users/bruce/github/requests/venv/lib/python3.9/site-packages/pluggy/_callers.py\", line 130, in _multicall\r\n teardown[0].send(outcome)\r\n File \"/Users/bruce/github/requests/venv/lib/python3.9/site-packages/_pytest/helpconfig.py\", line 100, in pytest_cmdline_parse\r\n config: Config = outcome.get_result()\r\n File \"/Users/bruce/github/requests/venv/lib/python3.9/site-packages/pluggy/_result.py\", line 114, in get_result\r\n raise exc.with_traceback(exc.__traceback__)\r\n File \"/Users/bruce/github/requests/venv/lib/python3.9/site-packages/pluggy/_callers.py\", line 77, in _multicall\r\n res = hook_impl.function(*args)\r\n File \"/Users/bruce/github/requests/venv/lib/python3.9/site-packages/_pytest/config/__init__.py\", line 1003, in pytest_cmdline_parse\r\n self.parse(args)\r\n File \"/Users/bruce/github/requests/venv/lib/python3.9/site-packages/_pytest/config/__init__.py\", line 1283, in parse\r\n self._preparse(args, addopts=addopts)\r\n File \"/Users/bruce/github/requests/venv/lib/python3.9/site-packages/_pytest/config/__init__.py\", line 1172, in _preparse\r\n self.pluginmanager.load_setuptools_entrypoints(\"pytest11\")\r\n File \"/Users/bruce/github/requests/venv/lib/python3.9/site-packages/pluggy/_manager.py\", line 398, in load_setuptools_entrypoints\r\n plugin = ep.load()\r\n File \"/Users/bruce/.pyenv/versions/3.9.16/lib/python3.9/importlib/metadata.py\", line 86, in load\r\n module = import_module(match.group('module'))\r\n File \"/Users/bruce/.pyenv/versions/3.9.16/lib/python3.9/importlib/__init__.py\", line 127, in import_module\r\n return _bootstrap._gcd_import(name[level:], package, level)\r\n File \"<frozen importlib._bootstrap>\", line 1030, in _gcd_import\r\n File \"<frozen importlib._bootstrap>\", line 1007, in _find_and_load\r\n File \"<frozen importlib._bootstrap>\", line 986, in _find_and_load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 680, in _load_unlocked\r\n File \"/Users/bruce/github/requests/venv/lib/python3.9/site-packages/_pytest/assertion/rewrite.py\", line 170, in exec_module\r\n exec(co, module.__dict__)\r\n File \"/Users/bruce/github/requests/venv/lib/python3.9/site-packages/pytest_httpbin/plugin.py\", line 2, in <module>\r\n from httpbin import app as httpbin_app\r\n File \"/Users/bruce/github/requests/venv/lib/python3.9/site-packages/httpbin/__init__.py\", line 3, in <module>\r\n from .core import *\r\n File \"/Users/bruce/github/requests/venv/lib/python3.9/site-packages/httpbin/core.py\", line 35, in <module>\r\n from werkzeug.http import parse_authorization_header\r\nImportError: cannot import name 'parse_authorization_header' from 'werkzeug.http' (/Users/bruce/github/requests/venv/lib/python3.9/site-packages/werkzeug/http.py)\r\nmake: *** [ci] Error 1\r\n```",
"@bruceadams the issue is with a test dependent, not requests",
"For anyone who hits this problem in the future, a workaround is to add the entry `werkzeug<3.0.0` into `requirements-dev.txt`. With this addition, running requests unit tests works.\r\n\r\n```bash\r\necho 'werkzeug<3.0.0' >> requirements-dev.txt\r\nmake\r\nmake ci\r\n```\r\n\r\nMy wild guess is this problem is specific to Mac's with Apple Silicon, since `make && make ci` appears to run fine on [macOS on GitHub Actions](https://github.com/psf/requests/blob/main/.github/workflows/run-tests.yml)."
] |
https://api.github.com/repos/psf/requests/issues/6540 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6540/labels{/name} | https://api.github.com/repos/psf/requests/issues/6540/comments | https://api.github.com/repos/psf/requests/issues/6540/events | https://github.com/psf/requests/pull/6540 | 1,915,952,456 | PR_kwDOABTKOs5bXFd8 | 6,540 | Create master | {
"avatar_url": "https://avatars.githubusercontent.com/u/139004803?v=4",
"events_url": "https://api.github.com/users/fc700/events{/privacy}",
"followers_url": "https://api.github.com/users/fc700/followers",
"following_url": "https://api.github.com/users/fc700/following{/other_user}",
"gists_url": "https://api.github.com/users/fc700/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/fc700",
"id": 139004803,
"login": "fc700",
"node_id": "U_kgDOCEkLgw",
"organizations_url": "https://api.github.com/users/fc700/orgs",
"received_events_url": "https://api.github.com/users/fc700/received_events",
"repos_url": "https://api.github.com/users/fc700/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/fc700/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fc700/subscriptions",
"type": "User",
"url": "https://api.github.com/users/fc700",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2023-09-27T16:36:23Z | 2024-10-01T00:04:39Z | 2023-09-27T16:37:32Z | NONE | resolved | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6540/reactions"
} | https://api.github.com/repos/psf/requests/issues/6540/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6540.diff",
"html_url": "https://github.com/psf/requests/pull/6540",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6540.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6540"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6539 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6539/labels{/name} | https://api.github.com/repos/psf/requests/issues/6539/comments | https://api.github.com/repos/psf/requests/issues/6539/events | https://github.com/psf/requests/issues/6539 | 1,913,438,640 | I_kwDOABTKOs5yDMGw | 6,539 | Versions at requests.readthedocs.io flyout menu are outdated | {
"avatar_url": "https://avatars.githubusercontent.com/u/17479683?v=4",
"events_url": "https://api.github.com/users/fohrloop/events{/privacy}",
"followers_url": "https://api.github.com/users/fohrloop/followers",
"following_url": "https://api.github.com/users/fohrloop/following{/other_user}",
"gists_url": "https://api.github.com/users/fohrloop/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/fohrloop",
"id": 17479683,
"login": "fohrloop",
"node_id": "MDQ6VXNlcjE3NDc5Njgz",
"organizations_url": "https://api.github.com/users/fohrloop/orgs",
"received_events_url": "https://api.github.com/users/fohrloop/received_events",
"repos_url": "https://api.github.com/users/fohrloop/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/fohrloop/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fohrloop/subscriptions",
"type": "User",
"url": "https://api.github.com/users/fohrloop",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2023-09-26T12:47:08Z | 2024-10-15T00:04:17Z | 2023-10-15T22:07:45Z | NONE | resolved | The https://requests.readthedocs.io/ webpage flyout menu versions are currently:
- [latest](https://requests.readthedocs.io/en/latest/) [stable](https://requests.readthedocs.io/en/stable/) [v3.0.0](https://requests.readthedocs.io/en/v3.0.0/) [v2.9.1](https://requests.readthedocs.io/en/v2.9.1/) [v2.8.1](https://requests.readthedocs.io/en/v2.8.1/) [v2.7.0](https://requests.readthedocs.io/en/v2.7.0/) [v2.6.2](https://requests.readthedocs.io/en/v2.6.2/) [v2.5.3](https://requests.readthedocs.io/en/v2.5.3/) [v2.4.3](https://requests.readthedocs.io/en/v2.4.3/) [v2.3.0](https://requests.readthedocs.io/en/v2.3.0/) [v2.2.1](https://requests.readthedocs.io/en/v2.2.1/) [v2.1.0](https://requests.readthedocs.io/en/v2.1.0/) [v2.0.0](https://requests.readthedocs.io/en/v2.0.0/) [v1.2.3](https://requests.readthedocs.io/en/v1.2.3/) [v1.1.0](https://requests.readthedocs.io/en/v1.1.0/) [v1.0.4](https://requests.readthedocs.io/en/v1.0.4/)
Screenshot:
There are few problems with the versions:
- First, some of the selected versions in the flyout menu are really old. The 2.9.1 [is from December 2015](https://github.com/psf/requests/releases/tag/v2.9.1). I would expect to see 2.31.0, 2.30.0, 2.29.0 and perhaps 2.28.2 on the list.
- The 3.0.0 links to documentation for v.2.10.0.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6539/reactions"
} | https://api.github.com/repos/psf/requests/issues/6539/timeline | null | completed | null | null | false | [
"I would like to work on this issue. \r\nI am not much clear about the issue description, so could please elaborate on it.",
"The flyout menu is the black box in the bottom right corner:\r\n\r\n\r\nThis has old versions listed. It is missing recent versions like 2.31.0, 2.30.0, 2.29.0. In addition, the link for 3.0.0 in the flyout menu -- this:\r\n\r\n\r\n\r\n..points to documentation of v.2.10.0:\r\n\r\n\r\n",
"So issue says that, \r\n- Add the remaining versions like 2.31.0, 2.30.0, 2.29.0. \r\n- Correct the link for 3.0.0\r\n\r\nIs it correct or i left with anything else ?",
"I think what summarizes the issue well! :)",
"Hey while going through the code i am not able to locate the flyout menu.\r\nCould you please locate it.",
"I'm not familiar with the requests repository, but it could be also that it is configured somewhere in the readthedocs settings. I hope someone else here knows what should be edited.",
"These settings are managed form the administration panel in RTD. The older versions have been removed and we'll only be providing flyout links for stable (latest release) and latest (main branch). Thanks for the issue @fohrloop."
] |
https://api.github.com/repos/psf/requests/issues/6538 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6538/labels{/name} | https://api.github.com/repos/psf/requests/issues/6538/comments | https://api.github.com/repos/psf/requests/issues/6538/events | https://github.com/psf/requests/pull/6538 | 1,911,884,324 | PR_kwDOABTKOs5bJRw_ | 6,538 | Bump actions/checkout from 4.0.0 to 4.1.0 | {
"avatar_url": "https://avatars.githubusercontent.com/in/29110?v=4",
"events_url": "https://api.github.com/users/dependabot%5Bbot%5D/events{/privacy}",
"followers_url": "https://api.github.com/users/dependabot%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/dependabot%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/dependabot%5Bbot%5D/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apps/dependabot",
"id": 49699333,
"login": "dependabot[bot]",
"node_id": "MDM6Qm90NDk2OTkzMzM=",
"organizations_url": "https://api.github.com/users/dependabot%5Bbot%5D/orgs",
"received_events_url": "https://api.github.com/users/dependabot%5Bbot%5D/received_events",
"repos_url": "https://api.github.com/users/dependabot%5Bbot%5D/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dependabot%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dependabot%5Bbot%5D/subscriptions",
"type": "Bot",
"url": "https://api.github.com/users/dependabot%5Bbot%5D",
"user_view_type": "public"
} | [
{
"color": "0366d6",
"default": false,
"description": "Pull requests that update a dependency file",
"id": 1868210094,
"name": "dependencies",
"node_id": "MDU6TGFiZWwxODY4MjEwMDk0",
"url": "https://api.github.com/repos/psf/requests/labels/dependencies"
},
{
"color": "000000",
"default": false,
"description": "Pull requests that update GitHub Actions code",
"id": 5838729011,
"name": "github_actions",
"node_id": "LA_kwDOABTKOs8AAAABXAPvMw",
"url": "https://api.github.com/repos/psf/requests/labels/github_actions"
}
] | closed | true | null | [] | null | 0 | 2023-09-25T16:28:36Z | 2024-09-26T00:04:22Z | 2023-09-25T18:30:06Z | CONTRIBUTOR | resolved | Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.1.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update README.md for V4 by <a href="https://github.com/sivapalan"><code>@sivapalan</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1452">actions/checkout#1452</a></li>
<li>Add support for partial checkout filters by <a href="https://github.com/finleygn"><code>@finleygn</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1396">actions/checkout#1396</a></li>
<li>Prepare 4.1.0 release by <a href="https://github.com/cory-miller"><code>@cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1496">actions/checkout#1496</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/sivapalan"><code>@sivapalan</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1452">actions/checkout#1452</a></li>
<li><a href="https://github.com/finleygn"><code>@finleygn</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1396">actions/checkout#1396</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.0.0...v4.1.0">https://github.com/actions/checkout/compare/v4.0.0...v4.1.0</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v4.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1396">Add support for partial checkout filters</a></li>
</ul>
<h2>v4.0.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1067">Support fetching without the --progress option</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1436">Update to node20</a></li>
</ul>
<h2>v3.6.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1377">Fix: Mark test scripts with Bash'isms to be run via Bash</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/579">Add option to fetch tags even if fetch-depth > 0</a></li>
</ul>
<h2>v3.5.3</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1196">Fix: Checkout fail in self-hosted runners when faulty submodule are checked-in</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1287">Fix typos found by codespell</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1369">Add support for sparse checkouts</a></li>
</ul>
<h2>v3.5.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1289">Fix api endpoint for GHES</a></li>
</ul>
<h2>v3.5.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1246">Fix slow checkout on Windows</a></li>
</ul>
<h2>v3.5.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1237">Add new public key for known_hosts</a></li>
</ul>
<h2>v3.4.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1209">Upgrade codeql actions to v2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1210">Upgrade dependencies</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1225">Upgrade <code>@actions/io</code></a></li>
</ul>
<h2>v3.3.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1045">Implement branch list using callbacks from exec function</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1050">Add in explicit reference to private checkout options</a></li>
<li>[Fix comment typos (that got added in <a href="https://redirect.github.com/actions/checkout/issues/770">#770</a>)](<a href="https://redirect.github.com/actions/checkout/pull/1057">actions/checkout#1057</a>)</li>
</ul>
<h2>v3.2.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/942">Add GitHub Action to perform release</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/967">Fix status badge</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1002">Replace datadog/squid with ubuntu/squid Docker image</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/964">Wrap pipeline commands for submoduleForeach in quotes</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1029">Update <code>@actions/io</code> to 1.1.2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1039">Upgrading version to 3.2.0</a></li>
</ul>
<h2>v3.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/939">Use <code>@actions/core</code> <code>saveState</code> and <code>getState</code></a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/922">Add <code>github-server-url</code> input</a></li>
</ul>
<h2>v3.0.2</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/checkout/commit/8ade135a41bc03ea155e62e844d188df1ea18608"><code>8ade135</code></a> Prepare 4.1.0 release (<a href="https://redirect.github.com/actions/checkout/issues/1496">#1496</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/c533a0a4cfc4962971818edcfac47a2899e69799"><code>c533a0a</code></a> Add support for partial checkout filters (<a href="https://redirect.github.com/actions/checkout/issues/1396">#1396</a>)</li>
<li><a href="https://github.com/actions/checkout/commit/72f2cec99f417b1a1c5e2e88945068983b7965f9"><code>72f2cec</code></a> Update README.md for V4 (<a href="https://redirect.github.com/actions/checkout/issues/1452">#1452</a>)</li>
<li>See full diff in <a href="https://github.com/actions/checkout/compare/3df4ab11eba7bda6032a0b82a6bb43b11571feac...8ade135a41bc03ea155e62e844d188df1ea18608">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details> | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6538/reactions"
} | https://api.github.com/repos/psf/requests/issues/6538/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6538.diff",
"html_url": "https://github.com/psf/requests/pull/6538",
"merged_at": "2023-09-25T18:30:06Z",
"patch_url": "https://github.com/psf/requests/pull/6538.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6538"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6537 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6537/labels{/name} | https://api.github.com/repos/psf/requests/issues/6537/comments | https://api.github.com/repos/psf/requests/issues/6537/events | https://github.com/psf/requests/issues/6537 | 1,910,210,558 | I_kwDOABTKOs5x23_- | 6,537 | `unsafe legacy renegotiation disabled` error in specific website on Python 3.12 | {
"avatar_url": "https://avatars.githubusercontent.com/u/130233823?v=4",
"events_url": "https://api.github.com/users/ilotoki0804/events{/privacy}",
"followers_url": "https://api.github.com/users/ilotoki0804/followers",
"following_url": "https://api.github.com/users/ilotoki0804/following{/other_user}",
"gists_url": "https://api.github.com/users/ilotoki0804/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ilotoki0804",
"id": 130233823,
"login": "ilotoki0804",
"node_id": "U_kgDOB8M13w",
"organizations_url": "https://api.github.com/users/ilotoki0804/orgs",
"received_events_url": "https://api.github.com/users/ilotoki0804/received_events",
"repos_url": "https://api.github.com/users/ilotoki0804/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ilotoki0804/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ilotoki0804/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ilotoki0804",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2023-09-24T12:03:25Z | 2024-06-16T22:14:52Z | 2023-09-24T12:33:58Z | NONE | null | ## Issue Description
I've encountered a puzzling issue related to the `requests` library when using Python 3.12. Specifically, I'm receiving an "unsafe legacy renegotiation disabled" error when trying to access a specific website. This problem appears to be unique to Python 3.12, as I did not encounter it when using Python 3.11.4.
I've encountered a puzzling issue related to the requests library when using Python 3.12. Specifically, I'm receiving an "unsafe legacy renegotiation disabled" error when trying to access a specific website, [bufftoon.plaync.com/series/1001216](https://bufftoon.plaync.com/series/1001216). While I initially suspected that the issue might be related to the website itself, further investigation suggests that it's not the root cause. The error message indicates a problem with renegotiating SSL connections, which may be caused by Python 3.12, the requests library, OpenSSL, or other system-specific elements.
## Reproduction Steps
I've tested this in both Jupyter and a standard Python file, and the outcomes were the same. While accessing the website, you might need to use a VPN or Proxy to bypass any restrictions related to an abroad IP address. However, I found that the website produced consistent results when accessed through Github Codespace, hosted in Singapore, it appears that such limitations may not apply.
To reproduce the issue, you can use the following Python code:
```python
import requests
res = requests.get('https://bufftoon.plaync.com/series/1001216')
print(res)
```
## Expected Result
The expected result when running the code should be:
```
<Response [200]>
```
## Actual Result
However, when executing the same code on Python 3.12.0rc3, I encountered the following error:
```
---------------------------------------------------------------------------
SSLError Traceback (most recent call last)
...
SSLError: [SSL: UNSAFE_LEGACY_RENEGOTIATION_DISABLED] unsafe legacy renegotiation disabled (_ssl.c:1000)
During handling of the above exception, another exception occurred:
SSLError Traceback (most recent call last)
...
SSLError: [SSL: UNSAFE_LEGACY_RENEGOTIATION_DISABLED] unsafe legacy renegotiation disabled (_ssl.c:1000)
The above exception was the direct cause of the following exception:
MaxRetryError Traceback (most recent call last)
...
MaxRetryError: HTTPSConnectionPool(host='bufftoon.plaync.com', port=443): Max retries exceeded with url: /series/1001216 (Caused by SSLError(SSLError(1, '[SSL: UNSAFE_LEGACY_RENEGOTIATION_DISABLED] unsafe legacy renegotiation disabled (_ssl.c:1000)')))
During handling of the above exception, another exception occurred:
SSLError Traceback (most recent call last)
...
SSLError: HTTPSConnectionPool(host='bufftoon.plaync.com', port=443): Max retries exceeded with url: /series/1001216 (Caused by SSLError(SSLError(1, '[SSL: UNSAFE_LEGACY_RENEGOTIATION_DISABLED] unsafe legacy renegotiation disabled (_ssl.c:1000)')))
```
## Additional Information
I conducted tests on both Python 3.11.4 and Python 3.12.0rc3, and the outcomes were as follows:
**Python 3.11.4 (tags/v3.11.4:d2340ef, Jun 7 2023, 05:45:37) [MSC v.1934 64 bit (AMD64)]:**
```
<Response [200]>
```
**Python 3.12.0rc3 (tags/v3.12.0rc3:b973ab3, Sep 19 2023, 09:39:54) [MSC v.1935 64 bit (AMD64)]:**
```
The SSL error as described above.
```
## System Information
Here's the system information for Python 3.11.4 and Python 3.12:
**Python 3.11.4:**
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.2.0"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "CPython",
"version": "3.11.4"
},
"platform": {
"release": "10",
"system": "Windows"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "1010115f"
},
"urllib3": {
"version": "2.0.5"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
**Python 3.12.0rc3:**
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.2.0"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "CPython",
"version": "3.12.0rc3"
},
"platform": {
"release": "11",
"system": "Windows"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "300000a0"
},
"urllib3": {
"version": "2.0.5"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
Please help investigate this issue as it appears to be specific to Python 3.12 and is causing disruptions in accessing this website. Thank you. | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 3,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 3,
"url": "https://api.github.com/repos/psf/requests/issues/6537/reactions"
} | https://api.github.com/repos/psf/requests/issues/6537/timeline | null | completed | null | null | false | [
"That exact error is coming from the `ssl` module. It's not an issue with requests. I would determine what needs to be done to an SSLContext to allow you to connect and then plumb that through requests via a custom adapter for that site only. ",
"@sigmavirus24 Thanks for your response. I understand that the error is originating from the ssl module and not specifically from requests. However, I'm still puzzled about a few aspects:\r\n\r\n1. What's causing this issue in Python 3.12 but not in Python 3.11.4? Are there specific changes or updates in Python 3.12 that might be triggering this SSL error?\r\n\r\n2. Why is a custom adapter necessary to access the website while standard web browsers have no trouble?\r\n\r\nIf this isn't considered an error, could you provide any recommendations for potential solutions involving a custom adapter?",
"We use the standard cipher suites from the stdlib/OpenSSL. There may be a change there causing you problems. You could use a tool to compare them like Wireshark but that isn't something we will help you with. \n\nBrowsers don't use OpenSSL. They're also usually far more permissive to avoid complaints like this. https://stackoverflow.com/a/71646353 Should help you",
"See also https://github.com/urllib3/urllib3/issues/2653",
"@sigmavirus24 Thank you. I will use the adapter you recommended.",
"For complete implementation in code -> https://gist.github.com/FluffyDietEngine/94c0137445555a418ac9f332edfa6f4b",
"You need install cryptography==36.0.2"
] |
https://api.github.com/repos/psf/requests/issues/6536 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6536/labels{/name} | https://api.github.com/repos/psf/requests/issues/6536/comments | https://api.github.com/repos/psf/requests/issues/6536/events | https://github.com/psf/requests/issues/6536 | 1,910,185,397 | I_kwDOABTKOs5x2x21 | 6,536 | Requests are blocked by cloudflare inside docker | {
"avatar_url": "https://avatars.githubusercontent.com/u/51841352?v=4",
"events_url": "https://api.github.com/users/GabrielYudenich/events{/privacy}",
"followers_url": "https://api.github.com/users/GabrielYudenich/followers",
"following_url": "https://api.github.com/users/GabrielYudenich/following{/other_user}",
"gists_url": "https://api.github.com/users/GabrielYudenich/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/GabrielYudenich",
"id": 51841352,
"login": "GabrielYudenich",
"node_id": "MDQ6VXNlcjUxODQxMzUy",
"organizations_url": "https://api.github.com/users/GabrielYudenich/orgs",
"received_events_url": "https://api.github.com/users/GabrielYudenich/received_events",
"repos_url": "https://api.github.com/users/GabrielYudenich/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/GabrielYudenich/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/GabrielYudenich/subscriptions",
"type": "User",
"url": "https://api.github.com/users/GabrielYudenich",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2023-09-24T10:30:26Z | 2023-09-24T10:42:03Z | 2023-09-24T10:42:00Z | NONE | null | Hello to all, i need some help here
I have a code where i need to post a URL to get the autorization of the cookies and then i get this cookies and do another request in the website
It's a goverment thing, and i really need some help
When i use this script on my computer i can use it normally but when i upload in the container on docker (in my vps) i get "403" and i cannot continue my code
Someone can help me?
Anyone had an similar issue?
Everything is correct, the certificate path, the user and password, everything... But i keep being blocked by cloudflare
The HTML message of cloudflare and the 403 on docker:
Thank you all!
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6536/reactions"
} | https://api.github.com/repos/psf/requests/issues/6536/timeline | null | completed | null | null | false | [
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here."
] |
https://api.github.com/repos/psf/requests/issues/6535 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6535/labels{/name} | https://api.github.com/repos/psf/requests/issues/6535/comments | https://api.github.com/repos/psf/requests/issues/6535/events | https://github.com/psf/requests/issues/6535 | 1,909,870,866 | I_kwDOABTKOs5x1lES | 6,535 | Getting incorrect response. | {
"avatar_url": "https://avatars.githubusercontent.com/u/39483475?v=4",
"events_url": "https://api.github.com/users/TheAnkurGoswami/events{/privacy}",
"followers_url": "https://api.github.com/users/TheAnkurGoswami/followers",
"following_url": "https://api.github.com/users/TheAnkurGoswami/following{/other_user}",
"gists_url": "https://api.github.com/users/TheAnkurGoswami/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/TheAnkurGoswami",
"id": 39483475,
"login": "TheAnkurGoswami",
"node_id": "MDQ6VXNlcjM5NDgzNDc1",
"organizations_url": "https://api.github.com/users/TheAnkurGoswami/orgs",
"received_events_url": "https://api.github.com/users/TheAnkurGoswami/received_events",
"repos_url": "https://api.github.com/users/TheAnkurGoswami/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/TheAnkurGoswami/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/TheAnkurGoswami/subscriptions",
"type": "User",
"url": "https://api.github.com/users/TheAnkurGoswami",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
}
] | closed | true | null | [] | null | 1 | 2023-09-23T13:20:46Z | 2023-09-24T10:42:26Z | 2023-09-24T10:42:23Z | NONE | null | I was downloading an image using following python code:
```python
import requests
from PIL import Image
from io import BytesIO
link = "https://coloredmanga.com/wp-content/uploads/WP-manga/data/manga_6173003824249/85d69f8667f073e69cd03154b09f1412/149.jpg"
res = requests.get(link)
img = Image.open(BytesIO(res.content)) # PIL is unable to parse the image because of wrong response body.
```
## Expected Result
This code should download the image successfully, as the image can easily be downloaded using browser and postman.
## Actual Result
I tried running the same code two times. First time it was successful. But when I again ran it, it failed.
I printed first 100 bytes of the response in both cases.
**Case 1: Successful download**
```python
>>> res.content[:100]
b'\xff\xd8\xff\xe1)\xdcExif\x00\x00MM\x00*\x00\x00\x00\x08\x00\x0c\x01\x00\x00\x03\x00\x00\x00\x01\x05\xf0\x00\x00\x01\x01\x00\x03\x00\x00\x00\x01\t`\x00\x00\x01\x02\x00\x03\x00\x00\x00\x03\x00\x00\x00\x9e\x01\x06\x00\x03\x00\x00\x00\x01\x00\x02\x00\x00\x01\x12\x00\x03\x00\x00\x00\x01\x00\x01\x00\x00\x01\x15\x00\x03\x00\x00\x00\x01\x00\x03\x00\x00\x01\x1a\x00\x05\x00\x00'
```
**Case 2: Failure**
```python
>>> res.content[:100]
b'\xa5\xff\x7f1\n\xe9iq\xc6\x83\x88jR\x0f\x80:R\x17\xfe\xfc\xf9\xf7G\xc80\xb7\xff\xfc\xba\xff_\xfb\x0c\xef\xf5<@I`\x03\x9c\xe0\n\xb5\x0f\xb0JI\xf2\x0c\xe0\xdc\xa6\xa8\x18\x84T^\x04$"\xae"\xd1\x02\x12-\xd5Ry\x15\x89h\x91\xa8\xb8R)\xd5\xd2\x12\xf5S\x87\xff\x1b\x9e\xe6\xf6\x8f\x0c\x03\x8c\x9a\xb3\x89\x15,\x98\x0c'
```
## Reproduction Steps
Use the snippet above
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": "5.2.0"
},
"charset_normalizer": {
"version": "3.2.0"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "CPython",
"version": "3.8.18"
},
"platform": {
"release": "10",
"system": "Windows"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "300000a0"
},
"urllib3": {
"version": "2.0.4"
},
"using_charset_normalizer": false,
"using_pyopenssl": false
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6535/reactions"
} | https://api.github.com/repos/psf/requests/issues/6535/timeline | null | completed | null | null | false | [
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here."
] |
https://api.github.com/repos/psf/requests/issues/6534 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6534/labels{/name} | https://api.github.com/repos/psf/requests/issues/6534/comments | https://api.github.com/repos/psf/requests/issues/6534/events | https://github.com/psf/requests/issues/6534 | 1,907,691,310 | I_kwDOABTKOs5xtQ8u | 6,534 | Requests seems not to send the session cookie back to the server | {
"avatar_url": "https://avatars.githubusercontent.com/u/11373728?v=4",
"events_url": "https://api.github.com/users/flixman/events{/privacy}",
"followers_url": "https://api.github.com/users/flixman/followers",
"following_url": "https://api.github.com/users/flixman/following{/other_user}",
"gists_url": "https://api.github.com/users/flixman/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/flixman",
"id": 11373728,
"login": "flixman",
"node_id": "MDQ6VXNlcjExMzczNzI4",
"organizations_url": "https://api.github.com/users/flixman/orgs",
"received_events_url": "https://api.github.com/users/flixman/received_events",
"repos_url": "https://api.github.com/users/flixman/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/flixman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/flixman/subscriptions",
"type": "User",
"url": "https://api.github.com/users/flixman",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2023-09-21T20:14:40Z | 2023-09-21T22:14:34Z | 2023-09-21T22:14:28Z | NONE | null | I have a flask application, and I want to interact with it through requests. To this end, I have coded a small script providing a client that is supposed to keep around jwt and CSFR tokens that are sent back by the server:
```python
from http import HTTPStatus
from typing import Callable
import requests
from requests import Response
class AuthenticatedClient:
def __init__(self, base_url: str, email: str, password: str):
self._client = requests.Session()
self._base_url = base_url.rstrip('/')
response = self.post('/api/auth/login', json=dict(email=email, password=password))
if response.status_code != HTTPStatus.OK:
raise RuntimeError('Authentication did not succeed')
def _get_csfr(self, kwargs) -> None:
response = self._client.get(f'{self._base_url}/api/csrf')
kwargs['headers'] = kwargs.get('headers', {}) | {'X-CSRF-Token': response.json()['csrf']}
def _action(self, method: Callable, url: str, *args, **kwargs) -> Response:
url = url.lstrip('/')
return method(f'{self._base_url}/{url}', *args, **kwargs)
def get(self, url, *args, **kwargs) -> Response:
return self._action(self._client.get, url, *args, **kwargs)
def put(self, url, *args, **kwargs) -> Response:
self._get_csfr(kwargs)
return self._action(self._client.put, url, *args, **kwargs)
def post(self, url, *args, **kwargs) -> Response:
self._get_csfr(kwargs)
return self._action(self._client.post, url, *args, **kwargs)
def delete(self, url, *args, **kwargs) -> Response:
self._get_csfr(kwargs)
return self._action(self._client.delete, url, *args, **kwargs)
def __enter__(self):
return self
def __exit__(self, exc_type, exc_val, exc_tb):
self._client.close()
if __name__ == "__main__":
credentials = dict(email='[email protected]', password='mypassword')
# get an authenticated client
with AuthenticatedClient('http://127.0.0.1:5000', **credentials) as client:
# get all the lists for the user, and request their deletion
lists = client.get('/api/todolists')
```
## Expected Result
I would expect to get something back on the "lists" variable, given that the credentials are correct.
## Actual Result
I am getting an error due to the CSRF validation. Upon inspection of the trace with wireshark, I can conclude that the session cookie is being received and stored when doing the get for the CSRF token, but is not sent with the POST request when the AuthenticatedClient object is initialized.
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.2.0"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "CPython",
"version": "3.11.5"
},
"platform": {
"release": "6.5.3-arch1-1",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "30100020"
},
"urllib3": {
"version": "2.0.4"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6534/reactions"
} | https://api.github.com/repos/psf/requests/issues/6534/timeline | null | not_planned | null | null | false | [
"Duplicate of #6344 and so many more\n\nIn the future, please search **closed and** open issues before creating new ones that are duplicates."
] |
https://api.github.com/repos/psf/requests/issues/6533 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6533/labels{/name} | https://api.github.com/repos/psf/requests/issues/6533/comments | https://api.github.com/repos/psf/requests/issues/6533/events | https://github.com/psf/requests/issues/6533 | 1,907,343,398 | I_kwDOABTKOs5xr8Am | 6,533 | Retries don't work using a session adapter with empty prefix ("") | {
"avatar_url": "https://avatars.githubusercontent.com/u/4631191?v=4",
"events_url": "https://api.github.com/users/matthewarmand/events{/privacy}",
"followers_url": "https://api.github.com/users/matthewarmand/followers",
"following_url": "https://api.github.com/users/matthewarmand/following{/other_user}",
"gists_url": "https://api.github.com/users/matthewarmand/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/matthewarmand",
"id": 4631191,
"login": "matthewarmand",
"node_id": "MDQ6VXNlcjQ2MzExOTE=",
"organizations_url": "https://api.github.com/users/matthewarmand/orgs",
"received_events_url": "https://api.github.com/users/matthewarmand/received_events",
"repos_url": "https://api.github.com/users/matthewarmand/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/matthewarmand/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/matthewarmand/subscriptions",
"type": "User",
"url": "https://api.github.com/users/matthewarmand",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2023-09-21T16:23:11Z | 2024-09-21T00:07:10Z | 2023-09-21T22:10:40Z | CONTRIBUTOR | resolved | When using a Requests `Session` with an `HTTPAdapter` with `urllib3.util.Retry` configuration supplied, when the adapter is bound to an empty string prefix (`""`), the retries don't execute.
## Expected Result
This was an attempt to set up a session where every request in the session would have the retries executed, regardless of the prefix. A glance at the Requests `Session` source code seems to indicate this should work... the empty string can be a key in the `OrderedDict` storing the `Session`'s adapters, and checking `url.startswith("")` should return `True`. However...
## Actual Result
The retry configuration is ignored, and you're given a `Response` object with the erroneous error code instead of a raised `requests.exceptions.RetryError`. When binding the Adapter to the session with an actual prefix (for example, `"https://"`), the Retry behavior is observed.
## Reproduction Steps
The below script can be run to show the behavior, and below that I've posted the output I receive from it.
```python
from requests import Session
from requests.adapters import HTTPAdapter
from requests.exceptions import RetryError
from urllib3.util import Retry
class LogRetry(Retry):
def __init__(self, *args, **kwargs):
total_retries = kwargs["total"]
print(f"Retry {total_retries} initiating...")
super().__init__(*args, **kwargs)
def test_case(retry_clazz, prefix):
s = Session()
s.mount(
prefix,
HTTPAdapter(
max_retries=retry_clazz(
total=3,
backoff_factor=0.1,
status_forcelist=[500],
allowed_methods={"POST"},
)
),
)
try:
print(f"Trying with retry class {retry_clazz}, prefix: {prefix}")
s.post("https://httpbin.org/status/500", {})
except RetryError:
print("Got the retry error, hooray!")
else:
print("Didn't get the retry error, oh no!")
test_case(Retry, "https://")
test_case(Retry, "")
test_case(LogRetry, "https://")
test_case(LogRetry, "")
```
Results:
```
Trying with retry class <class 'urllib3.util.retry.Retry'>, prefix: https://
Got the retry error, hooray!
Trying with retry class <class 'urllib3.util.retry.Retry'>, prefix:
Didn't get the retry error, oh no!
Retry 3 initiating...
Trying with retry class <class '__main__.LogRetry'>, prefix: https://
Retry 2 initiating...
Retry 1 initiating...
Retry 0 initiating...
Retry -1 initiating...
Got the retry error, hooray!
Retry 3 initiating...
Trying with retry class <class '__main__.LogRetry'>, prefix:
Didn't get the retry error, oh no!
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": "5.2.0"
},
"charset_normalizer": {
"version": null
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "CPython",
"version": "3.11.5"
},
"platform": {
"release": "6.5.3-arch1-1",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.28.2"
},
"system_ssl": {
"version": "30100030"
},
"urllib3": {
"version": "1.26.15"
},
"using_charset_normalizer": false,
"using_pyopenssl": false
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 2,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 2,
"url": "https://api.github.com/repos/psf/requests/issues/6533/reactions"
} | https://api.github.com/repos/psf/requests/issues/6533/timeline | null | not_planned | null | null | false | [
"We use the longest match and document that. So if you do not remove the other adapters this doesn't work and it is the intended behavior ",
"Ah, you must be referring to the implicit adapters defined on `Session` instantiation at https://github.com/psf/requests/blob/881281250f74549f560408e5546d95a8cd73ce28/src/requests/sessions.py#L448. So that means in order to make this work, you'd have to do something like...\r\n\r\n```python\r\ns = Session()\r\ns.adapters.clear()\r\ns.mount(\"\", HTTPAdapter(.....))\r\n```\r\n\r\nThat makes sense, thanks. This is one area of requests where the documentation could be much clearer. Would it be appropriate to continue extending the Advanced Usage section I added in https://github.com/psf/requests/pull/6258 (https://requests.readthedocs.io/en/latest/user/advanced/#example-automatic-retries) with some of these additional details/gotchas? Or would it be better to start a different place in the docs for more in-depth documentation?"
] |
https://api.github.com/repos/psf/requests/issues/6532 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6532/labels{/name} | https://api.github.com/repos/psf/requests/issues/6532/comments | https://api.github.com/repos/psf/requests/issues/6532/events | https://github.com/psf/requests/issues/6532 | 1,902,644,892 | I_kwDOABTKOs5xaA6c | 6,532 | Exhaustively reading content from Response, doesn't call close on the non-stream request. | {
"avatar_url": "https://avatars.githubusercontent.com/u/325643?v=4",
"events_url": "https://api.github.com/users/CharString/events{/privacy}",
"followers_url": "https://api.github.com/users/CharString/followers",
"following_url": "https://api.github.com/users/CharString/following{/other_user}",
"gists_url": "https://api.github.com/users/CharString/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/CharString",
"id": 325643,
"login": "CharString",
"node_id": "MDQ6VXNlcjMyNTY0Mw==",
"organizations_url": "https://api.github.com/users/CharString/orgs",
"received_events_url": "https://api.github.com/users/CharString/received_events",
"repos_url": "https://api.github.com/users/CharString/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/CharString/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/CharString/subscriptions",
"type": "User",
"url": "https://api.github.com/users/CharString",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2023-09-19T10:08:29Z | 2024-09-20T00:04:07Z | 2023-09-19T13:40:17Z | NONE | resolved | <!-- Summary. -->
Iterating the full, non-stream content of a `Response` flags the content as consumed:
https://github.com/psf/requests/blob/881281250f74549f560408e5546d95a8cd73ce28/src/requests/models.py#L832
Which in turn prevents the raw object being closed.
https://github.com/psf/requests/blob/881281250f74549f560408e5546d95a8cd73ce28/src/requests/models.py#L1021-L1028
This can result in a bunch of open resources waiting for GC to happen. I ran into this using the zeep library to read a couple of wsdl documents files, which can do a lot of requests for xsd documents using `file://` scheme; it raised a ResourceError too many open files.
mvantellingen/python-zeep#1393
## Expected Result
Since it is explicitly stated in the docs that when you want to manipulate `Response.raw` you need to set `stream`, I expect the reading in the non-stream case of the generator https://github.com/psf/requests/blob/881281250f74549f560408e5546d95a8cd73ce28/src/requests/models.py#L826-L830
to be done in a `contextmanagers.closing` block, so it will always be properly closed, even when exceptions occur. To protect the naive Human™ like myself.
## System Information
```json
{
"chardet": {
"version": "5.1.0"
},
"charset_normalizer": {
"version": "2.0.2"
},
"cryptography": {
"version": "41.0.3"
},
"idna": {
"version": "2.10"
},
"implementation": {
"name": "CPython",
"version": "3.10.12"
},
"platform": {
"release": "6.1.0-0.deb11.11-amd64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "30100020",
"version": "23.2.0"
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "101010ef"
},
"urllib3": {
"version": "1.26.15"
},
"using_charset_normalizer": false,
"using_pyopenssl": true
}
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6532/reactions"
} | https://api.github.com/repos/psf/requests/issues/6532/timeline | null | completed | null | null | false | [
"Requests is written first and foremost to leverage urllib3. It assumes that adapters will behave as urllib3 does (i.e., consuming the socket closes it). If the `file://` adapter that is used by zeep and either written by them or provided by some other library is not doing the correct thing there, that is not a requests bug.\r\n\r\nLooking quickly at zeep's dependencies, they're using `requests-file` (which also looks largely unmaintained and more-or-less abandoned).\r\n\r\nSpecifically, https://github.com/dashea/requests-file/blob/675c7a6849bd5b2c271b503a3f51ea65599b34ec/requests_file.py#L87 seems like the fastest route but not necessarily the wisest. That said, looking at that code, they also set `release_conn` as an alias to `close` on that object here https://github.com/dashea/requests-file/blob/675c7a6849bd5b2c271b503a3f51ea65599b34ec/requests_file.py#L88 and https://github.com/dashea/requests-file/blob/675c7a6849bd5b2c271b503a3f51ea65599b34ec/requests_file.py#L106 which playing with that in a local REPL seems to work despite my expectation it wouldn't.\r\n\r\nSo looking back to _all_ of our `close` method (which hasn't been updated in 7 years), we have a fallback to that: https://github.com/psf/requests/blob/881281250f74549f560408e5546d95a8cd73ce28/src/requests/models.py#L1021-L1032 which would work if close were called.\r\n\r\nIn other words, if you're running into a GC issue with too many file handles open, something else either in zeep or your code is hanging on to unclosed file handles."
] |
https://api.github.com/repos/psf/requests/issues/6531 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6531/labels{/name} | https://api.github.com/repos/psf/requests/issues/6531/comments | https://api.github.com/repos/psf/requests/issues/6531/events | https://github.com/psf/requests/issues/6531 | 1,899,680,943 | I_kwDOABTKOs5xOtSv | 6,531 | How can I translate a page to English when scraping with requests python | {
"avatar_url": "https://avatars.githubusercontent.com/u/103885606?v=4",
"events_url": "https://api.github.com/users/Kamal-Moha/events{/privacy}",
"followers_url": "https://api.github.com/users/Kamal-Moha/followers",
"following_url": "https://api.github.com/users/Kamal-Moha/following{/other_user}",
"gists_url": "https://api.github.com/users/Kamal-Moha/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Kamal-Moha",
"id": 103885606,
"login": "Kamal-Moha",
"node_id": "U_kgDOBjErJg",
"organizations_url": "https://api.github.com/users/Kamal-Moha/orgs",
"received_events_url": "https://api.github.com/users/Kamal-Moha/received_events",
"repos_url": "https://api.github.com/users/Kamal-Moha/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Kamal-Moha/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Kamal-Moha/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Kamal-Moha",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2023-09-17T06:55:39Z | 2024-09-17T00:03:35Z | 2023-09-17T10:46:08Z | NONE | resolved | I'm trying to scrape the site [roca](https://roca.com.br/imovel/locacao/casas/sao-carlos/jardim-sao-carlos/66857?hl=en). This page is in Portuguese language, but I want to have translated into English so that I can capture English content when scraping with requests.
I have tried doing the below option of using Accepted-Language as I saw on [stackoverflow] (https://stackoverflow.com/questions/43572267/i-get-translated-text-when-i-do-a-get-request-in-python-how-to-get-english-co)
```
url = r'https://roca.com.br/imovel/locacao/casas/sao-carlos/jardim-sao-carlos/66857'
headers = {"Accept-Language": "en-US,en;q=0.5"}
response = requests.get(url, headers=headers).text # get content of URL (webpage), save to variable response
soup = BeautifulSoup(response,'html.parser') # create a new object using html parse
name = soup.select('div.Divisor__StyledDiv-sc-gc9tdc-1 h1')
print(f'House Name: {name[0].text}')
```
But when I run the above code, it still prints in Portuguese which I don't want. Please help | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6531/reactions"
} | https://api.github.com/repos/psf/requests/issues/6531/timeline | null | not_planned | null | null | false | [
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here."
] |
https://api.github.com/repos/psf/requests/issues/6530 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6530/labels{/name} | https://api.github.com/repos/psf/requests/issues/6530/comments | https://api.github.com/repos/psf/requests/issues/6530/events | https://github.com/psf/requests/issues/6530 | 1,896,279,797 | I_kwDOABTKOs5xBu71 | 6,530 | Automatically Close Requests Session After Specified Timeout, Even with Retries | {
"avatar_url": "https://avatars.githubusercontent.com/u/120313946?v=4",
"events_url": "https://api.github.com/users/shoval-c/events{/privacy}",
"followers_url": "https://api.github.com/users/shoval-c/followers",
"following_url": "https://api.github.com/users/shoval-c/following{/other_user}",
"gists_url": "https://api.github.com/users/shoval-c/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/shoval-c",
"id": 120313946,
"login": "shoval-c",
"node_id": "U_kgDOByvYWg",
"organizations_url": "https://api.github.com/users/shoval-c/orgs",
"received_events_url": "https://api.github.com/users/shoval-c/received_events",
"repos_url": "https://api.github.com/users/shoval-c/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/shoval-c/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shoval-c/subscriptions",
"type": "User",
"url": "https://api.github.com/users/shoval-c",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2023-09-14T10:34:35Z | 2024-09-15T00:04:22Z | 2023-09-14T11:20:15Z | NONE | resolved | **Desc**
Currently, when using the requests library in Python to create a session with a timeout and there are retries implemented within the request, the session remains open even after the specified timeout has elapsed. This behavior can lead to resource leakage and unexpected behavior when managing sessions with timeouts.
**Proposal:**
Add functionality to automatically close a requests session after a specified timeout, even if there are retries in the request itself. This enhancement would improve the library's usability and ensure that sessions are properly managed, even in cases involving retries.
**Use Case:**
As a developer, I often need to make HTTP requests with retries in case of transient errors. However, I also need to ensure that the session is closed after a certain timeout to prevent resource leaks. This feature would enable me to have both retry functionality and automatic session closure without having to implement custom solutions.
**Suggested Implementation:**
One way to implement this feature is to introduce an optional session_timeout parameter when creating a session or making requests. This parameter would specify the maximum duration the session can remain open, and if the timeout is reached, the session would be closed automatically, regardless of ongoing retries.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6530/reactions"
} | https://api.github.com/repos/psf/requests/issues/6530/timeline | null | not_planned | null | null | false | [
"In the future, please search **closed and** open issues before creating new ones that are duplicates."
] |
https://api.github.com/repos/psf/requests/issues/6529 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6529/labels{/name} | https://api.github.com/repos/psf/requests/issues/6529/comments | https://api.github.com/repos/psf/requests/issues/6529/events | https://github.com/psf/requests/pull/6529 | 1,896,100,712 | PR_kwDOABTKOs5aUXU_ | 6,529 | Update models.Response.json docstring to be clearer | {
"avatar_url": "https://avatars.githubusercontent.com/u/118899211?v=4",
"events_url": "https://api.github.com/users/anupam-arista/events{/privacy}",
"followers_url": "https://api.github.com/users/anupam-arista/followers",
"following_url": "https://api.github.com/users/anupam-arista/following{/other_user}",
"gists_url": "https://api.github.com/users/anupam-arista/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/anupam-arista",
"id": 118899211,
"login": "anupam-arista",
"node_id": "U_kgDOBxZCCw",
"organizations_url": "https://api.github.com/users/anupam-arista/orgs",
"received_events_url": "https://api.github.com/users/anupam-arista/received_events",
"repos_url": "https://api.github.com/users/anupam-arista/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/anupam-arista/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anupam-arista/subscriptions",
"type": "User",
"url": "https://api.github.com/users/anupam-arista",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 1 | 2023-09-14T09:01:07Z | 2024-07-01T05:16:42Z | null | NONE | null | null | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6529/reactions"
} | https://api.github.com/repos/psf/requests/issues/6529/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6529.diff",
"html_url": "https://github.com/psf/requests/pull/6529",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6529.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6529"
} | true | [
"I know I'm not an admin, but this doc string change is a solid change could it be merged? "
] |
https://api.github.com/repos/psf/requests/issues/6528 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6528/labels{/name} | https://api.github.com/repos/psf/requests/issues/6528/comments | https://api.github.com/repos/psf/requests/issues/6528/events | https://github.com/psf/requests/issues/6528 | 1,895,568,519 | I_kwDOABTKOs5w_BSH | 6,528 | Why encoding hard coding to "ISO-8859-1" | {
"avatar_url": "https://avatars.githubusercontent.com/u/14230710?v=4",
"events_url": "https://api.github.com/users/lizhaode/events{/privacy}",
"followers_url": "https://api.github.com/users/lizhaode/followers",
"following_url": "https://api.github.com/users/lizhaode/following{/other_user}",
"gists_url": "https://api.github.com/users/lizhaode/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lizhaode",
"id": 14230710,
"login": "lizhaode",
"node_id": "MDQ6VXNlcjE0MjMwNzEw",
"organizations_url": "https://api.github.com/users/lizhaode/orgs",
"received_events_url": "https://api.github.com/users/lizhaode/received_events",
"repos_url": "https://api.github.com/users/lizhaode/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lizhaode/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lizhaode/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lizhaode",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2023-09-14T02:56:26Z | 2024-09-15T00:04:21Z | 2023-09-14T13:18:36Z | NONE | resolved | <!-- Summary. -->
## Expected Result
UTF-8 is better
<!-- What you expected. -->
## Actual Result
ISO-8859-1
<!-- What happened instead. -->
## Reproduction Steps
I wanna download subtitle content, here is the code
```python
import requests
requests.get('https://events-delivery.apple.com/1008yunfyueoofvvgxpjmmvcblgnjsel/vod_main_bTVAkbqTcJuRovcmMRYungakLuiQyTWT/cc/zh/zh_0.webvtt',
headers={
'Accept-Language': 'zh-CN,zh;q=0.9,en;q=0.8',
'User-Agent': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36',}.text
```
I found response.text is garble
through read code, found this snippet in "utils.py" on "def get_encoding_from_headers(headers)"
```python
if "text" in content_type:
return "ISO-8859-1"
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.1.0"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "CPython",
"version": "3.11.4"
},
"platform": {
"release": "21.6.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "30100020"
},
"urllib3": {
"version": "2.0.2"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6528/reactions"
} | https://api.github.com/repos/psf/requests/issues/6528/timeline | null | not_planned | null | null | false | [
"You need to look at the response headers. The response is not providing an explicit `charset` otherwise we'd exit with this condition: https://github.com/psf/requests/blob/881281250f74549f560408e5546d95a8cd73ce28/src/requests/utils.py#L548\r\n\r\nUTF-8 has increasingly become the \"default\" for newer sites, but Requests has to handle all content old and new. The easiest thing for any newer site to do is to properly specify it's `charset` because that's been supported since HTTP/1.0 if I remember correctly. \r\n\r\nSince your site is not specifying an encoding explicitly, Requests uses the next most common encoding if it can predict that the content is either `text/plain` or `text/html`. After that it'll use an external library to guess. You can always override the encoding yourself if you know what you care to use.\r\n\r\nIn the future, please search **closed and** open issues before creating new ones that are duplicates. There are **many** past issues discussing exactly tihs."
] |
https://api.github.com/repos/psf/requests/issues/6527 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6527/labels{/name} | https://api.github.com/repos/psf/requests/issues/6527/comments | https://api.github.com/repos/psf/requests/issues/6527/events | https://github.com/psf/requests/pull/6527 | 1,894,678,362 | PR_kwDOABTKOs5aPkk5 | 6,527 | Autoclose specific issue templates | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
},
{
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
}
] | null | 0 | 2023-09-13T14:36:49Z | 2024-10-11T00:04:24Z | 2023-10-11T16:29:20Z | CONTRIBUTOR | resolved | We spend a fair amount of time closing issues because people don't read the template closely or understand what they're being told. Let's take advantage of being able to auto-label an issue based on the template and then trigger a workflow to auto-magically close the issue with a message and lock the issue. | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6527/reactions"
} | https://api.github.com/repos/psf/requests/issues/6527/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6527.diff",
"html_url": "https://github.com/psf/requests/pull/6527",
"merged_at": "2023-10-11T16:29:20Z",
"patch_url": "https://github.com/psf/requests/pull/6527.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6527"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/6526 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6526/labels{/name} | https://api.github.com/repos/psf/requests/issues/6526/comments | https://api.github.com/repos/psf/requests/issues/6526/events | https://github.com/psf/requests/issues/6526 | 1,892,614,335 | I_kwDOABTKOs5wzwC_ | 6,526 | open core legacy patcher | {
"avatar_url": "https://avatars.githubusercontent.com/u/144814817?v=4",
"events_url": "https://api.github.com/users/baquer147/events{/privacy}",
"followers_url": "https://api.github.com/users/baquer147/followers",
"following_url": "https://api.github.com/users/baquer147/following{/other_user}",
"gists_url": "https://api.github.com/users/baquer147/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/baquer147",
"id": 144814817,
"login": "baquer147",
"node_id": "U_kgDOCKGy4Q",
"organizations_url": "https://api.github.com/users/baquer147/orgs",
"received_events_url": "https://api.github.com/users/baquer147/received_events",
"repos_url": "https://api.github.com/users/baquer147/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/baquer147/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/baquer147/subscriptions",
"type": "User",
"url": "https://api.github.com/users/baquer147",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2023-09-12T14:11:34Z | 2024-09-12T00:04:24Z | 2023-09-12T14:20:04Z | NONE | resolved | hello, i am facing a error while downloading the ventura file from open core legacy patcher, it downloads 2GB from 11.9 gb and a error comes Download failed:
HTTPSConnectionPool(host='swcdn.apple.com', port=443): Read timed out
please help me with this
thankyou | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6526/reactions"
} | https://api.github.com/repos/psf/requests/issues/6526/timeline | null | completed | null | null | false | [
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here."
] |
https://api.github.com/repos/psf/requests/issues/6525 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6525/labels{/name} | https://api.github.com/repos/psf/requests/issues/6525/comments | https://api.github.com/repos/psf/requests/issues/6525/events | https://github.com/psf/requests/issues/6525 | 1,890,483,063 | I_kwDOABTKOs5wrnt3 | 6,525 | Getting 500 with Requests.get whereas Postman gives 400 | {
"avatar_url": "https://avatars.githubusercontent.com/u/42774628?v=4",
"events_url": "https://api.github.com/users/dbellani/events{/privacy}",
"followers_url": "https://api.github.com/users/dbellani/followers",
"following_url": "https://api.github.com/users/dbellani/following{/other_user}",
"gists_url": "https://api.github.com/users/dbellani/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dbellani",
"id": 42774628,
"login": "dbellani",
"node_id": "MDQ6VXNlcjQyNzc0NjI4",
"organizations_url": "https://api.github.com/users/dbellani/orgs",
"received_events_url": "https://api.github.com/users/dbellani/received_events",
"repos_url": "https://api.github.com/users/dbellani/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dbellani/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dbellani/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dbellani",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2023-09-11T13:12:06Z | 2024-09-12T00:04:26Z | 2023-09-11T16:39:49Z | NONE | resolved | Summary: For a Get API, The same url and token gives 400 status code in postman and when tried with pytest-bdd with requests library, I get 500
## Expected Result
For a invalid param, should be giving status code 400 in the response
## Actual Result
We get 500 status code though the request is exactly the same used in both places, please see below images
## Reproduction Steps
<img width="1273" alt="image"
<img width="694" alt="Screenshot 2023-09-11 at 6 28 37 PM" src="https://github.com/psf/requests/assets/42774628/5f66eacc-5fe6-4af6-b489-84f32081752f">
src="https://github.com/psf/requests/assets/42774628/86da23bb-5943-4bbb-9a11-84361155474b">
## System Information
pytest --version: 6.2.5
Python3 --version: 3.9.6
MacOS
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6525/reactions"
} | https://api.github.com/repos/psf/requests/issues/6525/timeline | null | completed | null | null | false | [
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here.\n\nThe server is returning a 500, not requests. Something is wrong in your setup",
"<img width=\"1273\" alt=\"image\" src=\"https://github.com/psf/requests/assets/42774628/a016bd9d-51ea-4afa-9bc8-c125f8930faa\">\r\n\r\n\r\nBut my request is same in both places, please refer this image.",
"Your images do not prove what you want them to nor are they searchable or accessible to those who need to use assistive devices like a screen reader. The requests are not identical and there are any number of prior issues here and answers on StackOverflow that can help you diagnose what the difference is."
] |
https://api.github.com/repos/psf/requests/issues/6524 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6524/labels{/name} | https://api.github.com/repos/psf/requests/issues/6524/comments | https://api.github.com/repos/psf/requests/issues/6524/events | https://github.com/psf/requests/issues/6524 | 1,890,017,482 | I_kwDOABTKOs5wp2DK | 6,524 | Requests honor env no_proxy but will not respect no_proxy when passed as proxies dictionary | {
"avatar_url": "https://avatars.githubusercontent.com/u/3580380?v=4",
"events_url": "https://api.github.com/users/chriskvik/events{/privacy}",
"followers_url": "https://api.github.com/users/chriskvik/followers",
"following_url": "https://api.github.com/users/chriskvik/following{/other_user}",
"gists_url": "https://api.github.com/users/chriskvik/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/chriskvik",
"id": 3580380,
"login": "chriskvik",
"node_id": "MDQ6VXNlcjM1ODAzODA=",
"organizations_url": "https://api.github.com/users/chriskvik/orgs",
"received_events_url": "https://api.github.com/users/chriskvik/received_events",
"repos_url": "https://api.github.com/users/chriskvik/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/chriskvik/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chriskvik/subscriptions",
"type": "User",
"url": "https://api.github.com/users/chriskvik",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2023-09-11T08:59:14Z | 2024-09-12T00:04:25Z | 2023-09-12T12:43:44Z | NONE | resolved | When working in a environment that uses proxies, most servers and clients will have proxy information set in their environment:
```
HTTP_PROXY=http://some-proxy.com:1234
HTTPS_PROXY=http://some-proxy.com:1234
NO_PROXY=example.com
```
Requests will respect these environment variables by default, meaning the following will work just fine.
```python
import requests
requests.get("https://example.com")
```
The snippet above will not use proxy, as specified with the `NO_PROXY` variable.
In requests we can also pass a proxy dict to requests, like this:
``` python
proxies = {
"http": "http://some-proxy.com:1234",
"https": "http://some-proxy.com:1234",
"no": "example.com" # Don't use the proxy for requests to example.com
}
requests.get("https://example.com", proxies=proxies)
```
But this wont work, request does not honor the `no` directive when passing proxies directly.
## Expected Result
I expect requests to bypass proxy when issuing a get towards example.com
## Actual Result
Requests tries to contact the proxy
## Reproduction Steps
See example above
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "3.2.0"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.4"
},
"implementation": {
"name": "CPython",
"version": "3.11.3"
},
"platform": {
"release": "6.2.0-31-generic",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.31.0"
},
"system_ssl": {
"version": "30000020"
},
"urllib3": {
"version": "2.0.4"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6524/reactions"
} | https://api.github.com/repos/psf/requests/issues/6524/timeline | null | completed | null | null | false | [
"Duplicate of #5000"
] |
https://api.github.com/repos/psf/requests/issues/6523 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6523/labels{/name} | https://api.github.com/repos/psf/requests/issues/6523/comments | https://api.github.com/repos/psf/requests/issues/6523/events | https://github.com/psf/requests/pull/6523 | 1,888,745,855 | PR_kwDOABTKOs5Z7vtH | 6,523 | Pass response_kw to HTTPConnectionPool through HTTPAdapter.send | {
"avatar_url": "https://avatars.githubusercontent.com/u/7031489?v=4",
"events_url": "https://api.github.com/users/joren485/events{/privacy}",
"followers_url": "https://api.github.com/users/joren485/followers",
"following_url": "https://api.github.com/users/joren485/following{/other_user}",
"gists_url": "https://api.github.com/users/joren485/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/joren485",
"id": 7031489,
"login": "joren485",
"node_id": "MDQ6VXNlcjcwMzE0ODk=",
"organizations_url": "https://api.github.com/users/joren485/orgs",
"received_events_url": "https://api.github.com/users/joren485/received_events",
"repos_url": "https://api.github.com/users/joren485/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/joren485/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/joren485/subscriptions",
"type": "User",
"url": "https://api.github.com/users/joren485",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 7 | 2023-09-09T13:36:06Z | 2023-09-16T12:02:39Z | null | CONTRIBUTOR | null | ### Summary
This PR adds kwargs arguments to `HTTPAdapter.send`, which it passes to `HTTPConnectionPool.urlopen` in urllib3.
### Description
As discussed in #4956, urrllib3 recently changed the default value of `enforce_content_length` from `False` to `True`. The new default seems like a sane choice, but in some use cases the `Content-Length` header should not be enforced. To change the default behavior, urllib3 allows application code to set the `enforce_content_length` argument. As far as I know, `requests` does not have a way to pass this argument to urllib3.
The `HTTPConnectionPool.urlopen` method in urllib3 has the `**response_kw` kwargs argument to pass extra arguments down to the response parser. This PR adds a similar to argument to `HTTPAdapter.send`.
With this PR, users can override the `HTTPAdapter.send` method to pass extra arguments to `HTTPConnectionPool.urlopen`. For example, this enables users to explicitly set the `enforce_content_length`.
### Example
```Python
import requests
from requests.adapters import HTTPAdapter
class EnforceContentLengthAdapter(HTTPAdapter):
def send(self, *args, **kwargs):
kwargs["enforce_content_length"] = False
return super().send(*args, **kwargs)
s = requests.Session()
s.mount("http://", EnforceContentLengthAdapter())
s.mount("https://", EnforceContentLengthAdapter())
r = s.get("http://localhost:8080/")
print(r.raw.enforce_content_length) # Returns False
``` | null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6523/reactions"
} | https://api.github.com/repos/psf/requests/issues/6523/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6523.diff",
"html_url": "https://github.com/psf/requests/pull/6523",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6523.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6523"
} | true | [
"Hi @joren485 ,\r\n\r\nRequests is under a feature freeze. Further, even though this _may_ seem like a backwards compatible change, it in fact will likely cause issues for a good percentage of users if they are unware. Many people implement customer HTTPAdapters for various reasons and I'd estimate at least 50% copy the exact signature out of requests when they write the code and don't expect to need to update things after the fact. This effectively expands the signature in a way that isn't backwards compatible as now, someone may start using a library that has too permissive of a lower bound on requests with an adapter that requires this and it will cause confusing and unexpected errors in passing too many arguments. This will cost countless people an unnecessary amount of time trying to debug things.\r\n\r\nWith that in mind, I could see a potential benefit to adding a separate attribute on the HTTPAdapter that is not added to any function signature (i.e., not to `__init__`, `send`, etc.) and is pickled properly that is a dictionary of `urllib3_response_options`, e.g.,\r\n\r\n```py\r\nself.urllib3_response_options = {}\r\n```\r\n\r\nAs the default that could then be updated with `self.urllib3_response_options.setdefault(\"enforce_content_length\", True)`. This could then be used in https://github.com/psf/requests/blob/881281250f74549f560408e5546d95a8cd73ce28/src/requests/adapters.py#L485-L497 where I would create a copy of the dictionary and then override it with what we have in the kwargs to that call, and the explode (`**`) into the `urlopen` call.\r\n\r\nDoes that make sense to you?",
"@sigmavirus24\r\n\r\nThat definitely makes sense to me! I pushed a first version of your idea. Is this what you had in mind?\r\n\r\nIt would work like this:\r\n```Python\r\nimport requests\r\n\r\nfrom requests.adapters import HTTPAdapter\r\n\r\n\r\nclass EnforceContentLengthAdapter(HTTPAdapter):\r\n def __init__(self, *args, **kwargs):\r\n super().__init__(*args, **kwargs)\r\n self.urllib3_response_options.setdefault(\"enforce_content_length\", False)\r\n\r\n\r\ns = requests.Session()\r\ns.mount(\"http://\", EnforceContentLengthAdapter())\r\ns.mount(\"https://\", EnforceContentLengthAdapter())\r\n\r\nr = s.get(\"http://localhost:8080/\")\r\nprint(r.raw.enforce_content_length)\r\n```\r\n\r\nI am aware of the feature freeze, but I dot not consider this change a feature, but rather backwards compatibility as the default behavior of requests has changed. Is this PR allowed?",
"@sigmavirus24 I implemented your suggestions.\r\n\r\nI removed the need for `self.urllib3_response_options.copy()` by providing `**self.urllib3_response_options` directly to `urlopen`, because it minimizes the code changes and looks cleaner imo. This way, user code is still not able to override the given arguments (and only provide new arguments like `enforce_content_length`), as providing duplicate arguments throws a `TypeError`. \r\n\r\nHowever, if you prefer the use of a separate dictionary with `self.urllib3_response_options.copy()`, I will happily change it back.\r\n",
"@nateprewitt Thank you very much for your suggestions, I am happy to implement them. @sigmavirus24 do you agree with the suggested changes?\r\n\r\n> I understand the use case, although it's fairly straightforward to work around.\r\n\r\nCould you expand on this? The only way to work around the new `enforce_content_length` behavior, that I know of, is to monkey patch `urllib3`. Do you have a better workaround?\r\n\r\n\r\n\r\n",
"> The only way to work around the new enforce_content_length behavior, that I know of, is to monkey patch urllib3\n\nYou can inherit from the adapter and override the send method that you are modifying here.\n\nYou could also create a pool manager that sets this parameter and set it on the adapter. Specifically, a Pool manager accepts ConnectionPool kwargs and the Connection Pool accepts response kwargs.\n\nHonestly, it's probably best to update the adapter to pass this to how we create the pool manager now that we're talking about it. It will be far fewer copies and updates here and will look like how folks can already use this today ",
"Sorry for the twists here @joren485. I've been reviewing this entirely from my phone so much harder to review docs etc at the same time and make a better decision ",
"> You can inherit from the adapter and override the send method that you are modifying here.\r\n\r\nI wanted to prevent the need for such an override with this PR, as `HTTPAdapter.send` is quite a large method and overriding it to change a single call in the middle of the method would require manually copying any upstream changes.\r\n \r\n> You could also create a pool manager that sets this parameter and set it on the adapter. Specifically, a Pool manager accepts ConnectionPool kwargs and the Connection Pool accepts response kwargs.\r\n\r\nI do not see how this would work, as the `connection_pool_kw` kwargs set by `PoolManager._new_pool` are not used in `HTTPConnectionPool.urlopen` (or `HTTPConnectionPool._make_request`). `PoolManager` does not seem to have control over the arguments passed to `HTTPConnectionPool.urlopen`. Please correct me if I am wrong."
] |
https://api.github.com/repos/psf/requests/issues/6522 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6522/labels{/name} | https://api.github.com/repos/psf/requests/issues/6522/comments | https://api.github.com/repos/psf/requests/issues/6522/events | https://github.com/psf/requests/pull/6522 | 1,886,595,787 | PR_kwDOABTKOs5Z0eOO | 6,522 | Response Object Code cleanup suggestions | {
"avatar_url": "https://avatars.githubusercontent.com/u/8212743?v=4",
"events_url": "https://api.github.com/users/xxdunedainxx/events{/privacy}",
"followers_url": "https://api.github.com/users/xxdunedainxx/followers",
"following_url": "https://api.github.com/users/xxdunedainxx/following{/other_user}",
"gists_url": "https://api.github.com/users/xxdunedainxx/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/xxdunedainxx",
"id": 8212743,
"login": "xxdunedainxx",
"node_id": "MDQ6VXNlcjgyMTI3NDM=",
"organizations_url": "https://api.github.com/users/xxdunedainxx/orgs",
"received_events_url": "https://api.github.com/users/xxdunedainxx/received_events",
"repos_url": "https://api.github.com/users/xxdunedainxx/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/xxdunedainxx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xxdunedainxx/subscriptions",
"type": "User",
"url": "https://api.github.com/users/xxdunedainxx",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2023-09-07T21:41:42Z | 2024-09-10T00:04:24Z | 2023-09-07T23:05:53Z | NONE | resolved | Any thoughts here?
I felt like the exception driven logic of `ok()` wasn't ideal, so I went in an added a new method: `is_raisable_status()`, which basically checks if the response code is 400 or more (could be improved?).
Also put `reason = self.decode_reason()` reason decoding into its own method.
If theres interest in getting this change pushed thru, I'll put in the effort to get unit tests updated and written, and update some of the method documentation 😂 | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6522/reactions"
} | https://api.github.com/repos/psf/requests/issues/6522/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6522.diff",
"html_url": "https://github.com/psf/requests/pull/6522",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6522.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6522"
} | true | [
"Hi @xxdunedainxx,\n\nI don't think this is something we'd accept as it breaks the established behavior of the API which we wouldn't do in the current minor version.\n\nWe'll pass on this for now, but thanks for the contribution."
] |
https://api.github.com/repos/psf/requests/issues/6521 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6521/labels{/name} | https://api.github.com/repos/psf/requests/issues/6521/comments | https://api.github.com/repos/psf/requests/issues/6521/events | https://github.com/psf/requests/issues/6521 | 1,883,910,942 | I_kwDOABTKOs5wSjMe | 6,521 | upload a photo and copy link | {
"avatar_url": "https://avatars.githubusercontent.com/u/137342194?v=4",
"events_url": "https://api.github.com/users/Pana11/events{/privacy}",
"followers_url": "https://api.github.com/users/Pana11/followers",
"following_url": "https://api.github.com/users/Pana11/following{/other_user}",
"gists_url": "https://api.github.com/users/Pana11/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Pana11",
"id": 137342194,
"login": "Pana11",
"node_id": "U_kgDOCC-s8g",
"organizations_url": "https://api.github.com/users/Pana11/orgs",
"received_events_url": "https://api.github.com/users/Pana11/received_events",
"repos_url": "https://api.github.com/users/Pana11/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Pana11/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Pana11/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Pana11",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2023-09-06T12:28:00Z | 2024-09-09T00:07:26Z | 2023-09-06T15:59:07Z | NONE | resolved | import requests
url = 'https://scanqr.org/'
responde2 = requests.get(url)
files = {'file': open('ph.jpg', 'rb')}
response = requests.post(url, files=files)
print(response.text)
print(responde2.text)
This is a site for scanning the QR code, that is, you upload the picture of the QR code, then it shows the link related to the QR code.
I uploaded a photo using the requests library and got the output before and after, but there is no difference between the outputs
If I expected, give me the link in the output after uploading
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6521/reactions"
} | https://api.github.com/repos/psf/requests/issues/6521/timeline | null | completed | null | null | false | [
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here."
] |
https://api.github.com/repos/psf/requests/issues/6520 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/6520/labels{/name} | https://api.github.com/repos/psf/requests/issues/6520/comments | https://api.github.com/repos/psf/requests/issues/6520/events | https://github.com/psf/requests/pull/6520 | 1,881,022,943 | PR_kwDOABTKOs5ZhkKh | 6,520 | Create python-app.yml | {
"avatar_url": "https://avatars.githubusercontent.com/u/10506498?v=4",
"events_url": "https://api.github.com/users/leonardoadame/events{/privacy}",
"followers_url": "https://api.github.com/users/leonardoadame/followers",
"following_url": "https://api.github.com/users/leonardoadame/following{/other_user}",
"gists_url": "https://api.github.com/users/leonardoadame/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/leonardoadame",
"id": 10506498,
"login": "leonardoadame",
"node_id": "MDQ6VXNlcjEwNTA2NDk4",
"organizations_url": "https://api.github.com/users/leonardoadame/orgs",
"received_events_url": "https://api.github.com/users/leonardoadame/received_events",
"repos_url": "https://api.github.com/users/leonardoadame/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/leonardoadame/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/leonardoadame/subscriptions",
"type": "User",
"url": "https://api.github.com/users/leonardoadame",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2023-09-05T01:17:53Z | 2024-09-05T00:04:05Z | 2023-09-05T02:07:57Z | NONE | resolved | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6520/reactions"
} | https://api.github.com/repos/psf/requests/issues/6520/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/6520.diff",
"html_url": "https://github.com/psf/requests/pull/6520",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6520.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6520"
} | true | [
"Hi @leonardoadame, I'm not sure it makes sense to add this to Requests. We already have testing infrastructure set up and it appears this was lifted from another project. We'll go ahead and close this out."
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.