input
stringlengths 1
18.7k
| output
stringlengths 1
18.7k
|
|---|---|
basically just having two repos in one repo? sure
| but these are almost logically separated, you can do better than that
Yee it is not 2 repos, its discreet usecases
|
but these are almost logically separated, you can do better than that
Yee it is not 2 repos, its discreet usecases
| yeah that’s fine, as long as you can have different top level dirs
|
yeah that’s fine, as long as you can have different top level dirs
| Okay gotcha this makes sense, and in the case that we want to have the same top level directory is that also possible?
|
Okay gotcha this makes sense, and in the case that we want to have the same top level directory is that also possible?
| I was just going to type that, that should be possible as well
so it becomes complicated Vrinda Vasavada if you try to import without the right dependencies installed across the 2 files
otherwise it is entirely possible
this is the registration command - <https://github.com/lyft/flytesnacks/blob/master/cookbook/Makefile#L30>
|
I was just going to type that, that should be possible as well
so it becomes complicated Vrinda Vasavada if you try to import without the right dependencies installed across the 2 files
otherwise it is entirely possible
this is the registration command - <https://github.com/lyft/flytesnacks/blob/master/cookbook/Makefile#L30>
| so long as there is a distinct break somewhere, some parent that bifurcates all the tasks/workflows, it’ll be fine, it doesn’t have to be at the root of the repo.
|
so long as there is a distinct break somewhere, some parent that bifurcates all the tasks/workflows, it’ll be fine, it doesn’t have to be at the root of the repo.
| yup, Yee so the real thing that differentiates the “discovery” of all tasks and workflows is the “config” file
for example, we will find all workflows in - <https://github.com/lyft/flytesnacks/blob/master/cookbook/sandbox.config#L2> recursively
Vrinda Vasavada if you have any questions, let us know, we should probably add an example in this repo
|
yup, Yee so the real thing that differentiates the “discovery” of all tasks and workflows is the “config” file
for example, we will find all workflows in - <https://github.com/lyft/flytesnacks/blob/master/cookbook/sandbox.config#L2> recursively
Vrinda Vasavada if you have any questions, let us know, we should probably add an example in this repo
| okay so there should be some split in the directories and a separate config file for each, and then the different docker images in each?
|
okay so there should be some split in the directories and a separate config file for each, and then the different docker images in each?
| ideally yes.
|
ideally yes.
| gotcha, thank you!! :slightly_smiling_face: I'll let you know if I have any more questions as I implement
|
gotcha, thank you!! :slightly_smiling_face: I'll let you know if I have any more questions as I implement
| just for background, the link between a task and the image happens inside the task definition. currently at registration, the task will be populated by the value of the `FLYTE_INTERNAL_IMAGE` environment variable (which is set by the build script provided by flytekit). It’s overridable ofc. Figuring out how to allow users to specify arbitrary images for arbitrary tasks in a workflow is a mostly ux question i feel, and one that’s hard to do in a non-confusing way. But it’s definitely something we’ve been thinking about.
but not relevant for your case right now
|
Anand Swaminathan Katrina Rogan - Hongxin Liang seems to have found a bug <https://github.com/lyft/flyteadmin/pull/71/files#r475657367>
| Yeah
Just saw that. Wondering how I missed it, thought had a test to catch it.
|
Yeah
Just saw that. Wondering how I missed it, thought had a test to catch it.
| do you understand the impact? It seems that everytime there are missing resources, it will fail?
|
do you understand the impact? It seems that everytime there are missing resources, it will fail?
| Exactly. Hongxin Liang fix I believe is correct. In fact if you scroll few lines back, I have a debug statement for this case.
|
Exactly. Hongxin Liang fix I believe is correct. In fact if you scroll few lines back, I have a debug statement for this case.
| but then how can this work for sandbox?
I think we should fix this ASAP
|
but then how can this work for sandbox?
I think we should fix this ASAP
| Ketan Umare May be Sandbox does not use multi cluster?
|
Ketan Umare May be Sandbox does not use multi cluster?
| yeah i thought we only used this is in our actual lyft deployment
|
yeah i thought we only used this is in our actual lyft deployment
| This PR is correct <https://github.com/lyft/flyteadmin/pull/117/files>
|
This PR is correct <https://github.com/lyft/flyteadmin/pull/117/files>
| yeah we check if the resource is nil below before dereferencing
|
yeah we check if the resource is nil below before dereferencing
| Thanks for approving the PR. I will create a corresponding issue for tracking purpose and then merge it.
BTW this fails for non in-cluster setup, so it doesn’t need to be multiple clusters.
|
Thanks for approving the PR. I will create a corresponding issue for tracking purpose and then merge it.
BTW this fails for non in-cluster setup, so it doesn’t need to be multiple clusters.
| That’s the case- out of cluster
|
Katrina Rogan - Meet emiliza (from unity) she is trying to get Flyte up in GCP
she is failing to start `sync resources` because of this error
```{"json":{"src":"clusterresource.go:98"},"level":"fatal","msg":"Failed to sync cluster resources [Failed to create kubernetes object from config template [aa_namespace.yaml] for namespace [flyteexamples-development] with err: namespaces is forbidden: User \"system:serviceaccount:flyte:default\" cannot create resource \"namespaces\" in API group \"\" at the cluster scope, Failed to create kubernetes object from config template [aa_namespace.yaml] for namespace [flyteexamples-staging] with err: namespaces is forbidden: User \"system:serviceaccount:flyte:default\" cannot create resource \"namespaces\" in API group \"\" at the cluster scope, Failed to create kubernetes object from config template [aa_namespace.yaml] for namespace [flyteexamples-production] with err: namespaces is forbidden: User \"system:serviceaccount:flyte:default\" cannot create resource \"namespaces\" in API group \"\" at the cluster scope, Failed to create kubernetes object from config template [aa_namespace.yaml] for namespace [flytetester-development] with err: namespaces is forbidden: User \"system:serviceaccount:flyte:default\" cannot create resource \"namespaces\" in API group \"\" at the cluster scope, Failed to create kubernetes object from config template [aa_namespace.yaml] for namespace [flytetester-staging] with err: namespaces is forbidden: User \"system:serviceaccount:flyte:default\" cannot create resource \"namespaces\" in API group \"\" at the cluster scope, Failed to create kubernetes object from config template [aa_namespace.yaml] for namespace [flytetester-production] with err: namespaces is forbidden: User \"system:serviceaccount:flyte:default\" cannot create resource \"namespaces\" in API group \"\" at the cluster scope, Failed to create kubernetes object from config template [aa_namespace.yaml] for namespace [flytesnacks-development] with err: namespaces is forbidden: User \"system:serviceaccount:flyte:default\" cannot create resource \"namespaces\" in API group \"\" at the cluster scope, Failed to create kubernetes object from config template [aa_namespace.yaml] for namespace [flytesnacks-staging] with err: namespaces is forbidden: User \"system:serviceaccount:flyte:default\" cannot create resource \"namespaces\" in API group \"\" at the cluster scope, Failed to create kubernetes object from config template [aa_namespace.yaml] for namespace [flytesnacks-production] with err: namespaces is forbidden: User \"system:serviceaccount:flyte:default\" cannot create resource \"namespaces\" in API group \"\" at the cluster scope]","ts":"2020-08-24T20:24:21Z"}```
it seems her RBAC is wrongly configured for Admin
| it looks like admin isn't using the flyteadmin role
|
it looks like admin isn't using the flyteadmin role
| ya
|
ya
| should be this one <https://github.com/lyft/flyte/blob/master/kustomize/base/adminserviceaccount/adminserviceaccount.yaml#L6>
|
should be this one <https://github.com/lyft/flyte/blob/master/kustomize/base/adminserviceaccount/adminserviceaccount.yaml#L6>
| this is what i’ve got set for rbac:
```apiVersion: <http://rbac.authorization.k8s.io/v1|rbac.authorization.k8s.io/v1>
kind: ClusterRole
metadata:
name: flyteadmin
namespace: flyte
rules:
- apiGroups:
- ""
- <http://flyte.lyft.com|flyte.lyft.com>
- <http://rbac.authorization.k8s.io|rbac.authorization.k8s.io>
resources:
- configmaps
- flyteworkflows
- namespaces
- pods
- resourcequotas
- roles
- rolebindings
- secrets
- services
- serviceaccounts
- spark-role
verbs:
- '*'```
|
this is what i’ve got set for rbac:
```apiVersion: <http://rbac.authorization.k8s.io/v1|rbac.authorization.k8s.io/v1>
kind: ClusterRole
metadata:
name: flyteadmin
namespace: flyte
rules:
- apiGroups:
- ""
- <http://flyte.lyft.com|flyte.lyft.com>
- <http://rbac.authorization.k8s.io|rbac.authorization.k8s.io>
resources:
- configmaps
- flyteworkflows
- namespaces
- pods
- resourcequotas
- roles
- rolebindings
- secrets
- services
- serviceaccounts
- spark-role
verbs:
- '*'```
| emiliza it is what Katrina Rogan is saying, you need to have the role specified, i dont know how but somehow it was overriden in your kustomize?
|
emiliza it is what Katrina Rogan is saying, you need to have the role specified, i dont know how but somehow it was overriden in your kustomize?
| huh i wonder if it's because we specify the service account name here <https://github.com/lyft/flyte/blob/d3660d4a1a8f46d0246b8798a7e6fbbc58f7820a/kustomize/overlays/eks/admindeployment/cron.yaml#L12> but not here <https://github.com/lyft/flyte/blob/d3660d4a1a8f46d0246b8798a7e6fbbc58f7820a/kustomize/overlays/eks/admindeployment/admindeployment.yaml#L30> ?
emiliza is this failing on start-up or when the cron runs?
|
huh i wonder if it's because we specify the service account name here <https://github.com/lyft/flyte/blob/d3660d4a1a8f46d0246b8798a7e6fbbc58f7820a/kustomize/overlays/eks/admindeployment/cron.yaml#L12> but not here <https://github.com/lyft/flyte/blob/d3660d4a1a8f46d0246b8798a7e6fbbc58f7820a/kustomize/overlays/eks/admindeployment/admindeployment.yaml#L30> ?
emiliza is this failing on start-up or when the cron runs?
| on start-up
|
on start-up
| ooh okay i bet that could be it, since the cron has the correct service role - let me make a pr
|
ooh okay i bet that could be it, since the cron has the correct service role - let me make a pr
| i’ll add to my deployment and check it out
|
i’ll add to my deployment and check it out
| Katrina Rogan she is using the GCP overlay
that Spotify built, it might have a bug,
|
Katrina Rogan she is using the GCP overlay
that Spotify built, it might have a bug,
| can you link me?
|
can you link me?
| <https://github.com/lyft/flyte/pull/185/files>
yup it is missing in both EKS and in GCP
|
<https://github.com/lyft/flyte/pull/185/files>
yup it is missing in both EKS and in GCP
| the gcp admindeployment also appears to be missing the serviceaccount
|
the gcp admindeployment also appears to be missing the serviceaccount
| Thank you emiliza!
|
Thank you emiliza!
| i can update this pr instead, thanks for pointing this out
|
i can update this pr instead, thanks for pointing this out
| hmm, recreated the admin deployment and killed the `syncresources` pods but i’m still getting the same issue
|
hmm, recreated the admin deployment and killed the `syncresources` pods but i’m still getting the same issue
| oh sorry i had a meeting and wasn't yet able to update :sweat_smile:
mind pulling the latest and trying again emiliza
|
oh sorry i had a meeting and wasn't yet able to update :sweat_smile:
mind pulling the latest and trying again emiliza
| works now, thanks Katrina Rogan!
|
works now, thanks Katrina Rogan!
| great, glad to hear it!
|
great, glad to hear it!
| Thank you Katrina
|
Thank you Katrina
| completely different question: is there something else i’m supposed to install to get FlyteHub showing up in my flyte console? looking at importing <https://flytehub.org/objectdetector|ObjectDetector> and cant find this Hub :joy:
|
completely different question: is there something else i’m supposed to install to get FlyteHub showing up in my flyte console? looking at importing <https://flytehub.org/objectdetector|ObjectDetector> and cant find this Hub :joy:
| That is not supported in the mainline fork of Flyte
Why do you want Flyte hub?
|
That is not supported in the mainline fork of Flyte
Why do you want Flyte hub?
| just to import that objectdetector workflow
|
just to import that objectdetector workflow
| That example is available in flytesnacks
Just use that
Fastest way to get started
|
That example is available in flytesnacks
Just use that
Fastest way to get started
| hmm, i wasn’t actually able to get <https://lyft.github.io/flyte/user/getting_started/examples.html|flytesnacks> loaded properly. followed the example and got some errors:
``` $ docker run --network host -e FLYTE_PLATFORM_URL='http://<redacted admin ip>/' lyft/flytesnacks:v0.1.0 pyflyte -p flytesnacks -d development -c sandbox.config register workflows
Using configuration file at /app/sandbox.config
Flyte Admin URL http://<redacted admin ip>/
Running task, workflow, and launch plan registration for flytesnacks, development, ['workflows'] with version 46045e6383611da1cb763d64d846508806fce1a4
Registering Task: workflows.edges.edge_detection_canny
Traceback (most recent call last):
File "/app/venv/bin/pyflyte", line 11, in <module>
sys.exit(main())
File "/app/venv/lib/python3.6/site-packages/click/core.py", line 764, in __call__
return self.main(*args, **kwargs)
File "/app/venv/lib/python3.6/site-packages/click/core.py", line 717, in main
rv = self.invoke(ctx)
File "/app/venv/lib/python3.6/site-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/app/venv/lib/python3.6/site-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/app/venv/lib/python3.6/site-packages/click/core.py", line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/app/venv/lib/python3.6/site-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/app/venv/lib/python3.6/site-packages/click/decorators.py", line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File "/app/venv/lib/python3.6/site-packages/flytekit/clis/sdk_in_container/register.py", line 86, in workflows
register_all(project, domain, pkgs, test, version)
File "/app/venv/lib/python3.6/site-packages/flytekit/clis/sdk_in_container/register.py", line 24, in register_all
o.register(project, domain, name, version)
File "/app/venv/lib/python3.6/site-packages/flytekit/common/exceptions/scopes.py", line 158, in system_entry_point
return wrapped(*args, **kwargs)
File "/app/venv/lib/python3.6/site-packages/flytekit/common/tasks/task.py", line 141, in register
_engine_loader.get_engine().get_task(self).register(id_to_register)
File "/app/venv/lib/python3.6/site-packages/flytekit/engines/flyte/engine.py", line 234, in register
self.sdk_task
File "/app/venv/lib/python3.6/site-packages/flytekit/clients/friendly.py", line 50, in create_task
spec=task_spec.to_flyte_idl()
File "/app/venv/lib/python3.6/site-packages/flytekit/clients/raw.py", line 12, in handler
return fn(*args, **kwargs)
File "/app/venv/lib/python3.6/site-packages/flytekit/clients/raw.py", line 77, in create_task
return self._stub.CreateTask(task_create_request)
File "/app/venv/lib/python3.6/site-packages/grpc/_channel.py", line 604, in __call__
return _end_unary_response_blocking(state, call, False, None)
File "/app/venv/lib/python3.6/site-packages/grpc/_channel.py", line 506, in _end_unary_response_blocking
raise _Rendezvous(state, None, None, deadline)
grpc._channel._Rendezvous: <_Rendezvous of RPC that terminated with:
status = StatusCode.UNAVAILABLE
details = "DNS resolution failed"
debug_error_string = "{"created":"@1598317962.581326500","description":"Failed to pick subchannel","file":"src/core/ext/filters/client_channel/client_channel.cc","file_line":3876,"referenced_errors":[{"created":"@1598317962.581295600","description":"Resolver transient failure","file":"src/core/ext/filters/client_channel/resolving_lb_policy.cc","file_line":263,"referenced_errors":[{"created":"@1598317962.581287600","description":"DNS resolution failed","file":"src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc","file_line":357,"grpc_status":14,"referenced_errors":[{"created":"@1598317962.581256400","description":"C-ares status is not ARES_SUCCESS: Domain name not found","file":"src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_wrapper.cc","file_line":244,"referenced_errors":[{"created":"@1598317962.581099300","description":"C-ares status is not ARES_SUCCESS: Domain name not found","file":"src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_wrapper.cc","file_line":244}]}]}]}]}"```
|
hmm, i wasn’t actually able to get <https://lyft.github.io/flyte/user/getting_started/examples.html|flytesnacks> loaded properly. followed the example and got some errors:
``` $ docker run --network host -e FLYTE_PLATFORM_URL='http://<redacted admin ip>/' lyft/flytesnacks:v0.1.0 pyflyte -p flytesnacks -d development -c sandbox.config register workflows
Using configuration file at /app/sandbox.config
Flyte Admin URL http://<redacted admin ip>/
Running task, workflow, and launch plan registration for flytesnacks, development, ['workflows'] with version 46045e6383611da1cb763d64d846508806fce1a4
Registering Task: workflows.edges.edge_detection_canny
Traceback (most recent call last):
File "/app/venv/bin/pyflyte", line 11, in <module>
sys.exit(main())
File "/app/venv/lib/python3.6/site-packages/click/core.py", line 764, in __call__
return self.main(*args, **kwargs)
File "/app/venv/lib/python3.6/site-packages/click/core.py", line 717, in main
rv = self.invoke(ctx)
File "/app/venv/lib/python3.6/site-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/app/venv/lib/python3.6/site-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/app/venv/lib/python3.6/site-packages/click/core.py", line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/app/venv/lib/python3.6/site-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/app/venv/lib/python3.6/site-packages/click/decorators.py", line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File "/app/venv/lib/python3.6/site-packages/flytekit/clis/sdk_in_container/register.py", line 86, in workflows
register_all(project, domain, pkgs, test, version)
File "/app/venv/lib/python3.6/site-packages/flytekit/clis/sdk_in_container/register.py", line 24, in register_all
o.register(project, domain, name, version)
File "/app/venv/lib/python3.6/site-packages/flytekit/common/exceptions/scopes.py", line 158, in system_entry_point
return wrapped(*args, **kwargs)
File "/app/venv/lib/python3.6/site-packages/flytekit/common/tasks/task.py", line 141, in register
_engine_loader.get_engine().get_task(self).register(id_to_register)
File "/app/venv/lib/python3.6/site-packages/flytekit/engines/flyte/engine.py", line 234, in register
self.sdk_task
File "/app/venv/lib/python3.6/site-packages/flytekit/clients/friendly.py", line 50, in create_task
spec=task_spec.to_flyte_idl()
File "/app/venv/lib/python3.6/site-packages/flytekit/clients/raw.py", line 12, in handler
return fn(*args, **kwargs)
File "/app/venv/lib/python3.6/site-packages/flytekit/clients/raw.py", line 77, in create_task
return self._stub.CreateTask(task_create_request)
File "/app/venv/lib/python3.6/site-packages/grpc/_channel.py", line 604, in __call__
return _end_unary_response_blocking(state, call, False, None)
File "/app/venv/lib/python3.6/site-packages/grpc/_channel.py", line 506, in _end_unary_response_blocking
raise _Rendezvous(state, None, None, deadline)
grpc._channel._Rendezvous: <_Rendezvous of RPC that terminated with:
status = StatusCode.UNAVAILABLE
details = "DNS resolution failed"
debug_error_string = "{"created":"@1598317962.581326500","description":"Failed to pick subchannel","file":"src/core/ext/filters/client_channel/client_channel.cc","file_line":3876,"referenced_errors":[{"created":"@1598317962.581295600","description":"Resolver transient failure","file":"src/core/ext/filters/client_channel/resolving_lb_policy.cc","file_line":263,"referenced_errors":[{"created":"@1598317962.581287600","description":"DNS resolution failed","file":"src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc","file_line":357,"grpc_status":14,"referenced_errors":[{"created":"@1598317962.581256400","description":"C-ares status is not ARES_SUCCESS: Domain name not found","file":"src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_wrapper.cc","file_line":244,"referenced_errors":[{"created":"@1598317962.581099300","description":"C-ares status is not ARES_SUCCESS: Domain name not found","file":"src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_wrapper.cc","file_line":244}]}]}]}]}"```
| It is unable to find the admin endpoint
emiliza - here is the actual repo - <https://github.com/lyft/flytesnacks>
your error is `"DNS resolution failed"`
|
Hi all, video from today’s bi-weekly sync posted here: <https://drive.google.com/file/d/1V8IEpxS8sHtvDjkk7W-7BGNkOy_xB0sn/view?usp=sharing> Yee showed some alternative Python signatures for task execution with more or less syntax and implied context that he is considering for the next update of the Flytekit SDK. If you are an opinionated Python jock please take a look and comment, or better, submit an alternative PR. It’s important that we get this right because we’re going to be living with it for a long, long time.
| FYI Steven Kothen-Hill Marvin Bertin
|
FYI Steven Kothen-Hill Marvin Bertin
| I will be adding it to
The notes
|
Hello Everyone! :wave:
I’d like to ask advice about using `storage_request` / `storage_limit` for `python_tasks` tasks.
I thought that this value should appear in the Pod spec at `resources.*.ephemeral-storage` section but my assumptions were wrong
And I see in the Flytepropeller sources that it is the different k8s core type. Could you please advise how to use this properly?
Thank you in advance!
| Ruslan Stanevich whats the usecase?
|
Ruslan Stanevich whats the usecase?
| Looks like it should be PVC storage but I missed how I can use it :thinking_face:
HI Ketan
At the moment there is no use case that we could not solve, just curiosity when I saw this in the documentation :slightly_smiling_face:
|
Looks like it should be PVC storage but I missed how I can use it :thinking_face:
HI Ketan
At the moment there is no use case that we could not solve, just curiosity when I saw this in the documentation :slightly_smiling_face:
| thank you, yes so `storage-limits` are available only in the newer Kubernetes versions
and you are right, we are not patchng it to ephemeral storage we should
if you want to use PVC you have to use sidecar tasks (bad name)
|
thank you, yes so `storage-limits` are available only in the newer Kubernetes versions
and you are right, we are not patchng it to ephemeral storage we should
if you want to use PVC you have to use sidecar tasks (bad name)
| Yeah, I agree.
About the use cases. In fact, we have an example of a task that we are expecting a huge file with geographic data (which is very problematic to split).
And yes, we used sidecar_task for this as workaround. We are on EKS v1.17 now
|
Yeah, I agree.
About the use cases. In fact, we have an example of a task that we are expecting a huge file with geographic data (which is very problematic to split).
And yes, we used sidecar_task for this as workaround. We are on EKS v1.17 now
| ohh awesome
lets file an issue for storage support and you can help us validate it
|
ohh awesome
lets file an issue for storage support and you can help us validate it
| ah, thanks Ketan!
with great pleasure
|
Hi, it seems we are missing a few release tags here: <https://github.com/lyft/flyte/releases>.
| Which one?
|
Which one?
| 0.6 and 0.7 are missing
|
0.6 and 0.7 are missing
| that is my bad
the release has no real meaning here, but a tag
i will add the latest
Sören Brunk / Hongxin Liang created 0.7.0
i will go back in time and tag 0.6.0 later, unless you want it now
|
that is my bad
the release has no real meaning here, but a tag
i will add the latest
Sören Brunk / Hongxin Liang created 0.7.0
i will go back in time and tag 0.6.0 later, unless you want it now
| Cool. Thanks.
I often refer to release page for latest stuff. :)
|
Cool. Thanks.
I often refer to release page for latest stuff. :)
| ya fair, i think we should make the bot to release that automatically
|
Igor Valko question about the pytorch example
<https://github.com/lyft/flytesnacks/blob/master/plugins/pytorch/workflows/mnist.py#L148-L152>
I think this will not work for population size (mpi group size) greater than 1
| Hey Ketan!
What exact issue do you observe?
I’ve found in <https://pytorch.org/tutorials/beginner/saving_loading_models.html#saving-torch-nn-dataparallel-models|this tutorial> that model wrapped into DataParallel (i.e. distributed model) should be saved the following way
```torch.save(model.module.state_dict(), PATH)```
Is that the thing you’re talking about?
|
Hey Ketan!
What exact issue do you observe?
I’ve found in <https://pytorch.org/tutorials/beginner/saving_loading_models.html#saving-torch-nn-dataparallel-models|this tutorial> that model wrapped into DataParallel (i.e. distributed model) should be saved the following way
```torch.save(model.module.state_dict(), PATH)```
Is that the thing you’re talking about?
| so in Flyte, when you run the task, each task will startup with all the inputs and expect all the outputs
but in distributed training case, only one job really produces the output
so we need to ensure that only the master produces outputs (model) and for all other, outputs are ignored and/or not required
Chang-Hong Hsu ^
Kevin Su ^
|
All, I am working on cleaning up our Kustomize, do you think this will impact your deployments. We will try to release it in the next version. This should make it easier to configure and manage your overlays, but, it may break any existing overlays. Is that ok? I will share the PR
Jeev B Hongxin Liang emiliza Deepen Mehta Sören Brunk ^?
| No worries. We pin our kustomize bases by commit anyway so this shouldn’t affect us. Thanks for the heads up!
|
No worries. We pin our kustomize bases by commit anyway so this shouldn’t affect us. Thanks for the heads up!
| ok that is awesome. ya again i will share the PR. But I think this would clean up the kustomize quite a bit
|
ok that is awesome. ya again i will share the PR. But I think this would clean up the kustomize quite a bit
| Ketan Umare Please go ahead. We only use the Kustomize setup for testing cluster. Production is different as you know.
|
Ketan Umare Please go ahead. We only use the Kustomize setup for testing cluster. Production is different as you know.
| We're still in an early integration phase so :+1:
|
We're still in an early integration phase so :+1:
| Sören Brunk Jeev B Hongxin Liang Yee Deepen Mehta Please PR for me - <https://github.com/lyft/flyte/pull/510>
|
Does anyone have experience with kubernetes pod logging? I'm trying to get the kubernetes logs to show up with the corresponding node in the Flyte console but wondering if this is possible / if there are any examples I should be looking at?
| what currently shows up under the Logs section when you click on a task in the UI?
|
what currently shows up under the Logs section when you click on a task in the UI?
| Currently it just says No logs found
|
Currently it just says No logs found
| Vrinda Vasavada there are 2 options today - Stackdriver and/or kubernetes dashboard
It needs to be configured
I can help with that
|
Vrinda Vasavada there are 2 options today - Stackdriver and/or kubernetes dashboard
It needs to be configured
I can help with that
| Great thank you!
|
Hi. Is there a plan to publish `<http://docker.io/lyft/flyteadmin:v0.3.6|docker.io/lyft/flyteadmin:v0.3.6>`
| is that not published?
that should be done automatically
if not let me push it
Bye I forgot to tell you but I pushed it
|
anyone seen this error with flyteadmin:
```$ flyteadmin --logtostderr --config /etc/flyte/config/flyteadmin_config.yaml migrate seed-projects jeevb-sandbox
...
{"json":{"src":"seed_data.go:22"},"level":"warning","msg":"failed to save project [jeevb-sandbox]","ts":"2020-09-28T19:45:33Z"}
{"json":{"src":"migrate.go:122"},"level":"fatal","msg":"Could not add projects to database with err: pq: column \"labels\" of relation \"projects\" does not exist","ts":"2020-09-28T19:45:33Z"}```
running with: `<http://docker.io/lyft/flyteadmin:v0.3.5|docker.io/lyft/flyteadmin:v0.3.5>`
| you’re probably missing a migration
|
you’re probably missing a migration
| thanks for following up Yee. when are the migrations applied for flyteadmin?
im running the command after `flyteadmin` is up and running
|
thanks for following up Yee. when are the migrations applied for flyteadmin?
im running the command after `flyteadmin` is up and running
| hmm
|
hmm
| oh wait
|
oh wait
| that is unfortunately something that is deployment-specific. this is the migration in question <https://github.com/lyft/flyteadmin/commit/eb9236eea8af44791d87c0f4113b92d0da32fa0f#diff-d4e6d4b7fe6e051b604a13e2838a96ceR255>
|
that is unfortunately something that is deployment-specific. this is the migration in question <https://github.com/lyft/flyteadmin/commit/eb9236eea8af44791d87c0f4113b92d0da32fa0f#diff-d4e6d4b7fe6e051b604a13e2838a96ceR255>
| ah interesting. this is with a fresh sandbox. seems odd that it wont just work out of the box
|
ah interesting. this is with a fresh sandbox. seems odd that it wont just work out of the box
| 0.3.5 should definitely have it. and in the sandbox case, migrations are run as part of the init container <https://github.com/lyft/flyte/blob/master/deployment/sandbox/flyte_generated.yaml#L1150>
oops, wrong line
it absolutely should work out of the box.
|
0.3.5 should definitely have it. and in the sandbox case, migrations are run as part of the init container <https://github.com/lyft/flyte/blob/master/deployment/sandbox/flyte_generated.yaml#L1150>
oops, wrong line
it absolutely should work out of the box.
| ah i know why. this is user error. my apologies.
|
ah i know why. this is user error. my apologies.
| what was it?
|
what was it?
| we have specific kustomize overrides for images that i need to clean up.
|
we have specific kustomize overrides for images that i need to clean up.
| :ok_hand:
are you back from leave already?
|
:ok_hand:
are you back from leave already?
| yea just got back today
|
yea just got back today
| welcome back!
|
welcome back!
| thanks! :slightly_smiling_face:
|
Hey all, Am seeing a bizarre behaviour, not sure if it is expected or if i am doing something wrong:
I was uploading a workflow that uses `Types.Generic` and `[Types.Generic]` as an ouptut, and I was having issues because it seemed that the workflows where uploading successfully, but when i launch the workflow it does not include the tasks that used the `Types.Generic` outputs. I switched to `Types.Blob` and things worked again. any idea if that is expected?
| hmm this is weird
Yee should we write an example to reproduce this?
|
hmm this is weird
Yee should we write an example to reproduce this?
| for sure
|
for sure
| ok
i guess no other way
|
ok
i guess no other way
| if you don't mind copying/pasting code from your end Thomas that would be helpful too (but we understand there are IP concerns)
|
if you don't mind copying/pasting code from your end Thomas that would be helpful too (but we understand there are IP concerns)
| Thomas Vetterli i tried it quickly in this PR <https://github.com/lyft/flytesnacks/pull/40>
and it seems to work
maybe the version of flytekit?
|
Thomas Vetterli i tried it quickly in this PR <https://github.com/lyft/flytesnacks/pull/40>
and it seems to work
maybe the version of flytekit?
| ah awesome, will try a simple example on my end as well, see what happens. Thanks for trying it out
|
ah awesome, will try a simple example on my end as well, see what happens. Thanks for trying it out
| Sure let me know
|
Anand Swaminathan - Yuvraj (union.ai) has done amazing work by creating an interactive flyte tutorial. HE wants to improve the contents of the README. Can you please help him - basically PR and provide guidance on what content should be in each step of the tutorial
the PR is <https://github.com/lyft/flytesnacks/pull/41>
you can try it out here - <https://www.katacoda.com/yuvraj02>
Also Katrina Rogan Anmol Khurana Jeev B Yee anyone if you can comment on this PR and help Yuvraj (union.ai) - higly appreciated (I am a little busy today and tomorrow)
| :eyes:
|
Hi. When do we plan to cut a new release of flyteadmin?
| Yes Hongxin Liang the month end release is still pending
|
Yes Hongxin Liang the month end release is still pending
| Great, thanks! We are waiting for a stackdriver log link fix to be pushed out. Not urgent though.
|
Great, thanks! We are waiting for a stackdriver log link fix to be pushed out. Not urgent though.
| fyi Yee just cut <https://github.com/lyft/flyteadmin/releases/tag/v0.3.7>
|
fyi Yee just cut <https://github.com/lyft/flyteadmin/releases/tag/v0.3.7>
| Also I just cut v0.8.0
|
<!here> reminder everybody:
Flyte bi-weekly community sync tomorrow at 9:00 am Pacific. (4pm UTC) Chang-Hong Hsu will show off some Sagemaker integration for Flyte-orchestrated distributed ML training workflows. Ketan Umare will show off some of the great tutorial work Yuvraj (union.ai) has contributed.
Zoom: <https://us04web.zoom.us/j/71298741279?pwd=TDR1RUppQmxGaDRFdzBOa2lHN1dsZz09>
Meeting ID: 712 9874 1279
Password: 7stPGd
| Is there a recording of this that we can view George Snelling
|
Is there a recording of this that we can view George Snelling
| Ian very sorry, I forgot to post. Just a sec…
Looks like Zoom stores the recordings on the host’s local computer, which in this case is my home machine. I’ll return home in a few hours and will upload it then.
|
Ian very sorry, I forgot to post. Just a sec…
Looks like Zoom stores the recordings on the host’s local computer, which in this case is my home machine. I’ll return home in a few hours and will upload it then.
| No rush, so long as there is something can get it later.
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.