Observation about upscale
#3
by
theo77186
- opened
In the description of the upscale, I've seen this config:
slices:
- sources:
- model: zerofata/MS3.2-PaintedFantasy-v2-24B
layer_range: [0, 29] # layers 0 to 28
- sources:
- model: zerofata/MS3.2-PaintedFantasy-v2-24B
layer_range: [10, 39] # layers 10 to 38
But the layer_range is upper bound excluded, generating a 58 layers model, with the layer 39 from the original being never represented. Is that intentional or an oversight?
I know it's not clearly documented in mergekit, but I still feel like pointing it out.
This also affects the v1.
Hey,
Good spot, it was a counting fail I'd done the first time around. I'd noticed the layer count was one off what I'd expected, so this is helpful to know the reason why. Admittedly forgot to troubleshoot it before doing the v2, where I just reused the same layer config.