feat-rename-vector-type-0622
#21
by
nan
- opened
- remove redundant
_vectorin the vector types - use Enum for the vector types.
nan
changed pull request status to
open
LGTM
Minor comment: instead of
single (torch.Tensor): Single-vector embeddings of shape (batch_size, dim).
multi (torch.Tensor): Multi-vector embeddings of shape (batch_size, num_tokens, dim).
it should be single_vec_emb and multi_vec_emb.
nan
changed pull request status to
merged